This version of gwtorm contains an important bug-fix that ensures that
"LIMIT ?" is not omitted in generated queries [1]. This can improve the
performance of such queries by a large factor.
[1] https://gerrit-review.googlesource.com/57216
Change-Id: Ibd0d3918629b2901288de6dd2e85489e4503091a
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Based off https://gerrit-review.googlesource.com/#/c/52190, but
implementing the final suggestion of indexing raw delta counts and
allowing arbitrary range queries off of those.
Also upgrade Lucene to 4.8.1 as this was released since the last
schema change (which was on 4.7.0).
Change-Id: Ia8a677e71e133f68eced4c5394df1d23efe7f12a
* changes:
Buck: Rename gwtxml to gwt_xml in gwt_module()
Buck: Omit default values to gwt_binary() rule
Buck: Make gwt_module() rule more pythonic
Buck: Merge deps and compile_deps parameters in gwt_module() rule
Update Buck and use gwt_binary()
* stable-2.9:
Describe 'No Differences' label in review UI documentation
Describe red bar for line gaps in review UI documentation
Link new review UI documentation from 2.9 release notes
Add 'View Plugins' global capability that allows to list plugins
Keep new draft comment expanded if expand all comments is set
Allow to download reposize.sh script from Gerrit
Link new review UI documentation from new change screen welcome popup
Document major differences between old and new review UI
Describe keyboard shortcuts in review UI documentation
Describe navigation in patch file in review UI documentation
Describe Vim-like search in review UI documentation
Upgrade jgit to v3.4.0.201405051725-m7
Link 2.8.5 release notes from 2.9 release notes
Review UI docs: Update screenshot about navigation to show all arrows
Review UI Docs: Remove note about double-click not adding new comments
Describe diff preferences in review UI documentation
Add new screenshot that shows the result after replying with done
Describe navigation between patches in review UI documentation
Describe patch set selection and patch download in review UI docs
Conflicts:
lib/jgit/BUCK
Change-Id: I3b63776c5eed46406c93996b190f968e294f84eb
Maven artifact names on Google bucket replacing SNAPSHOT suffix with
timestamp. 731967591ef98ab3c94691ba9dc0f217630dda76 changed this by
preserving the SNAPSHOT suffix. This broke fetching of gwtorm and
gwtjsonrpc and was reverted by 731967591ef98ab3c94691ba9dc0f217630dda76.
This change fixes this for both worlds: stripping it for GERRIT and
GERRIT_API Maven repositories but preserving it for the rest.
Test plan:
maven_jar() is working as expected for the both worlds:
* gwtorm:gwtorm:1.10-SNAPSHOT-20140310.015132-1 (repo = GERRIT)
* org.eclipse.jgit:org.eclipse.jgit:3.4.0-SNAPSHOT (repo = MAVEN_LOCAL)
Change-Id: I5357abe9ad6a40538c444ad70016c8c6d75d8ff3
If a documentation txt file has no content, parsing the document title
from it in the DocIndexer fails with a NullPointerException:
Exception in thread "main" java.lang.NullPointerException
at java.util.regex.Matcher.getTextLength(Matcher.java:1234)
at java.util.regex.Matcher.reset(Matcher.java:308)
at java.util.regex.Matcher.<init>(Matcher.java:228)
at java.util.regex.Pattern.matcher(Pattern.java:1088)
at DocIndexer.index(DocIndexer.java:117)
at DocIndexer.invoke(DocIndexer.java:86)
at DocIndexer.main(DocIndexer.java:163)
Change-Id: Idb4b808847d326ba49c9a2494a95b1cad8eb9406
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Jetty by default provides set of MBeans that can be registered in JMX.
This patch adds new configuration option called httpd.registerMBeans, by
default set to false, to control this behavior.
Change-Id: I3771ed3bb755240d7d90e9f1f1d7e7f84ff33ce3
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
* stable-2.9:
SideBySide2: Fix failure to load from "ISE EditIterator out of bounds"
Explain in project owner guide how other tools can be integrated
Add section about continuous integration to project owner guide
Add section about download commands to project owner guide
Improve/extend documentation about branch administration
Describe issue tracker system integration in project owner guide
Remove "Click to" from topic edit button's tooltip
Fix: wrongly throw 'commit already exists' exception
Update sshd to 0.11.0
Bump SSHD version to 0.10.1 and enable nio2 backend
Add missing article "the" in access-control.txt
Add a section about project dashboards to project owner guide
Add section about email notifications to project owner guide
Describe labels and submit rules in project owner guide
Discontinue comment visibility strategy for new change screen
Conflicts:
lib/mina/BUCK
Change-Id: Icc05236165b825001bb4821ed0fa9a4e3a3b7b7b
* stable-2.8:
SideBySide2: Fix failure to load from "ISE EditIterator out of bounds"
Remove "Click to" from topic edit button's tooltip
Fix: wrongly throw 'commit already exists' exception
Update sshd to 0.11.0
Bump SSHD version to 0.10.1 and enable nio2 backend
Conflicts:
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Topic.ui.xml
Change-Id: I63c1e12bbd413a8e212de5b2a8cf71fa2a2ce52d
Fixes a few issues including a null pointer exception [1] that causes
ssh commands to hang.
It also adds server driven rekeying after 1G bytes of data transferred,
which is a useful security feature.
[1] https://issues.apache.org/jira/browse/SSHD-307
Change-Id: I441995eaf76e4fe53f7991f5aef00e062900791b
46f8488a78742799a4f5f781279c8955460e7964 removed nio2 backend because of
a bug [1]. Given that the bug is fixed and released, enable it again.
Another problem was also fixed and released [2].
Upgrade to the official version 0.10.1 makes Gerrit's own custom patch of
SSHD and hosting it on Google bucket unnecessary.
[1] https://issues.apache.org/jira/browse/SSHD-252
[2] https://issues.apache.org/jira/browse/SSHD-255
Bug: Issue 2406
Change-Id: I6668f6194427f153e1982e14b3936d2f3132fa7d
SAP MaxDB (http://maxdb.sap.com/) is now supported as a database.
Depends-On: I9385bafe481152ce0c1471f2a7f89b1db5abac80
Change-Id: Iae2ad25a3db3a1069b80cf5733c92882da86e404
In new buck version `$SRCDIR` is not necessary any more. Buck now
always runs genrule relative to the $SRCDIR link forest.
Change-Id: Iee88bb575c7baa62bc087527927be5347a7f8f95
Index alongside the "project" field, which is an exact match field,
since we do not assume index implementations can search exact match
and prefix on the same field. We do not want to modify the existing
"project" to return prefixes.
Upgrade Lucene to 4.7.0, as this was released since the last schema
change.
Change-Id: I7c3379c087fc54af3e5790cb875a5e676e674338
In upstream Buck's change 4addffb6bf8b9bc4123811a2739d20f25a8a927e:
... convert `HasJavaSrcs` and `SrcsAttributeBuilder` to using `Paths`
`sourceJar` parameter to prebuilt_jar rule was converted to path instead
of string. Source Jar must be prefetched together with binary artifact.
Change-Id: I94641c1b31786ec9ee27d19bcf5b8a7a9104bd31
Updates the versions of protobuf, asm and guava libraries to
synchronize with the versions used in GWT 2.6.0
Change-Id: Id1badda0d0f24f6022404be479d4681560ed0eda
This prevents gwtorm snapshots from being downloaded from the
Gerrit maven repository.
This reverts commit 731967591ef98ab3c94691ba9dc0f217630dda76.
Change-Id: I17aad32606d4afb1c0654ffca0747f660c148520
46f8488a78742799a4f5f781279c8955460e7964 removed nio2 backend because of
a bug [1]. Given that the bug is fixed and released, enable it again.
Another problem was also fixed and released [2].
Upgrade to the official version 0.10.1 makes Gerrit's own custom patch of
SSHD and hosting it on Google bucket unnecessary.
[1] https://issues.apache.org/jira/browse/SSHD-252
[2] https://issues.apache.org/jira/browse/SSHD-255
Bug: Issue 2406
Change-Id: I6668f6194427f153e1982e14b3936d2f3132fa7d
a283507bccbd408540ae1baf75eb80eb59dce031 disabled EditIteratorTest due
to gwt-test-utils uncompatibility with new GWT 2.6 release.
After fixing the compatibility problem in [1] the tests can be enabled
again.
[1] https://github.com/gwt-test-utils/gwt-test-utils/issues/62
Change-Id: I1f93e6422a1ae60d66f4d8b4abac23b6a1acb4f9
84a66d82d36d554c1844acff11d1a62f10c174ed added support for light and
dark themes, but dark themes weren't enabled, as diff styles have
to be adjusted to correspond with dark colors.
101a8c4b65ebee4d54afddad10db05f5b9698ba9 reverted the preparation
for dark themes support.
This change enables support for subset of dark themes and switch
dynamicaly the diff styles to dark colors, when dark theme was
selected.
Change-Id: Ic220baf8f19366c04520b61e893a0d11912805ef
Since JGit 3.1 archive command was implemented. Add it to download
drop down as new line.
The following libraries are introduced in this change:
* jgit-archive (Apache 2)
* commons-compress (Apache 2)
* tukaani-xz (Public domain)
Change-Id: I5f61aac8c434414c73585a9320e84f4430dd111d
This fixes a long standing bug in the copy and rename detection
code where a copied file that is also updating its mode loses its
copy status and breaks the diff display.
Change-Id: I15c4d61ff1489e2c9b17e3b9ca76d9dcc98e26a8
This checks that the email address has a valid format.
Change-Id: I1f8d95dd9b02e720996bd15cca093ca55b5e4597
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
