11 Commits

Author SHA1 Message Date
Viktar Donich
5eb59e374e Serve fonts from Gerrit instead of Google Fonts.
Bug: Issue 3985
Change-Id: I107921c7e1fbc02e3b279f4d834c16447dffde51
2016-04-01 13:11:02 -04:00
Urs Wolfer
0f537c7bbc Add support for running (single) tests with 'run-server.sh'
- include 'web-component-tester' bower dependency as test-dependency
- remove special handling for serving folder 'bower_components'
- add support for passing parameters from 'run-server.sh' to 'server.go'

Change-Id: Ia74b3013e07b6304a4df568b081254909749efc5
2016-03-30 20:01:33 +02:00
Han-Wen Nienhuys
12b8249957 PolyGerrit: use more explicit filenames for globbing files under app/test/ .
This prevents administrative editor files (backups, etc.) from
interfering with Buck.

Change-Id: Ie5dd6e981f4cab9e543ccf27b117da3b3fd8f34f
2016-03-29 15:19:31 +02:00
Urs Wolfer
634a67bf76 Fix running WCT tests
If1890b46f added *_test.html files to excludes. These files
need to be included when running tests though.

Change-Id: Ic6015cbb3079d909169e1e3d46bd1039d106860e
2016-03-14 17:12:02 +01:00
Andrew Bonventre
8e5ac9d92a Move fake-app.js to test folder
Also exclude *_test.html files from BUCK app glob

Change-Id: If1890b46ffb7d4657bdea83786de5262343835ff
2016-03-10 19:30:31 -05:00
Dave Borowitz
a562eea049 Don't rename vulcanized HTML outputs
This was trying too hard to look like the gulp build. We can just give
the vulcanized HTML the same name as the original files and avoid the
whole step where we process index.html.

Change-Id: I66c2f2848642106dd85be4e53ba55e3d05a78e1d
2015-12-04 13:27:45 -05:00
Dave Borowitz
d8a42b3c2a PolyGerrit: Run crisper after vulcanizing
This makes the app CSP compliant[1] by splitting out JS from HTML.

[1] http://www.html5rocks.com/en/tutorials/security/content-security-policy/#inline-code-considered-harmful

Change-Id: Ifec20c0d7ebcaab6df905a16c3621ecffb80ae98
2015-12-04 13:27:45 -05:00
Dave Borowitz
a75837c6b5 Don't cp -L when setting up PolyGerrit tests
cp -rL is not supported on OS X. Following symlinks was unnecessary
anyway, as none of the zip inputs are symlinks to begin with.

Change-Id: Id0cdda3eadc53544a14bafd3aa53d5a8dac4dbd5
2015-12-04 10:49:50 -05:00
David Ostrovsky
58cb4b4881 Update Buck to newest version
The new Buck version fixed annoying stdout spamming bug on unit test
failures: [1]. Now we can revert our monkey patching hack to prevent
that.

Since [2] Buck interferes with files in buck-out directory: [3]. Switch
to using eclipse-out directory as Eclipse output directory instead. For
this change it's necessary to clean up buck-out directory, otherwise
`buck test` would fail.

This version also fixed "Python client lost connection" bug: [4].

This reverts commit 94e93aaad22e67b5956627cff1a9cb84d03a29ec.

[1] https://github.com/facebook/buck/issues/505
[2] 35cb495b57
[3] https://github.com/facebook/buck/issues/527
[4] https://github.com/facebook/buck/issues/534

Change-Id: I4cd1a99ce9d0615713c235d873e6cdd61b1854bb
2015-12-02 14:07:12 +00:00
Dave Borowitz
c89f64cc7c Run PolyGerrit tests with Buck
Since Buck has no native support for web tests, wrap the tests in a
Python shim that calls wct. As in other Polymer cases, we need to
prepare a set of inputs and create a directory containing exactly what
wct expects to be there. Buck exposes resources to python_tests using
the pkg_resources API, which is cumbersome to use, and easier just to
ship around zip files as we do elsewhere.

Unlike other npm binaries we've encountered, the web-component-tester
module has numerous native dependencies, up to and including Selenium.
Rather than get in the game of distributing platform-specific
binaries, punt and require `wct` to be on the user's $PATH for now.

Tests are currently excluded in .buckconfig but can be run directly
with either:

  buck test //polygerrit-ui/app:polygerrit_tests
  buck test --include web

Change-Id: Ia314213925ac27ff271374a96ed539fb2acf0187
2015-11-25 11:14:05 -05:00
David Ostrovsky
be81e1f4b5 Vulcanize PolyGerrit in Buck build
Change-Id: Ie9baded31746a307bb257b69deeef41665821e9d
2015-11-18 15:26:39 -05:00