This will be the default in a future version of GWT. It is not
compatible with Gerrit's hacky server side selector. Get rid of
the hacky server selection and run only the stock code.
The new linker selection is compatible with Super Dev Mode.
Change-Id: I26c2ed184b6f336d4f964732023aa81d647a5e7c
Plugins may want to get notified when a pack file is received.
For example, the quota plugin may want to cache the repository
size in the file system and update it every time a new pack is
received.
Change-Id: I0212eab6e4867819ebe7ecc7fc5532c26bb82282
We cannot guarantee that secondary index implementations (particularly
the one used by googlesource.com) can efficiently paginate based on
the sortkey, and in particular can both sort and reverse sort on the
same field. This particular performance issue notwithstanding,
searching is now generally fast enough that it is feasible just to
skip the first N results when doing pagination.
Add an option S= to QueryChanges to support starting at a nonzero
offset. Note that we still have to fetch n+S results from the index in
order to do visibility filtering, since if we skipped at the index
layer we wouldn't know how many of the skipped elements would have
matched later filtering.
Drop the sortkey token suffix from the legacy anchor parser; there is
no reliable way to convert it to an offset, and it's unlikely that
users have permalinks to specific sortkey values.
On the server side, remove the sortkey field from the current index
version, and use pagination by offset instead of sortkey in the new
version only.
Continue to support sortkey queries against old index versions, to
support online reindexing while clients have an older JS version.
Change-Id: I6a82965db02c4d534e2107ca6ec91217085124d6
If a plugin has a REST collection that accepts PUT requests and the
REST view that handles these PUT requests is annotated with
@RequiresCapability to require a plugin capability then the validation
of this capability in Gerrit core fails since the plugin name is not
forwarded to the capability check. Because of the missing plugin name
the capability check is looking for a Gerrit core capability although
it should check for a plugin capability.
Change-Id: I9779bd04b4b849bd8c3646a3e226b07faf3e9cc3
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Plugins can register ReceivePackInitializer's in order to provide custom
initialization of the ReceivePack instance. For example, the quota plugin
may use this extension point to set the maximum allowed pack size based
on its quota configuration and the disk space occupied by that project.
Change-Id: I8d6e7d4bb75099b0fa5f6968ae5371883bf865ee
If a RestCollection in a plugin implements AcceptsPost POST requests
for it currently fail with Not Found.
Change-Id: I6db50cbe08c5ec53dac727d90af58fbe4538dbcf
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Allow plugins to contribute messages to the UI during initial page
load. Gerrit displays the messages in a butter bar at the top of
the page and allows users to hide them with the "Dismiss" button.
Messages are hidden per-browser using a cookie named after the
message id, set to expire at a date supplied by the server. After
this date the same message could redisplay if the server sends the
same message again.
Change-Id: I0bcca845f501cbeb8c31356fff398c3adb43099a
In a notedb world we would like to slurp all information about a
change from the git-based storage as soon as a ChangeResource is
constructed, which will involve extra work in this parse, analogous to
how parse currently validates the change permissions.
Preserve the ability to pass in a particular ChangeControl object,
since various callers have specific requirements like reusing the
control elsewhere, or using a control for a different user.
Change-Id: Ia7c9761ef92bb8f05ae3323210babaa02b0dbe6f
This class lives in gerrit-reviewdb because "refs/changes/" needs to be
referenced from PatchSet in reviewdb/client (and other UI classes).
Rename constants to all use REFS_* instead of being inconsistent.
Change-Id: I76e6ee7e63a4549b51a43698fb50b54a19dabfc6
The title text shown on the link to the bug tracker can be configured
in the gerrit.config file. If not set, it defaults to "Report Bug".
Bug: Issue 2318
Change-Id: I38c6057b96bf97fc96341621c9d8bbb49060dc40
The config provider will always provide a value. Either the
value given by the user in gerrit.config, or the default value.
Change-Id: I9b7107857c79f939ed5315e52610277b05ef7d67
It is not sufficient only to dispatch doFilter() methods. To initialize and
destroy filters, init() and destroy() methods must be honored.
Change-Id: I5b87583a212c4dc854cf205f2a57125b713736cb
Convert the new RPC data into the old data, just enough to keep the
old UI alive against a newer server. This will allow us to build a
final version of the old UI code and run it for quite some time
against a modern REST API.
Users who refuse to upgrade to ChangeScreen2 can run this frozen old
UI build until it no longer works.
Change-Id: Ieef15c39e97673f6bcdeb03567fc48ddbd289a6e
The idea of 'standalone JavaScript plugins' came during the 'JavaScript
plugins' talk at the Gerrit User Summit.
The main concept is to automatically install and expose all *.js files
that are in Gerrit's plugins/ directory. This should lower the entry
point barrier for JS developers.
There is one limitation of such plugins: they cannot contribute
additional resources. When such are required, the implementer should
inline them in JS code or use the gerrit-plugin-js-archetype.
Change-Id: Ibad8c3938c0855fcabe6937fd8b4d508a9a2eac3
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
Some user groups are intolerant of any sort of new feature or
funcationalty being added to the web interface. Add a server
variable that disables or hides most new functionality.
Change-Id: Ide3a6a5e66cbba9c58575345a4a9ad1da209bb16
Checked type inference has changed slightly in Java 7, so many of the
suppressions are no longer necessary.
Change-Id: I73585e888b8204429ea67c8f4822d81d4dad8c46
Internal group names are automatically hyperlinked in the access
control editor. This makes it easy to view the members of the group
and determine if access is correctly assigned.
Plugins supplying group systems may include a url to a group
information page. If present use these URLs as hyperlinks in the
access editor, providing the same functionality.
Change-Id: I9605fdc1d43d6705a01ec2b68b083e8678dbc88a
Delete 'Anonymous Users', 'Registered Users', 'Project Owners' and
'Change Owner' from the database and account_groups table. Define
them inside of a specialized SystemGroupBackend class.
Change-Id: Ia67add4630579f3d0ce25edcfd662bbcf918dc8f
GWT only needs the rebind code for CSS and ServerLinker to be
precompiled as bytecode. Save build time by passing no source
files to the java_library() used by gwt_module().
For a full draft build of ui_safari this cuts the refresh time
down from 32.015s to 26.158s on my MacBook. Saving 6s on each
UI reload adds up during development.
The common annotations need to be provided as bytecode, avoiding
spurious warnings from GWT when there is a Java syntax error.
Change-Id: I37826498650c65c05303e7d4d1177d05781c56f6
Require the secondary index to be enabled in Gerrit 2.9. Unless
configured differently, Lucene is used for the secondary index.
Change-Id: I3d2d804170835d69ffbfef586ddc3873ea3cd1c8
