This reverts commit 5db3bba3e2d85662bacedc5d2f215fff7d8d2805.
I was too fast to submit 5db3bba. Besides forgetting to submit the
referenced changes in some submodules some people reported issues
with the interception of the javax.inject.Inject in some JEE containers.
Change-Id: I931ad329d2e7be6f6ce804b8395489a021c8240b
The Guice team is discouraging use of its specific annotation where
possible, to increase JSR330 compliance.
Leave optional injection alone for now, which needs to be manually
replaced with OptionalBinder.
Change-Id: I4f53a518ba6f36fd67af12f3540dc44cbad07ff8
- Implement new mandatory getTarget() method for web links
- Added BranchWeblink to HelloWeblink
- Add example plugin demonstrating MergeValidationListener
Change-Id: Ifb04f7a34fa9f184d84e40639805c01586a74d89
* Implement new mandatory getTarget() method for web links
Change-Id: Ieae2990c3fdae8dd73525c6c23bc6b73945ec1ca
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Plugins can now control the target window in which a web link should
be opened.
This is an incompatible change and plugins implementing web links must
be adapted.
Change-Id: I5aec40ce425251b10fcb912131d547982d27cd55
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
replication:
- Fix infinite retry loop if createMissingRepositories enabled
cookbook:
- Replace cookbook-plugin with @PLUGIN@ in the docs.
Change-Id: If470d06eab52745e0ae339fc2a94e43b544d0daa
* Move replication logs into a separate file
* Add id to PushOne and print it in the log and in show-queue command
* Add buck resources to .gitignore
* Debug logging when replication is scheduled
* Promote replication scheduled logs to info
Change-Id: I8e31556ab34c77088649af79fdfadb77b5a297c1
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Move the definitions to a separate file, thus making the lib/BUCK file
smaller.
Add a VERSION definition for powermock and reuse it for all the libary
declarations, rather than hard-coding the same version string every
time.
Depends-On: I695efcfabe67416104b0efb71f090a5303393702
Change-Id: I8840ef29d9ddfa241740fb0e4c4715c52ff07e30
This adds the following changes:
replication:
- Clean not used SchemaFactory<ReviewDb> parameter
commit-message-length-validator:
- Allow threshold of too long lines to be configured
Change-Id: If4da3e54df1a13635bf8d3244a36e78ec9dc2297
* stable-2.9:
Add support for JCE (Java Cryptography Extension) ciphers
Buck: Respect gerrit-gwtui-common dependency for GWT plugins
More improvements in the change info block UI
Add a section about the submit type to the project owner guide
Fix: Wrong exception mapping in ReceiveCommmits
Fix REST example for removing included groups from a group
rest-api-groups.txt: Correct input examples to use [] for lists
Document project options
Allow service users to access REST API if auth.gitBasicAuth = true
Improve documentation about project creation
Make singleusergroup a core plugin
Rename 'Change Submit Action' in documentation to 'Submit Type'
ProjectInfoScreen: Display submit type and content merge next to each other
Add guide for project owners
Improve description of the auth.gitBasicAuth parameter
Conflicts:
Documentation/config-gerrit.txt
Documentation/rest-api-groups.txt
gerrit-gwtui/src/main/java/com/google/gerrit/client/GerritResources.java
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectInfoScreen.java
Change-Id: I269f8f1395c352d8d90ba4f770a19296a50967de
This plugin might be useful for a lot of users. Make it a core plugin
so it gets included in the distributed war file and offered to the user
during installation.
Change-Id: Ic69e01018d11b1989b36150584b104a98d48ea99
The intent is to use this method from ChangeJson to dynamically copy
labels every time the change detail is loaded, thus not relying on
one-time copying of labels in the notedb read path.
To do so requires a bit of refactoring, since the ChangeControl now
needs to be passed into this method.
Change-Id: I8bc25d32a91218e074517dcacf4bf3a77d4ae957
- Configure plugin specific list parameters as ProjectConfigEntries
- Changed merged from stable-2.8
Change-Id: Ifbf1222ecbc64a988d7e61bfd891b28c2488eac6
Unchanged, updated, and deleted approvals may need to be handled
separately by the underlying storage layer, e.g. in Submit. Record
this information in the result of LabelNormalizer.normalize().
For callers that don't care whether approvals were updated or not,
provide a convenience method to concatenate them.
Change-Id: Ifea7db3f7333d3ddb5e4d647a1d7e8eeb8cbff11
To get the following changes:
- Rename WrappedLogger to ReplicationStateLogger
- Retry replications failed due to "failed to lock" errors
- Do not retry replications with UnknownHostKey
Change-Id: I726dc5d8ca99bc41cbb08ab3e87469544b0623bb
To get the following fixes and updates:
- Change default push refSpec to 'refs/*:refs/*' (non-forced push)
- Allow default force update to be configurable
- Correct misspelled method name
Change-Id: Ic734a7290a303562e42b11a0b64697a0fcbc1d71
Update the plugins to the latest revisions to get the
following changes:
replication:
- Minor improvements in the config documentation
- Replication settings auto-reload and restart
singleusergroup
- Remove pom.xml
Change-Id: Ie75091d9ced8962a30797a7ad8160454c8a3ab7c
Encapsulate the current state of the migration in a NotesMigration
class. For each database table (or broader group of functionality)
that we migrate to notedb, configure a boolean indicating whether that
data should be read from notes, defaulting to false.
Unlike reads, NotesMigration contains just a single boolean
indicating that data should be written. We don't attempt to write
just some types of data; as the migration continues we will just
rewrite history.
Since most existing reads of the PatchSetApprovals table have been
migrated to ApprovalsUtil, most implementation changes happen there.
There are a few other implementations scattered around, and some that
will require a bit more work (e.g. stamping normalized approvals at
submit time).
Change-Id: I5676267d4de607c385e8c9917a89333863b9c9e7
The commonality of these methods is they will have a different
implementation when approvals are read from an eventual notedb, so
it makes sense to keep them located together.
Change-Id: I5de63a4210f29863274111964480fb1f5720ca60
Running `buck build plugins:core` before initialising the submodules
causes buck to throw FileNotFoundException and then go into an infinite
loop.
The genrule in the plugins' BUCK configuration has a check in the `cmd`
to make sure the required core plugins (`NEED`) exist, but it looks
like this gets evaluated after the `srcs` which is using `CORE`.
Change `srcs` to use `HAVE`. Now buck will exit with an error when the
core plugins do not exist.
Bug: issue 2343
Change-Id: I1bc2f67bcf6aacfe553c00e54fff18f959ac4b79
This class lives in gerrit-reviewdb because "refs/changes/" needs to be
referenced from PatchSet in reviewdb/client (and other UI classes).
Rename constants to all use REFS_* instead of being inconsistent.
Change-Id: I76e6ee7e63a4549b51a43698fb50b54a19dabfc6
