- Add transaction support for Jdbc dialects
- Only bind LIMIT variable in SQL when dialect supports it
Also note that the groupID of the component has been changed to
com.google.gerrit
Change-Id: Ie89c1bcc9643e909becff7a0fef37880440f50e3
Use custom build of SSHD library from Atlassian's maven repository,
that fixes sporadic handshake failures [1].
[1] https://issues.apache.org/jira/browse/SSHD-330
Change-Id: I4258f515ac10e04c8c8f1850f060b9dbad6d876f
Maven artifact names on Google bucket replacing SNAPSHOT suffix with
timestamp. 731967591ef98ab3c94691ba9dc0f217630dda76 changed this by
preserving the SNAPSHOT suffix. This broke fetching of gwtorm and
gwtjsonrpc and was reverted by 731967591ef98ab3c94691ba9dc0f217630dda76.
This change fixes this for both worlds: stripping it for GERRIT and
GERRIT_API Maven repositories but preserving it for the rest.
Test plan:
maven_jar() is working as expected for the both worlds:
* gwtorm:gwtorm:1.10-SNAPSHOT-20140310.015132-1 (repo = GERRIT)
* org.eclipse.jgit:org.eclipse.jgit:3.4.0-SNAPSHOT (repo = MAVEN_LOCAL)
Change-Id: I5357abe9ad6a40538c444ad70016c8c6d75d8ff3
This version of gwtorm contains an important bug-fix that ensures that
"LIMIT ?" is not omitted in generated queries [1]. This can improve the
performance of such queries by a large factor.
[1] https://gerrit-review.googlesource.com/57216
Change-Id: Ibd0d3918629b2901288de6dd2e85489e4503091a
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
937d527ac0e4ee685fccb60ae604406a6638daec upgraded bouncy castle to 1.49.
The old JAR artifact was renamed and split to number of files. For Gerrit
two libraries must be downloaded and be available under `$gerrit_site/lib`:
* bcprov-jdk15on-149.jar
* bcpkix-jdk15on-149.jar
Update download logic to support a basic concept of required dependencies,
ensuring BC provider is downloaded if the SSL library is installed by init.
Change-Id: I60092ebe136f78a5649fe8512737275f50195a34
Many bugs were fixed since version 1.44 that we are using[1].
JARs artifacts were renamed.
[1] http://www.bouncycastle.org/releasenotes.html
Change-Id: Ie2b22328c77b0100dfff61139b737894b88e7664
* stable-2.8:
SideBySide2: Fix failure to load from "ISE EditIterator out of bounds"
Remove "Click to" from topic edit button's tooltip
Fix: wrongly throw 'commit already exists' exception
Update sshd to 0.11.0
Bump SSHD version to 0.10.1 and enable nio2 backend
Conflicts:
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Topic.ui.xml
Change-Id: I63c1e12bbd413a8e212de5b2a8cf71fa2a2ce52d
Fixes a few issues including a null pointer exception [1] that causes
ssh commands to hang.
It also adds server driven rekeying after 1G bytes of data transferred,
which is a useful security feature.
[1] https://issues.apache.org/jira/browse/SSHD-307
Change-Id: I441995eaf76e4fe53f7991f5aef00e062900791b
46f8488a78742799a4f5f781279c8955460e7964 removed nio2 backend because of
a bug [1]. Given that the bug is fixed and released, enable it again.
Another problem was also fixed and released [2].
Upgrade to the official version 0.10.1 makes Gerrit's own custom patch of
SSHD and hosting it on Google bucket unnecessary.
[1] https://issues.apache.org/jira/browse/SSHD-252
[2] https://issues.apache.org/jira/browse/SSHD-255
Bug: Issue 2406
Change-Id: I6668f6194427f153e1982e14b3936d2f3132fa7d
a283507bccbd408540ae1baf75eb80eb59dce031 disabled EditIteratorTest due
to gwt-test-utils uncompatibility with new GWT 2.6 release.
After fixing the compatibility problem in [1] the tests can be enabled
again.
[1] https://github.com/gwt-test-utils/gwt-test-utils/issues/62
Change-Id: I1f93e6422a1ae60d66f4d8b4abac23b6a1acb4f9
84a66d82d36d554c1844acff11d1a62f10c174ed added support for light and
dark themes, but dark themes weren't enabled, as diff styles have
to be adjusted to correspond with dark colors.
101a8c4b65ebee4d54afddad10db05f5b9698ba9 reverted the preparation
for dark themes support.
This change enables support for subset of dark themes and switch
dynamicaly the diff styles to dark colors, when dark theme was
selected.
Change-Id: Ic220baf8f19366c04520b61e893a0d11912805ef
Since JGit 3.1 archive command was implemented. Add it to download
drop down as new line.
The following libraries are introduced in this change:
* jgit-archive (Apache 2)
* commons-compress (Apache 2)
* tukaani-xz (Public domain)
Change-Id: I5f61aac8c434414c73585a9320e84f4430dd111d
This fixes a long standing bug in the copy and rename detection
code where a copied file that is also updating its mode loses its
copy status and breaks the diff display.
Change-Id: I15c4d61ff1489e2c9b17e3b9ca76d9dcc98e26a8
This checks that the email address has a valid format.
Change-Id: I1f8d95dd9b02e720996bd15cca093ca55b5e4597
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This version includes a fix for an LOB deadlock between reading
and updating LOB columns.
Bug: Issue 2365
Change-Id: I845d645ee4bc095ffb04f38a03dc00a4de7ff243
GWT 2.6.0 has Java 7 support and other new features [1].
Internal Jetty version, shipped with GWT was updated to 8.1. This
version collides with the version that is used internally by Gerrit
(9.1). To resolve the conflict, GWT's own Jetty version is stripped
from the gwt-dev.jar with maven_jar() method and Gerrit's own Jetty
used instead. Missing Jetty artifacts, needed for the GWT to run in
dev mode:
* jetty-webapp
* jetty-xml
are included now as dependency of gerrit-gwtdebug project.
New GWT version updates a number of dependencies that are used in
Gerrit [3]. Update them too.
EditIteratorTest test is failing with NSME Exception in gwt-test-utils
framework, so deactivate it for now [2].
[1] http://www.gwtproject.org/release-notes.html#Release_Notes_2_6_0_RC1
[2] https://code.google.com/p/gwt-test-utils/issues/detail?id=179
[3]
* Guava 15.0
* Protobuf 2.5.0
* ASM 4.1
Change-Id: I0fa96da6465d52febeae65168b0bd1c2913f6c7e
This avoids packing too many CSS rules, which bloats the download
to the browser and may slow down rendering while the browser picks
matching CSS classes.
Change-Id: I8888bc9daa9693ff2598ccfe29d150fa3fac0916
Add support for CM3 themes. CM3 has built in support for themes.
Unfortunately we can not use all of them out of the box, because
we set statically background colors on diff styles. However we
can use light themes. Especially "eclipse" theme looks very sexy
for Java developers that use this IDE and are acquainted with its
look and feel.
Integrate all supported themes in Buck tool chain, so that we are
prepared to extend the support for dark themes. To do that we must
dynamically assign background colors for different diff styles per
theme.
Change-Id: Ic97c237d789dc4daeff6b8bb4f7606da83f5d532
* stable-2.8:
Codemirror: Add support for Groovy mode
Codemirror: Add support for Clojure mode
Codemirror: Add support for Lisp mode
Codemirror: Add support for ruby mode
Codemirror: Add support for perl mode
Conflicts:
gerrit-server/src/main/java/com/google/gerrit/server/DefaultFileExtensionRegistry.java
Change-Id: Icf61f85ea50b02d63a222973d0781afe67e03ee6
Drop the code that removes SNAPSHOT suffix in artifact name. This prevents
Gitblit plugin from fetching its custom artifact from Gerritforge Maven
repository, making from the right name:
com/gitblit/gitblit/1.4.0-SNAPSHOT/gitblit-1.4.0-SNAPSHOT.jar
the broken artifact name:
com/gitblit/gitblit/1.4.0-SNAPSHOT/gitblit-1.4.0.jar
Change-Id: Ib16f032a9fda3ef61570a85d97659cd3ce02f5f2
Write the index entirely in RAM. Its only a few hundred KiB, which
trivially fits in memory.
Compress it twice in memory, once to build the ZIP that is unpacked
at runtime, and again to package it into a JAR for linking with
the runtime. This saves a build step in the BUCK rules.
Move the ZIP under the server package name, to reduce any risk
of collision with another concept of "index.zip".
Change-Id: I74e59712e9855ac79c5220ff0a6b30ecbc3d152f
