Currently, if a user tries reverting a submission, the subject for all
changes of that new revert submission will be 'Revert "Change x"'.
Also, if you try to revert that newly created submission, the subject
for all changes of that new revert submission will be 'Revert "Revert
"Change x""' (while "Change x" depends on the change).
This is clearly not good, since it doesn't scale well with 2 or more
reverts. This change makes it so that it never shows "Revert Revert" for
changes, but rather changes the convention to "Revert^N". E.g, instead
of 'Revert "Revert "Change x""' the subject is 'Revert^2 "Change x"'.
Also, the limit for length of subject was reduced by 3 to 60 max length
to account for the addition of "^NN" in the subject.
Another problem is the fact that Git's default for Git Revert is the same
as the current behavior in Gerrit ("Revert Revert Change X"). I'm trying
to get in touch with them to change the default behavior. For now, it's
okay if I make this change specifically for RevertSubmission, and keep
Revert functionality for both Git and Gerrit consistent (the cost
is that Revert Submission and Revert are not very consistent this way).
Change-Id: Id5e4b9ab20165548b24aec9b9046ff5a9a9c4e7b
* stable-3.0:
Update highlight.js to include soy
Update building docs for building highlight.js
config-gerrit: Remove superfluous quote mark
Stop query from executing if predicate is empty
Highlight jinja2 syntax
Highlight Jenkinsfile as groovy
Update highlight.js
Verify Gerrit changes also on NoteDb
Don't sort messages returned by Jenkins
Fix string formatting in Jenkinsfile
Fix RejectedAccessException during posting checks in Jenkinsfile
Remove unnecessary SCM checkout from Jenkinsfile
Fix expected response code when posting checks in Jenkinsfile
Use basic auth for posting checks
Add Jenkinsfile for verification pipeline
Change-Id: Id78327e509ab6a93f63b5929dc7408c219903376
* stable-2.16:
Update highlight.js to include soy
Update building docs for building highlight.js
config-gerrit: Remove superfluous quote mark
Stop query from executing if predicate is empty
Highlight jinja2 syntax
Highlight Jenkinsfile as groovy
Update highlight.js
Verify Gerrit changes also on NoteDb
Don't sort messages returned by Jenkins
Fix string formatting in Jenkinsfile
Fix RejectedAccessException during posting checks in Jenkinsfile
Remove unnecessary SCM checkout from Jenkinsfile
Fix expected response code when posting checks in Jenkinsfile
Use basic auth for posting checks
Add Jenkinsfile for verification pipeline
Remove the reviewDb build from Jenkinsfile.
Change-Id: I48f1fd6c19f87a55cb838955c5edbfb40f7db68f
* stable-2.15:
Highlight jinja2 syntax
Highlight Jenkinsfile as groovy
Verify Gerrit changes also on NoteDb
Don't sort messages returned by Jenkins
Fix string formatting in Jenkinsfile
Fix RejectedAccessException during posting checks in Jenkinsfile
Remove unnecessary SCM checkout from Jenkinsfile
Fix expected response code when posting checks in Jenkinsfile
Use basic auth for posting checks
Add Jenkinsfile for verification pipeline
Change-Id: I5f22af9db17fcd2397cf039b33b6d6a446844cdc
* stable-3.0:
Upgrade JGit to 5.3.6.201910020505-r
Bazel: Bump bazel version to 1.0.0
Syntax highlighting: associate *.cproj and *.xaml as xml
Upgrade JGit to 5.1.12.201910011832-r
Change-Id: Iab58c9044db0aac594bf46a29694cf0d04d0f7d0
* stable-2.16:
Bazel: Bump bazel version to 1.0.0
Syntax highlighting: associate *.cproj and *.xaml as xml
Upgrade JGit to 5.1.12.201910011832-r
The change "Upgrade JGit to 5.1.12.201910011832-r" is intentionally
omitted in this merge since we use a different major release on the
stable-3.0 branch.
Change-Id: Ice7098a5ede220c0d2122a1d7d76a481c5b1726d
* stable-3.0:
Highlight svg as xml
Fix some corner cases with the download dropdown
Update highlight.js
Change-Id: I8ef5b8c5099d85ead7b43633b7a11f1a89b1fdb7
* stable-2.16:
Highlight svg as xml
Fix some corner cases with the download dropdown
Update highlight.js
Change-Id: Iec2bc764162f42990b4ab089fb3cd782eb76a846
Per
https://en.wikipedia.org/wiki/Master/slave_(technology)#Terminology_concerns
the use "slave" is considered offsensive in some circles.
For compatibility reasons, the "container.slave" property is
maintained, and the --slave flag is an alias for --replica.
Change-Id: If57df22705dac9450c1cf9900f051d9123d7dd2c
* stable-3.0:
Load proto_library from @rules_proto//proto:defs.bzl
Update git submodules
Set version to 3.0.3-SNAPSHOT
Use --header-text-color css variable for some classes in gr-main-header
Bazel: Add fixes for --incompatible_load_{java|python}_rules_from_bzl
Bazel: Bump minimum supported version to 0.29.0
Lucene index configuration and docs.
Change-Id: I82a153e2d3c3fede0347d2a870025143288721e6
* stable-2.16:
Load proto_library from @rules_proto//proto:defs.bzl
Update git submodules
Bazel: Add fixes for --incompatible_load_{java|python}_rules_from_bzl
Bazel: Bump minimum supported version to 0.29.0
Lucene index configuration and docs.
Change-Id: I401c192096047dd5069be37f17c4a62a8ed3afb7
* stable-2.15:
Bazel: Add fixes for --incompatible_load_{java|python}_rules_from_bzl
Bazel: Bump minimum supported version to 0.29.0
Lucene index configuration and docs.
Change-Id: I6c597cbc89fafece83c374e9b36c4c4c0126704f
* stable-3.0:
Expose Gerrit's GWT client library in the plugin API
Replace usage of Iterables.limit with Java 8 Stream API
Follow up to "Adapt gerrit.sh script to work on Alpine Linux"
Change-Id: I6b70578cf3f5a5599e521e46d794c586639d7bc9
* stable-2.16:
Expose Gerrit's GWT client library in the plugin API
Replace usage of Iterables.limit with Java 8 Stream API
Follow up to "Adapt gerrit.sh script to work on Alpine Linux"
Change-Id: I0b9ea803ade5673030a06b112c30996a72735a8e
* stable-2.15:
Expose Gerrit's GWT client library in the plugin API
Replace usage of Iterables.limit with Java 8 Stream API
Follow up to "Adapt gerrit.sh script to work on Alpine Linux"
Change-Id: If66c0dd7f912e4551a6855c3cf299ed2586873dc
* stable-3.0:
Fix transitive load of GWT_PLUGIN_DEPS for in-tree plugin builds
Bazel: Move PLUGIN_DEPS_NEVERLINK declaration to plugin.bzl
Adapt gerrit.sh script to work on Alpine Linux
Make wording of "Merged" html and text templates consistent
Update git submodules
Online index upgrade: skip submit rules for closed changes
BaseInit: Don't throw if schema cannot be upgraded
Change-Id: Iaa6435d06d8a0c254dc36794fe9ff2a7950c0dba
* stable-2.16:
Fix transitive load of GWT_PLUGIN_DEPS for in-tree plugin builds
Bazel: Move PLUGIN_DEPS_NEVERLINK declaration to plugin.bzl
Adapt gerrit.sh script to work on Alpine Linux
Make wording of "Merged" html and text templates consistent
Online index upgrade: skip submit rules for closed changes
BaseInit: Don't throw if schema cannot be upgraded
Change-Id: Id6a6034c6a2bcd1456d0b6095ef023c402388be1
* stable-2.15:
Fix transitive load of GWT_PLUGIN_DEPS for in-tree plugin builds
Bazel: Move PLUGIN_DEPS_NEVERLINK declaration to plugin.bzl
Adapt gerrit.sh script to work on Alpine Linux
Change-Id: Ica5ef5b8ff76c43515ca58e4bce13bee5c341d68
* stable-2.15:
Make wording of "Merged" html and text templates consistent
BaseInit: Don't throw if schema cannot be upgraded
Change-Id: If5f1230a893c644b07b899aa1e1403c01cc5f6d5
After consulting Polymer experts we have come to the conclusion that
enabling polyfills does not gain us anything during the Polymer 2
migration.
Change-Id: I5376b4ec10d295304d2ea5d4365e4bf12dbe9822
* stable-3.0:
ReceiveCommits: Don't instantiate BranchCommitValidator repeatedly
ElasticVersionTest: Add missing version 7.1 asserts
ElasticVersionTest: Improve test method ordering
ElasticVersionTest: Make test method names accurate
Upgrade gitiles to 0.2-10
PermissionRange: Interpret allowMin > allowMax as disallow
Fix formatting issue in project config documentation
ReceiveCommits: Validate ref operation before commits for non-ff case
Add test coverage for ref operation validation extension point
Allow CommitValidationListener to ignore 'skip validation' push option
Upgrade JGit to 4.11.8.201904181247-r
CreateProject: Expose createProject method
ElasticContainer: Switch to Alpine-based images from blacktop
DeleteVote.soy: Make wording consistent with DeleteVoteHtml.soy
DeleteVote.soy add missing review URL
Update git submodules
NewChange.soy: add missing closing parenthesis
Remove use of "NoteDB" config in PolyGerrit
Always show "NoteDB" config under gr-repo
Fix hiding "enable signed push" and "require signed push" under gr-repo
Update git submodules
gerrit.sh: Fix message about JRE
Allow CommitValidationListener to ignore 'skip validation' push option
ChangeEmail: Stop using deprecated SoyListData and SoyMapData
IndexServlet: Stop using deprecated SoyMapData
Bazel: Fix lint warning flagged by buildifier
Change-Id: Icadfa2bb77929e0aa5118ea8492fdb24e0e9aa7e
All the other review related templates (including DeleteVoteHtml.soy)
contain review URL, hence it was added to this one too.
Change-Id: Ice904d315841f7fe90e4f1567af092324f535b2d
Signed-off-by: Jacek Centkowski <jcentkowski@collab.net>
* stable-2.15:
gerrit.sh: Fix message about JRE
Allow CommitValidationListener to ignore 'skip validation' push option
The change "Allow CommitValidationListener to ignore 'skip validation'
push option" is omitted from this merge as it requires non-trivial fixes
to make it work on stable-2.16. It will be re-done separately in a follow
up commit, to make it easier to review.
Change-Id: I2930c972c3db4eaae6a025a43753145d8aad94ba
* changes:
Validate comments in MailProcessor using new interface
Validate comments in ReceiveCommits using new interface
Validate comments and message in PostReview using new interface
Add extension point for plugins to validate comments before publishing
* stable-3.0:
Highlight .mjs as javascript
Set version to 2.15.15-SNAPSHOT
Update buildifier to 0.26
Change-Id: I37f28ca8c35980ec61ee12c4c9e24ea602df6cf2
* stable-2.16:
Highlight .mjs as javascript
Set version to 2.15.15-SNAPSHOT
Update buildifier to 0.26
Change-Id: I98261be3f7e48747401e9cff45bb3314288c40d4
Adds logic to MailProcessor to validate all comments received via email.
Test case covers acceptance (existing tests) and rejection (new tests)
as well as distinction between inline/file/change message comments.
Change-Id: Iad889893cd3007c18aa36103fe1bd96491fdb8d8
* stable-3.0:
ReviewersUtil: Increase multiplier for candidate list to 3
Add missing 'Allow content merges' section title in project config documentation
Fix placement of footer and searchbox in config-project-config.txt
AbstractQueryChangesTest: Open TestRepository in try-with-resource
TestRepository: Fix resource leak flagged by Eclipse
Update git submodules
Update git submodules
Accept more than one endpoint from the same plugin
mvn.py: Explicitly specify version in mvn deploy command
Add missing 'Allow content merges' section title in project config documentation
Allow to disable log file compression
Allow to disable log file rotation
SystemLog: Don't keep Config as a member
Remove mention of the offline migrator being in 3.0
AccountIT#deletePreferredEmail: Fix flakiness
gerrit.sh: Fix PID definition
Upgrade gitiles to 0.2-9
Use Provider<PersonIdent> in CreateProject @Singleton
AccountIT: Add test for deleting preferred email
AccountIT: Add test coverage of adding an email and setting preferred
Change-Id: I76b25cf1201d13025fa566b893c3fd02fbf212a0
* stable-2.16:
Update git submodules
Accept more than one endpoint from the same plugin
mvn.py: Explicitly specify version in mvn deploy command
Add missing 'Allow content merges' section title in project config documentation
Allow to disable log file compression
Allow to disable log file rotation
SystemLog: Don't keep Config as a member
AccountIT#deletePreferredEmail: Fix flakiness
gerrit.sh: Fix PID definition
Use Provider<PersonIdent> in CreateProject @Singleton
AccountIT: Add test for deleting preferred email
AccountIT: Add test coverage of adding an email and setting preferred
Change-Id: I56efcb5dcc09472b2c18e26be1feae62b9811eb9
* stable-2.15:
gerrit.sh: Fix PID definition
AccountIT: Add test for deleting preferred email
AccountIT: Add test coverage of adding an email and setting preferred
Adjust AccountIT#deletePreferredEmail to the different behavior on this
branch: the account is not reindexed twice when the preferred email is
deleted.
Change-Id: Icffba48df458f303f261a2189d3baa942d397fb8
Gerrit's UI dispatches a number of requests to the server when it
initially loads. These are to obtain server configs, server version and
account data. These round trips add additional time when the App starts.
This commit ships the most relevant data in-line directly in index.html.
On the server, this is almost for free because when rendering
index.html, we already authenticated the user, so inline this data is
cheap. The server information is static, so it is also cheap to inline.
We expect this to help reduce the App's startup on slow networks.
We render the data using Gson and Soy. Soy has a predefined ordainer to
render JSON data. We use this to safely escape values.
Change-Id: I8e9cc077fa7212ca782b1ec334d41b872a3fd470
