113 Commits

Author SHA1 Message Date
Shawn Pearce
1bd7946054 Update CodeMirror to latest HEAD
Change-Id: I0a4a15df0217c81f8ec6bf9bdbaf9bd11cd930ae
2013-07-15 16:38:21 -07:00
Shawn Pearce
1ee35db3d6 Update CodeMirror to latest HEAD
Change-Id: Ib2add9e94abf28fdb70cd00f5b05529ba5b20c41
2013-07-12 17:08:13 -07:00
Shawn Pearce
05c0236a09 Update CodeMirror
Change-Id: If61dc1022daea586efd670582ddbc5fe70e5e65f
2013-07-11 17:24:35 -07:00
Shawn Pearce
7654c61385 Update CodeMirror to latest tip of master
Change-Id: I3098b8bda449db13adb8b525049b0504c6aff4fd
2013-07-09 11:14:50 -07:00
Shawn Pearce
0bfaaef5b0 Update CodeMirror to latest HEAD
Change-Id: I579e4523483f73084da3c7f54469c44e77e95ca1
2013-06-27 14:55:04 -07:00
Michael Zhou
faf65a356c Start displaying comments and drafts.
Added drafts() call to CommentApi.

Added CommentBox for displaying comments.

Modified CodeMirrorDemo:
1. Implemented the algorithm and data structure that, given a line
number on one CM, return the corresponding line number on the other.
2. Added methods to display comments.

Modified some CSS styles for DiffTable.

Added wrapper for LineWidget in case we need it.

Change-Id: I9b9f6940ffa4eb1f87f79d5a655edd6beaab3b37
2013-06-25 10:04:24 -07:00
Shawn Pearce
d251f3a0ed Move codemirror LICENSE onto the codemirror java_library()
This fixes the name shown in the generated licenses.txt and HTML
to be "codemirror" and not "codemirror_jar".

Change-Id: Ib90d97c022c69179943dfa827f68e62fcea87825
2013-05-29 16:39:57 -07:00
Shawn Pearce
1d89e26411 Merge "Fix download and download_sources to aggressively get all targets" 2013-05-29 23:36:22 +00:00
Thomas Broyer
18fdb9d0ac Fix //lib/codemirror:codemirror so it's included in "buck audit classpath"
Change-Id: I2fdad8263a550883356855dded05ce4d51e48a30
2013-05-26 11:02:55 +02:00
Shawn Pearce
3b4ca73c2c Fix download and download_sources to aggressively get all targets
Run any target that depends on download_file, no matter what its
name is. This allows grabbing codemirror without confusing the
__download_bin case with assuming a __download_src target exists.

Change-Id: Iaf7cc3000164aa46376314f8d24dc1f057ab06c3
2013-05-23 10:45:51 -07:00
Shawn Pearce
c6e12dc696 Download codemirror as part of buck build download
The target name must end in '__download_bin' in order to be magically
picked up as a download target.  Rename the target to conform to the
expected convention.

Change-Id: Ic93f58568522f442e6648be7e63630d08dcc0a16
2013-05-22 19:58:10 -07:00
Shawn Pearce
2c7c1224ce Fix name codemirror is cached under
The cache in ~/.gerritcodereview/buck-cache uses the basename of
the -o parameter to store the file. Calling it dist.zip means we
see the entry in the cache as dist.zip-${SHA1}, which is not where
a developer might expect to find codemirror. Use a naming pattern
similar to the Maven artifact case.

Change-Id: I956cb657e02a00124309896de96f449aad8d1b87
2013-05-22 08:48:43 -07:00
Shawn Pearce
1e279c10fd Include codemirror 3.13
Download and package codemirror 3.13 for inclusion in the UI.
This may eventually replace the current side-by-side viewer,
as well as offer rich online editing to make small fixes to
existing changes.

Change-Id: I483fb46d9e18164d189826eca5cb96f9a1471c7e
2013-05-20 11:39:10 -07:00