If a screen is registered by a plugin this registration needs to be
completed before the dispatcher tries to parse the token. Wait for
plugin scripts to finish loading and evaluating. The old method of
injecting a script tag was not waiting correctly, especially for GWT
based plugins.
JavaScript plugins are now required to use Gerrit.install() as this
method updates internal Gerrit state tracking the script. Not using
install() will eventually cause the UI to report the plugin as failing
to load.
GWT plugins must override onPluginLoad() not onModuleLoad(). All
plugins must recompile with the new glue code, as there is now a
handshake between the GWT plugin and the main Gerrit code.
All plugins must load within 5 seconds, otherwise the page marks them
as failed and reports loading errors. During loading a glass pane is
used to prevent the user from interacting with a partial initialized
UI. Plugins may be making critical contributions that need to be
registered before use.
A chunk of the API glue code was moved around to make each JSNI block
smaller, and better isolate purpose. Plugin is now declared in its
own Java class.
Plugin instances are now tracked in the map $wnd.Gerrit.plugins.
This allows the main code to later figure out if any instance failed
to load. Any loading errors are usually reported on the JavaScript
console as script failures, and may include stack traces.
Change-Id: Id03581437ae1010cf995ef7ba8626ece37dfc2f4
The Maven archetypes are still built with Maven and the corresponding
target folders should be ignored.
Change-Id: I4cc129b8a381c80e352bba41c6cd38bc6aa320b3
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Instead of adding a button that opens a GWT dialog box,
have a top menu from which the GWT dialog box is opened.
Change-Id: Ie62f04609958c4e1bdf4f30ada08f42579a42961
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This reverts commit 27234fd184c63a70fb243d12dafd7a398ea6e14f.
The '.css' files of the different plugins must of unique names. Having
several plugins with a 'plugin.css' is not working and thus the rename
makes no sense.
Change-Id: I599bbb201556985cb5a7f4f13aabe7b8bc0decf3
This is dependency is not needed and it references an old version of
JUnit.
Change-Id: Ia3b14ab091ca4b4e5bc64ca08a61bf152bae3527
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
The old name ('hello.css') doesn't fit to any plugin which is why this
file needs to renamed after a project has been generated. The new name
('plugin.css') is more suitable and doesn't need to be changed.
Change-Id: Ib5d132a9518f3faa29b85e35117c81d864f90323
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
The GWT version that is used by Gerrit should be the default for the
GWT plugin.
Change-Id: I22c50e0b91e22d2f591ea5db102ab29bd927bb7b
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
With this plugin projects that are created with the archetypes
immediately have the Gerrit standard settings, e.g. code formatting
rules.
Change-Id: Ia98ca03fd9d5d759a4292f82f7fdda9838461dee
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
The parent pom.xml doesn't exist anymore since the Gerrit build is now
using Buck.
Change-Id: I4b9872f44cf7fb8cec0ceb499ccbbb9e7c617ee5
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Per [1] the correct URL is <bucket>.storage.googleapis.com/<object>.
Update existing references to project resources to use this domain
name instead of the old name.
[1] https://developers.google.com/storage/docs/reference-uris
Change-Id: I3788cfb4504b3908d2b5eccbdf52beffc3d18387
Arial Unicode MS does not have a bold version. Selecting this font
prevents correct display of bold text on Mac OS X. Simplify the
selector to sans-serif and allow the browser to use the user's
preferred font in this family.
Bug: issue 1863
Change-Id: I70627d974f6f34cc3b49821a4beb4c49032f6c6e
Update GWT plugin archetype to auto register its instance in Gerrit
Change-Id: I7b1930871b21f5ae4850ee07f14cd430f9866036
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
Adds example GWT based Web UI plugin archetype.
Change-Id: Ib11c1571522ced54c6bf74cd1a0aff71da406c3b
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
