378 Commits

Author SHA1 Message Date
David Pursehouse
7635930138 Update git submodules
* Update plugins/hooks from branch 'master'
  - Refactor to pass injected instances through HookArgs
    
    Instead of injecting the SitePath and GitRepositoryManager in all the
    places they're used, inject them only in HookFactory and pass them
    around through HookArgs.
    
    Make objects package visible in HookArgs so that they can be accessed
    directly rather than through getter methods.
    
    Change-Id: I0cee06e4928748e7dba0315653def894d27244de
2017-02-15 08:58:49 +00:00
Dave Borowitz
793c7933ff Update git submodules
* Update plugins/reviewnotes from branch 'master'
  - RefUpdateListener: Add missing import
    
    Change-Id: I67067065ab45030a73d031ec8c53e13e7e5ac171
2017-02-08 14:46:51 +00:00
Dave Borowitz
bf4224bc2f Merge "Assign unused Future return value to a variable"
* submodules:
* Update plugins/reviewnotes from branch 'master'
  - Assign unused Future return value to a variable
    
    Error Prone plans to make this pattern into a compile error; this avoids
    future breakage.
    
    Change-Id: I6a023f22f472941854a6729f6450b9b70a020069
2017-02-08 13:58:39 +00:00
David Pursehouse
49df12cb7d Merge "Format all Java files with google-java-format"
* submodules:
* Update plugins/hooks from branch 'master'
  - Format all Java files with google-java-format
    
    Change-Id: Ic726e55d416c3ceda674111b20fdc985c857c245
    * Update plugins/reviewnotes from branch 'master'
  - Format all Java files with google-java-format
    
    Change-Id: I05b6a2e93015e8a5a5e93cf64ad15b710e86b5c9
    * Update plugins/commit-message-length-validator from branch 'master'
  - Format all Java files with google-java-format
    
    Change-Id: Ibc2af6488f1b117ba3f94613309c8c69f1ed6dc1
    * Update plugins/cookbook-plugin from branch 'master'
  - Format all Java files with google-java-format
    
    Change-Id: Id46240f027c75888265c1f878df52817cd50ec8a
    * Update plugins/replication from branch 'master'
  - Merge "Format all Java files with google-java-format"
  - Format all Java files with google-java-format
    
    Change-Id: I7884ab98ed1d2baa1776b2bb032ce338e8f88bc9
    * Update plugins/singleusergroup from branch 'master'
  - Format all Java files with google-java-format
    
    Change-Id: I504a6177f9fded8bee1a8d6d3a7ab4f983d63853
    * Update plugins/download-commands from branch 'master'
  - Format all Java files with google-java-format
    
    Change-Id: Iec0368bf90d394e0a98662e535ac082ad45f3bbb
2017-02-07 03:31:04 +00:00
David Pursehouse
347854a4e2 Update git submodules
* Update plugins/hooks from branch 'master'
  - Merge branch 'stable-2.13'
    
    * stable-2.13:
      Add metrics for hook execution
    
    Change-Id: I1f4026f3fa96e2a5fa0321d02563f629ffa95fb2
    
  - Add metrics for hook execution
    
    - Execution latency
    - Execution count
    - Error count
    - Timeout count
    
    Change-Id: I7ed95e08608b436ab533929322f951e85a45b7f9
2017-02-03 05:23:48 +00:00
David Pursehouse
cbad27c464 Update git submodules
* Update plugins/replication from branch 'master'
  - Merge branch 'stable-2.13'
    
    * stable-2.13:
      ReplicationMetrics: Make members private final
    
    Change-Id: Icf7dd3f5c9dd518c8984546aba9708525a428f79
    
  - ReplicationMetrics: Make members private final
    
    These members should only be accessed through the public methods:
    
     - start(...), to create/start a new timer context
     - record(...), to record the retry/delay values
    
    Mark the members as private final to prevent unintended access.
    
    Change-Id: I69a7e3b13ba4c344f3176528306163ebef07653c
2017-02-03 01:03:12 +00:00
Luca Milanesio
6b19214ef6 Allow plugins to contribute external workspace deps
When building a Gerrit plugin in-tree, allow to add extra dependencies
to the WORKSPACE file.

The only operation required will be the overwrite of the
plugins/external_plugin_deps.bzl file with the one provided by the
plugin.

Bug: Issue 5305
Change-Id: I07e4538f9f81ef923a4ca1aeceaee75d8429434e
2017-01-26 20:39:45 +00:00
David Ostrovsky
c3c271b892 Update git submodules
* Update plugins/singleusergroup from branch 'master'
  - Actually remove Buck based build
    
    Accidentaly, the wrong file was removed. It was supposed to remove BUCK
    and not BUILD.
    
    This partially reverts commit 6800d41177013999c7259b387314d812cb51bcce.
    
    Change-Id: Ia131c160a614b7d6dae242def0ace2203dde1230
2017-01-24 09:18:42 +00:00
Gerrit Code Review
18bac84b94 Update git submodules
* Update plugins/cookbook-plugin from branch 'master'
  - Remove Buck based build
    
    Change-Id: Iaa8fc09ffab1f55c73a1aec8d810ce848de38f56
    * Update plugins/replication from branch 'master'
  - Remove Buck based build
    
    Change-Id: I8d083b35dd00a27644c0415655ae87a24325e376
    * Update plugins/singleusergroup from branch 'master'
  - Remove Buck based build
    
    Change-Id: I473c7f3d7ae882c7cce3374700c7adfeb1037ca9
    * Update plugins/hooks from branch 'master'
  - Remove Buck based build
    
    Change-Id: If58e92593cae0f0b75dd2610fd873affad70795a
    * Update plugins/download-commands from branch 'master'
  - Remove Buck based build
    
    Change-Id: Ie7be70c183d229e7aa965195d334e33160574b82
    * Update plugins/reviewnotes from branch 'master'
  - Remove Buck based build
    
    Change-Id: I92196a692632a993822fd7709a793e3b67b2768b
2017-01-24 06:52:03 +00:00
David Ostrovsky
fdbfcad77d Remove Buck based build
Bug: Issue 5302
Change-Id: I6e860446ef30ff0ad1c7c49fc0e39d39d921820b
2017-01-23 12:44:58 +00:00
Dave Borowitz
0ecf8cf401 Avoid Multimap implementation create methods
Guava team recommends MultimapBuilder over specific Multimap
implementations, so callers don't have to know the specific key/value
behaviors of the individual implementations. The static factory
methods in the implementations will be removed in a later version.

LinkedListMultimap and LinkedHashMultimap are not affected, since
MultimapBuilder lacks support for specifying linked entries, and thus
the factory methods are not in immediate danger of deletion.

Change-Id: I7744db687da84a7beae31d1cb8953e782ed23c1d
2017-01-18 10:37:06 +09:00
Dave Borowitz
484da493b3 Prefer subtypes of Multimap
Guava team recommends using the subinterfaces of Multimap, for the
same reasons they recommend using Set and List rather than Collection:
it documents expectations about ordering, uniqueness, and behavior of
equals. Do this across the board in Gerrit.

Mostly this is straightforward and I tried to exactly match existing
behavior where possible. However, there were a few wrinkles, where
different callers passed different subtypes to the same method.

The main one is arguments to ParameterParser#parse and
splitQueryString, where some callers used SetMultimaps (perhaps
semi-intentionally, or perhaps misunderstanding the nature of
HashMultimap). For the purposes of parameter parsing, a ListMultimap
makes more sense, because it preserves argument order and repetition.

Another instance is a couple places in ReceiveCommits and downstream
where there were SetMultimap<?, Ref>. Since Refs do not implement
equals, this is effectively the same thing as a ListMultimap, and
changing the interface no longer misleads readers into thinking there
might be some deduplication happening.

Finally, this change includes a breaking API change to the return
type of ExternalIncludedIn#getIncludedIn.

Change-Id: I5f1d15e27a32e534a6aaefe204e7a31815f4c8d7
2017-01-18 10:36:38 +09:00
Edwin Kempin
10aa4e2bbf Require account index and remove fallbacks
The account data is moved from ReviewDb into git.

Change-Id: I643827179b24601b138f394cfff5890f919b9da9
Signed-off-by: Edwin Kempin <ekempin@google.com>
2016-12-29 11:23:56 +01:00
David Pursehouse
5fdb5f2d6e Organize imports
Change-Id: Ia6e9edf3f735a7dba3a838ce9c5f6fbea40fa625
2016-12-27 14:02:13 +00:00
ekempin
a4505709b0 Merge changes from topic 'use-ssh'
* changes:
  Only generate SSH test keys if we run SSH tests
  Add @UseSsh Annotation and GERRIT_USE_SSH flag


* submodules:
* Update plugins/cookbook-plugin from branch 'master'
  - Add @UseSsh to CookbookIT
    
    Change-Id: I5245a09a0dd3593db6d80fab260369044692cd7a
2016-12-22 15:35:22 +00:00
David Ostrovsky
bc174c6f83 Update git submodules
* Update plugins/cookbook-plugin from branch 'master'
  - Bazel: Increase time limit for tests to 300 seconds
    
    20 seconds (small size) doesn't seem to be enough on the CI: [1].
    
    [1] https://gerrit-ci.gerritforge.com/job/Gerrit-verifier/1526/consoleText
    
    Change-Id: I41dd945f425510c49603dafb3c2835a5ad9453d7
2016-12-14 12:59:32 +00:00
David Pursehouse
39d362e5a7 Update git submodules
* Update plugins/cookbook-plugin from branch 'master'
  - Merge branch 'stable-2.13'
    
    * stable-2.13:
      HelloWebLink: Make the dummy image more visible
    
    Change-Id: I5291aabcf3c57f76fe17c65a770c09fe80022412
    
  - HelloWebLink: Make the dummy image more visible
    
    Change-Id: If2b80d5fd2f719ebd1db4c9b15f5c8e50f5cda3f
2016-12-12 06:57:30 +00:00
David Ostrovsky
8df8af2572 Manually bind plugin guice modules in gerrit Guice universe
Short circuit the plugin loading phase from the unit tests by passing
the module names from the manifest file.

This allows us to avoid building and deploying the plugin JAR from
within build tool chain.

To use the simplified plugin bootstrap tests, plugin test class must
be inherited from the LightweightPluginDaemonTest class and must be
annotated with @TestPlugin annotation:

  @TestPlugin(
    name = "cookbook",
    sysModule = "com.googlesource.gerrit.plugins.cookbook.Module",
    httpModule = "com.googlesource.gerrit.plugins.cookbook.HttpModule",
    sshModule = "com.googlesource.gerrit.plugins.cookbook.SshModule"
  )
  public class CookbookIT extends LightweightPluginDaemonTest {
    @Test
    public void revisionTest() throws Exception {
      createChange();
      RestResponse response =
          adminRestSession.post("/changes/1/revisions/1/cookbook~hello-revision");
      assertThat(response.getEntityContent())
          .contains("Hello admin from change 1, patch set 1!");
    }
  }

Inspired-By: Dave Borowitz <dborowitz@google.com>
Change-Id: I689bb71413ecfbbf99f72730b0d2617bf526d9dd
2016-12-08 12:14:48 +00:00
Gerrit Code Review
99cb54efb1 Update git submodules
* Update plugins/hooks from branch 'master'
  - Bazel: Reformat BUILD file with buildifier
    
    Change-Id: Ib3882321efed90b80d7fdcec909159697b2b90e3
    * Update plugins/reviewnotes from branch 'master'
  - Bazel: Reformat BUILD file with buildifier
    
    Change-Id: I3bb558072896e0b733516e013237ee3fde1ba597
    * Update plugins/commit-message-length-validator from branch 'master'
  - Bazel: Reformat BUILD file with buildifier
    
    Change-Id: I5d56eeceb1ba3c2738d59f6837edea7f9235a4e4
    * Update plugins/cookbook-plugin from branch 'master'
  - Bazel: Reformat BUILD file with buildifier
    
    Change-Id: I89660a07b1a6ccfd1fa5f68e1e0b75b8291647af
    * Update plugins/replication from branch 'master'
  - Bazel: Reformat BUILD file with buildifier
    
    Change-Id: Idf31346cdba78e897ff8d6427a2b929eb890c7fe
    * Update plugins/singleusergroup from branch 'master'
  - Bazel: Reformat BUILD file with buildifier
    
    Change-Id: I0e2f1450364533c4bcba9ef0af3cb79b4a26de2f
    * Update plugins/download-commands from branch 'master'
  - Bazel: Reformat BUILD file with buildifier
    
    Change-Id: Iab54927ee82990886e92e80c9860a79292359487
2016-12-07 15:12:22 +00:00
David Pursehouse
34321931e8 Merge "Remove test prefix from test methods"
* submodules:
* Update plugins/replication from branch 'master'
  - Remove test prefix from test methods in replication plugin
    
    We previously used 'test' to prefix tests but have decided to stop this.
    This change removes the prefix from all test code.
    
    Change-Id: I42e6191ece7872f4647e425e3ca0acf8c6452412
2016-12-07 12:48:37 +00:00
David Ostrovsky
fa18907d7f Bazel: Reformat build files
Reformat the Bazel build files with the buildifier tool [1].

The style is different for Bazel files. Most notably, indentation level
is 4 spaces instead of 2, and " is used instead of '.

[1] https://github.com/bazelbuild/buildifier

Change-Id: I95c0c6f11b6d76572797853b4ebb5cee5ebd3c98
2016-12-07 11:33:07 +00:00
David Ostrovsky
5863fcf7c0 Merge "Bazel: Generate source dir for plugins in eclipse classpath" 2016-11-25 10:10:52 +00:00
David Ostrovsky
64e1aff339 Bazel: Generate source dir for plugins in eclipse classpath
Change-Id: I9f71808b2ce6b29523143bcc98de4a5f50a5dc94
2016-11-25 09:58:39 +00:00
David Ostrovsky
933df2ad04 Update git submodules
* Update plugins/cookbook-plugin from branch 'master'
  - Bazel: Increase test timeout
    
    Change-Id: I577ee5967c95dd5be10252fe284662a7151119b2
2016-11-24 13:30:56 +00:00
Eryk Szymanski
198976610d Update git submodules
* Update plugins/replication from branch 'master'
  - Add ReplicationScheduledEvent to indicate ref replication is scheduled.
    
    Assure that event is posted only once each time a ref is scheduled.
    Covers the corner case when the ref is added to already scheduled push.
    
    Change-Id: I175940f8d4c6b9164c41bbec8c52d221ec30001b
    Signed-off-by: Eryk Szymanski <eryksz@gmail.com>
2016-11-24 01:34:42 +00:00
David Ostrovsky
ff719bb551 Update git submodules
* Update plugins/cookbook-plugin from branch 'master'
  - Bazel: Run plugin tests non-hermetically
    
    The plugin tests required the plugin to be built and installed to the
    test site (controlled by the test), so that this implementation is by
    design non hermeticized so we can't run in the sandbox.
    
    Change-Id: I39b981aaa4c6063f34e97db59a34b6a0f238e28b
2016-11-16 22:49:02 +00:00
David Ostrovsky
074e7868a7 Update git submodules
* Update plugins/cookbook-plugin from branch 'master'
  - Implement bazel build
    
    Tests are still failing as acceptance test framework wasn't migrated
    to Bazel yet.
    
    Change-Id: I4f48925df31a9a79da631b0a9ccd2b724a674270
2016-11-15 23:44:46 +00:00
David Pursehouse
ba017123d0 Update git submodules
* Update plugins/download-commands from branch 'master'
  - Merge branch 'stable-2.13'
    
    * stable-2.13:
      CloneWithCommitMsgHook: Fix HTTP clone command inconsistency
    
    Change-Id: I97fafb4e6972d5f11e3dddfd69ad0711d0c0bf7f
    
  - Merge branch 'stable-2.12' into stable-2.13
    
    * stable-2.12:
      CloneWithCommitMsgHook: Fix HTTP clone command inconsistency
    
    Change-Id: I8a86b8cc56834933391afd56fc93d4ece67a4401
    
  - CloneWithCommitMsgHook: Fix HTTP clone command inconsistency
    
    When cloning a project using HTTP schema, the "/a" in the URL was added
    only when choosing to clone without the commit hook. Now the URL is the
    same in both cases.
    
    Change-Id: I8fc0667f17cea592bd702a0441cba7ca3f762968
    (cherry picked from commit d632d6471b42a47877664a5266ba509026538a32)
2016-11-14 22:26:04 +00:00
David Ostrovsky
02069e6907 Bazel: Stamp core plugins
TEST PLAN:

  $ bazel build release

Install bazel-bin/release.war and verify that the versions of the
core plugins are reported correctly:

commit-message-length-validator: v2.13.1-2-g76b911
download-commands: v2.13.2-5-gd632d64
hooks: v2.13.2-7-gf27c7e7
replication: v2.13.2-17-g531ed1
reviewnotes: v2.13.1-7-g45f6975

Change-Id: Iaceeeb1daafd7455c8d8a3673682d1ab9e65d8ef
2016-11-12 15:45:39 -08:00
Hector Oswaldo Caballero
3a75214a45 Update git submodules
* Update plugins/download-commands from branch 'master'
  - CloneWithCommitMsgHook: Fix HTTP clone command inconsistency
    
    When cloning a project using HTTP schema, the "/a" in the URL was added
    only when choosing to clone without the commit hook. Now the URL is the
    same in both cases.
    
    Change-Id: I8fc0667f17cea592bd702a0441cba7ca3f762968
2016-11-11 18:32:50 +00:00
Luca Milanesio
a67575aa90 Update git submodules
* Update plugins/replication from branch 'master'
  - Fix Bazel build with testonly attribute set
    
    Replication plugin tests depend on //gerrit-acceptance-framework:lib
    which is flagged with testonly attribute.
    
    For Bazel, all the dependencies in the tree need to have the testonly
    set consistently.
    
    Change-Id: I0eb3f6c3f2123b66b98b8c8060badc9bbaa88dd6
2016-11-09 19:47:24 +00:00
Hugo Arès
625adda318 Update git submodules
* Update plugins/replication from branch 'master'
  - Create Destination using Guice Factory
    
    Destination classes were instantiated in ReplicationFileBasedConfig
    which required to have all Destination dependencies injected in
    ReplicationFileBasedConfig.
    
    Create Destination using a new DestinationFactory to stop having to
    pass dependencies from one class to another.
    
    Also-By: David Pursehouse <dpursehouse@collab.net>
    Change-Id: If4d9bc5266837b8fec261decfbd1e651c4cb0f51
    
  - ReplicationFileBasedConfig: Replace FluentIterable with streams/lambda
    
    Change-Id: I85356369f245a45aaef6db20655ac18750cb3400
2016-11-04 02:16:30 +00:00
Han-Wen Nienhuys
29cced5e29 bazel: remove 'out' attribute from genrule2, and use throughout.
This centralizes the OSX mktemp solution.

Change-Id: Iaab18450146b649245b36865bedc5d7b50d1aa07
2016-11-02 13:54:10 +01:00
David Pursehouse
12b0267ecb Update git submodules
* Update plugins/hooks from branch 'master'
  - Merge branch 'stable-2.13'
    
    * stable-2.13:
      Add project name to commit received hook
      Always return the output from ref-update hook
    
    Change-Id: Id86c2c7acf94e2a7b2e1a3e3af7c3637b054f65f
    
  - Add project name to commit received hook
    
    This also implicates that GIT_DIR and the working directory is correctly
    set for the ref-update hook.
    
    Bug: Issue 4841
    Change-Id: I48141d316cacdd649f6e56ea48d689d06940fbf5
    
  - Always return the output from ref-update hook
    
    Change I5905c44c7 moved the invocation of the ref-update hook out of
    the ReceiveCommits implementation and into CommitValidators. Since
    then, the output of the ref-update hook is not sent back to the git
    client except in the case of an error or rejection.
    
    Update the handling of the ref-update hook in the plugin so that its
    output is returned back to the caller as a commit validation message
    which is then sent to the client.
    
    Change-Id: I88af8a3c690cc226214208c3c93f552f054ccae0
    Reported-By: Robert Niemi <robert.den.klurige@googlemail.com>
2016-11-02 07:52:01 +00:00
David Pursehouse
617fa26c2d Update git submodules
* Update plugins/cookbook-plugin from branch 'master'
  - Get rid of dependency on Guava
    
    Since I789f9aa589 removed usage of Guava's Optional, we only have
    the dependency on Guava for the following simple utility methods:
    
      Strings.isNullOrEmpty
      MoreObjects.firstNonNull
    
    Remove the dependency and instead provide own implementations
    of those methods.
    
    Change-Id: Iddcc20005004d37dae703fc0522c546a5212575c
2016-10-28 13:47:34 +00:00
David Pursehouse
26e23723f9 Update git submodules
* Update plugins/cookbook-plugin from branch 'master'
  - Bump GWT to 2.8.0 final release
    
    Change-Id: Ica57a0c2ebd31ccd39b25870a674cd25e31b49b2
    
  - Add missing dependency on gerrit-acceptance-framework
    
    Change-Id: I8d2ebdad5687230f63c2fcca7c2383f9653e24d6
2016-10-28 04:44:55 +00:00
David Pursehouse
cf03df12bb Update replication plugin back to latest revision
Change Id45967aa8 accidentally reverted it to an earlier revision.

Change-Id: If545ce34ae3f586954b8746b4a5e433cb46d369c
2016-10-27 08:28:43 +09:00
Han-Wen Nienhuys
da5999b039 bazel: build a polygerrit war too.
Change-Id: Id45967aa844faedee3ab501491cd30cdb903a789
2016-10-25 13:12:26 +00:00
David Pursehouse
7b8b81f192 Merge "Upgrade Guava to 20.0-rc1"
* submodules:
* Update plugins/replication from branch 'master'
  - Remove usage of deprecated Throwables methods
    
    The propagate and propagateIfPossible methods are deprecated in
    Guava 20. Replace them with the recommended alternatives.
    
    Change-Id: I8aacba415a15655850c9d2e7ba8bd207db930460
2016-10-24 23:16:13 +00:00
David Pursehouse
d97d02de9f Update git submodules
* Update plugins/replication from branch 'master'
  - Merge branch 'stable-2.13'
    
    * stable-2.13:
      Make SearchingChangeCacheImpl nullable when replicating from slave
    
    Change-Id: I0d23a61100350239432d8eeb701483afe0625fb6
    
  - Make SearchingChangeCacheImpl nullable when replicating from slave
    
    SearchingChangeCacheImpl should be nullable in slave mode.
    
    Change-Id: If22407565f44e7ed201e57d7d3b7b9a51f20b5bc
2016-10-19 08:36:26 +00:00
Dave Borowitz
46b3de5baf PluginContentScanner: Use java.util.Optional
Change-Id: I5df1e0b21b727f19ee034e3df54d14d4b54516e1
2016-10-13 16:52:12 -04:00
Dave Borowitz
10b05e7285 Update git submodules
* Update plugins/reviewnotes from branch 'master'
  - Fix errant tab
    
    Change-Id: I58e1d3f7ccb67e468c8b477da3859763a4541c64
    
  - Reduce boilerplate with Maps.immutableEntry
    
    Change-Id: I5b3ea3d33c2e86dd3b7fa0ab0a32490a4a61a0ca
2016-10-13 15:00:58 +00:00
Han-Wen Nienhuys
a2280d455a Update git submodules
* Update plugins/commit-message-length-validator from branch 'master'
  - Ignore IntelliJ *.iml files
    
    Change-Id: I4183c9a9e2841e40dd977af8212bb6c61bdd3c8a
    * Update plugins/cookbook-plugin from branch 'master'
  - Ignore IntelliJ *.iml files
    
    Change-Id: I330430909075a5dc751fe18aaa7b5b72940469b1
    * Update plugins/replication from branch 'master'
  - Ignore IntelliJ *.iml files
    
    Change-Id: I7397e53a9d82137b0669ff47dd36f45b8a056fb7
    * Update plugins/singleusergroup from branch 'master'
  - Ignore IntelliJ *.iml files
    
    Change-Id: Ib0386f5453ae472cd703d5257fcd163d821f2d2c
    * Update plugins/download-commands from branch 'master'
  - Ignore IntelliJ *.iml files
    
    Change-Id: I6c722396f5d995e631af78deb7c02017f10eccfd
    * Update plugins/reviewnotes from branch 'master'
  - Ignore IntelliJ *.iml files
    
    Change-Id: I2997884b7ab1a39177f97310db465bfa64c79c09
2016-10-04 11:25:01 +00:00
David Ostrovsky
af71968891 Bazel: Fix build for core plugins
I382757618 added the Bazel build for core pluins, but missed to add
plugins/BUILD file.

TEST PLAN:

  bazel build release
  unzip -t bazel-bin/release.war | grep --regex "plugins/.*.jar" | wc -l
  6

Change-Id: I3338541ec61905db6658761fa5c6fc374dba0348
2016-09-29 21:12:53 +02:00
David Pursehouse
85c88c9708 Update git submodules
* Update plugins/hooks from branch 'master'
  - Merge branch 'stable-2.13'
    
    * stable-2.13:
      Add --change-url with correct value
    
    Change-Id: I6bf2b4c547d206190ff32702c2eeb1b942f1b377
    
  - Add --change-url with correct value
    
    Create the URL with the change-id rather than the change number.
    
    Change-Id: I7fb753fec0bc776c593062e3e44f48dd9004b085
2016-09-27 11:54:15 +00:00
Claudio Pacchiega
76b1375aa8 Update git submodules
* Update plugins/replication from branch 'master'
  - Removed the recommendation for ssh
    
    As discussed many times during the Gerrit conferences and hackathons,
    Git/SSH replication on Gerrit isn't stable enough due to the JSch
    client stack. Removing the recommendation from the documentation
    may help in choosing alternative methods.
    
    Change-Id: I3c8646135999d6cbb99b58d83d42655d25ea23e9
2016-09-24 07:20:52 +00:00
David Pursehouse
f725b07c2c Merge "Bazel: Build core plugins"
* submodules:
* Update plugins/commit-message-length-validator from branch 'master'
  - Implement Bazel build
    
    Change-Id: I246cdd00923d36c11a678b250ef6a91a5e433943
    * Update plugins/replication from branch 'master'
  - Implement Bazel build
    
    Change-Id: Ia6dc6ba50faeddd300d94aabdbef97b07cdb741d
    * Update plugins/singleusergroup from branch 'master'
  - Implement Bazel build
    
    Change-Id: Ia0d8fa1b91ea4db94e0da951604aac02ffde8662
    * Update plugins/hooks from branch 'master'
  - Implement Bazel build
    
    Change-Id: I7b6f05032b7329b992d8aefe0bbff63f357b0df5
    * Update plugins/download-commands from branch 'master'
  - Implement Bazel build
    
    Change-Id: I74da3f186e166aae5070b7458ade3f12714d8548
    * Update plugins/reviewnotes from branch 'master'
  - Implement Bazel build
    
    Change-Id: I8cc93cc87284340f48735925313d602a11dba716
2016-09-23 12:37:13 +00:00
David Ostrovsky
1579890639 Update git submodules
* Update plugins/replication from branch 'master'
  - Remove dependencies exported in the plugin API
    
    Change-Id: I3f0b3d33a8819e6489629b34706c72b4ab3d3f1c
2016-09-23 12:28:08 +00:00
David Pursehouse
ff7679320a Update git submodules
* Update plugins/cookbook-plugin from branch 'master'
  - Remove unused imports
    
    Change-Id: I448a2f2567fff0b0bdc81d04e20759fd1c5aafa5
2016-09-23 10:06:09 +00:00
David Ostrovsky
bb6f0b13bf Update git submodules
* Update plugins/replication from branch 'master'
  - Make JUint test not inherit from TestCase
    
    Change-Id: Ic627b67c1e9c0830708dba475c911e0c478887aa
2016-09-23 09:55:24 +00:00