Many of the acceptance test rely for their assertions on unique
timestamps. This is achieved by setting a clock step. E.g. a clock step
of one second means that two subsequent timestamps differ by 1 second.
Test classes set the clock step in a setup method that is annotated with
@Before or @BeforeClass, and then they reset the clock to use system
time in a cleanup method that is annotated with @After or @AfterClass.
On method level setting a clock step must have a finally block to unset
it when the test is done.
This results in a lot of boilerplate code and is also error-prone (e.g.
some tests didn't reset the clock to use system time after setting a
clock step).
The new UseClockStep annotation makes this easier and less error-prone.
If this annotation is set (either on class or method level)
AbstractDaemonTest takes care to set and unset clock steps.
By default @UseClockStep uses a clock step of 1 second, which is what
most tests use, but the clock step and the clock step unit can be
specified explicitly. In addition it's possible to request setting the
clock initially to Instant.EPOCH which some tests require.
If a test class uses a clock step single methods in this class can
override this setting by using the UseSystemTime annotation.
In addition this change adds a UseTimezone annotation that allows to set
the timezone for the test execution. Here too using the annotation
relieves the tests from caring to reset the timezone after the test is
done.
All tests that set a clock step or a timezone are adapted to use the new
annotations.
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Iff0429cedadaea8538fd5ab96417241762f5a588
00da932fab