00da932fab
Many of the acceptance test rely for their assertions on unique timestamps. This is achieved by setting a clock step. E.g. a clock step of one second means that two subsequent timestamps differ by 1 second. Test classes set the clock step in a setup method that is annotated with @Before or @BeforeClass, and then they reset the clock to use system time in a cleanup method that is annotated with @After or @AfterClass. On method level setting a clock step must have a finally block to unset it when the test is done. This results in a lot of boilerplate code and is also error-prone (e.g. some tests didn't reset the clock to use system time after setting a clock step). The new UseClockStep annotation makes this easier and less error-prone. If this annotation is set (either on class or method level) AbstractDaemonTest takes care to set and unset clock steps. By default @UseClockStep uses a clock step of 1 second, which is what most tests use, but the clock step and the clock step unit can be specified explicitly. In addition it's possible to request setting the clock initially to Instant.EPOCH which some tests require. If a test class uses a clock step single methods in this class can override this setting by using the UseSystemTime annotation. In addition this change adds a UseTimezone annotation that allows to set the timezone for the test execution. Here too using the annotation relieves the tests from caring to reset the timezone after the test is done. All tests that set a clock step or a timezone are adapted to use the new annotations. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Iff0429cedadaea8538fd5ab96417241762f5a588
36 lines
1.2 KiB
Java
36 lines
1.2 KiB
Java
// Copyright (C) 2019 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package com.google.gerrit.acceptance.annotation;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import com.google.gerrit.acceptance.AbstractDaemonTest;
|
|
import com.google.gerrit.acceptance.UseTimezone;
|
|
import org.junit.Test;
|
|
|
|
public class UseTimezoneTest extends AbstractDaemonTest {
|
|
@Test
|
|
@UseTimezone(timezone = "US/Eastern")
|
|
public void usEastern() {
|
|
assertThat(System.getProperty("user.timezone")).isEqualTo("US/Eastern");
|
|
}
|
|
|
|
@Test
|
|
@UseTimezone(timezone = "UTC")
|
|
public void utc() {
|
|
assertThat(System.getProperty("user.timezone")).isEqualTo("UTC");
|
|
}
|
|
}
|