035c74f508
- Refactors the _editDraft property of gr-diff-comment to _messageText. - Renames the gr-storage element as instantiated in gr-diff-comment from "localStorage" to "storage". - The gr-storage diff comment functions are refactored to include "comment" in their names and to accept a location object rather than 4 separate arguments. - Added a comment describing the use of a promise in the _loadLocalDraft method of gr-diff-comment. - Throttled the invocation of the _cleanupDrafts method of gr-storage to avoid potentially expensive crawls over all localStorage entries. - Various other smaller fixes. Bug: Issue 3787 Change-Id: Idf96051c0d56d6ce8b15f55ca2680363bd1ca805
PolyGerrit
Installing Node.js
# Debian/Ubuntu
sudo apt-get install nodejs-legacy
# OS X with Homebrew
brew install node
All other platforms: download from nodejs.org.
Optional: installing go
This is only required for running the run-server.sh script for testing. See below.
# Debian/Ubuntu
sudo apt-get install golang
# OS X with Homebrew
brew install go
All other platforms: download from golang.org
Add [go] to your path
PATH=$PATH:/usr/local/go/bin
Local UI, Production Data
To test the local UI against gerrit-review.googlesource.com:
./polygerrit-ui/run-server.sh
Then visit http://localhost:8081
Local UI, Test Data
One-time setup:
- Install Buck for building Gerrit.
- Build Gerrit and set up a local test site.
Run a test server:
buck build polygerrit && \
java -jar buck-out/gen/polygerrit/polygerrit.war daemon --polygerrit-dev -d ../gerrit_testsite --console-log --show-stack-trace
Running Tests
One-time setup:
# Debian/Ubuntu
sudo apt-get install npm
# OS X with Homebrew
brew install npm
# All platforms (including those above)
sudo npm install -g web-component-tester
Run all web tests:
buck test --no-results-cache --include web
The --no-results-cache flag prevents flaky test failures from being
cached.
If you need to pass additional arguments to wct:
WCT_ARGS='-p --some-flag="foo bar"' buck test --no-results-cache --include web
For interactively working on a single test file, do the following:
./polygerrit-ui/run-server.sh
Then visit http://localhost:8081/elements/foo/bar_test.html
Style guide
We follow the Google JavaScript Style Guide with a few exceptions. When in doubt, remain consistent with the code around you.