gerrit/polygerrit-ui/app/elements/admin
Wyatt Allen 292d013f32 Decode inheritance project IDs before use
In the JSON of emitted by the repo list endpoint, the project IDs are
URL-encoded using java.net.URLEncoder.encode. While the Java function
encodes spaces as plus-signs, the JavaScript decodeURLComponent does
not.

As a result, when editing the "inherits from" field of a project's
access settings where the parent project's ID includes spaces, the
payload would use an improperly decoded parent value, and this would be
rejected by the API for failing to identify the parent.

Add a new decoding method to the URL encoding behavior that better
matches the style of encoding used by java.net.URLEncoder. Because the
behavior had no test coverage before, it's moved to a new location and
a suite of tests are added. Add tests for the access screen properly
encoding and decoding parent IDs.

Change-Id: Icb1d28d8f1f88c3c7373aa1c8953238a61c32ace
2018-07-30 18:25:47 -07:00
..
gr-access-section Use color constant for access section 2018-07-13 09:33:54 -07:00
gr-admin-group-list Add @license tags to PG HTML and JS assets 2018-03-26 10:47:55 -04:00
gr-admin-view Decode inheritance project IDs before use 2018-07-30 18:25:47 -07:00
gr-confirm-delete-item-dialog Add @license tags to PG HTML and JS assets 2018-03-26 10:47:55 -04:00
gr-create-change-dialog Decode inheritance project IDs before use 2018-07-30 18:25:47 -07:00
gr-create-group-dialog Decode inheritance project IDs before use 2018-07-30 18:25:47 -07:00
gr-create-pointer-dialog Decode inheritance project IDs before use 2018-07-30 18:25:47 -07:00
gr-create-repo-dialog Decode inheritance project IDs before use 2018-07-30 18:25:47 -07:00
gr-group Replace more CSS vars with constants 2018-05-09 20:54:39 -07:00
gr-group-audit-log Bug fixes for gr-group-audit-log 2018-05-10 18:56:55 +00:00
gr-group-members Decode inheritance project IDs before use 2018-07-30 18:25:47 -07:00
gr-permission Fix access removal of added item 2018-04-23 14:44:46 -07:00
gr-plugin-list Use page-error in gr-repo-detail-list and gr-plugin-list 2018-03-29 22:33:27 +00:00
gr-repo Merge branch 'stable-2.15' 2018-07-17 13:08:37 +09:00
gr-repo-access Decode inheritance project IDs before use 2018-07-30 18:25:47 -07:00
gr-repo-command Add @license tags to PG HTML and JS assets 2018-03-26 10:47:55 -04:00
gr-repo-commands Consolidate some admin styles 2018-04-19 09:17:49 +00:00
gr-repo-dashboards Fix link generation in gr-repo-dashboards 2018-04-25 09:50:25 -07:00
gr-repo-detail-list Decode inheritance project IDs before use 2018-07-30 18:25:47 -07:00
gr-repo-list Check filter text before setting repos 2018-04-10 23:51:11 +00:00
gr-rule-editor Decode inheritance project IDs before use 2018-07-30 18:25:47 -07:00