gerrit

History

Becky Siegel 0727efa3d1 Implement isOnParent as functions rather than an attribute on comments

Previously, the rest api interface set '__isOnParent' for comments.
When comments were added, the property from the comment thread
'isOnParent' was passed as a property. When the draft was saved, it was
expecting '__isOnParent' rather than 'isOnParent' and this caused
comments to show up on the wrong side after saved/refreshed, because
'__isOnParent' was undefined.

Instead of changing to either '__isOnParent' which would be strange to
pass as an attribute or 'isOnParent' which would look like it came from
the api directly, this change introduces isOnParent functions so that
translation doesn't need to be done with the API.

Bug: Issue 5831
Change-Id: I3b849ba5878275cda0a39638626a12bd51341a29

2017-03-21 14:57:58 -07:00

gr-diff-builder_test.html

Reduce confusion between side and commentSide

2017-03-15 13:50:21 -07:00

gr-diff-builder-image.js

Establish annotation pipeline

2016-07-20 12:25:40 -07:00

gr-diff-builder-side-by-side.js

Allow multiple threads per line, with different ranges

2017-02-01 16:10:08 -08:00

gr-diff-builder-unified.js

Allow multiple threads per line, with different ranges