Files
gerrit/polygerrit-ui/app/elements/shared/gr-button/gr-button.js
Kasper Nilsson 2de6749191 Remove iron-a11y-keys bindings from gr-button
The file-list now uses native event listening to handle `enter`
keypresses (see Issue 7277 for more context). Because gr-button still
used iron-a11y-keys bindings, the `enter` event that was caught and
cancelled by the button was different from the `enter` event that was
caught by the file-list.

Migrating to native event listening on gr-buttons allows the event to be
properly cancelled.

Bug: Issue 7470
Change-Id: I7998243ce16b5cb5e6d3f903f184d39d89a1090d
2017-10-24 11:03:07 -07:00

88 lines
2.1 KiB
JavaScript

// Copyright (C) 2016 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
(function() {
'use strict';
Polymer({
is: 'gr-button',
properties: {
tooltip: String,
downArrow: {
type: Boolean,
reflectToAttribute: true,
},
link: {
type: Boolean,
value: false,
reflectToAttribute: true,
},
disabled: {
type: Boolean,
observer: '_disabledChanged',
reflectToAttribute: true,
},
noUppercase: {
type: Boolean,
value: false,
},
_enabledTabindex: {
type: String,
value: '0',
},
},
listeners: {
tap: '_handleAction',
click: '_handleAction',
keydown: '_handleKeydown',
},
behaviors: [
Gerrit.KeyboardShortcutBehavior,
Gerrit.TooltipBehavior,
],
hostAttributes: {
role: 'button',
tabindex: '0',
},
_handleAction(e) {
if (this.disabled) {
e.preventDefault();
e.stopImmediatePropagation();
}
},
_disabledChanged(disabled) {
if (disabled) {
this._enabledTabindex = this.getAttribute('tabindex');
}
this.setAttribute('tabindex', disabled ? '-1' : this._enabledTabindex);
},
_handleKeydown(e) {
if (this.modifierPressed(e)) { return; }
e = this.getKeyboardEvent(e);
// Handle `enter`, `space`.
if (e.keyCode === 13 || e.keyCode === 32) {
e.preventDefault();
e.stopPropagation();
this.click();
}
},
});
})();