Files
gerrit/java/com
Edwin Kempin 08a4c9aac5 Submit: Return updated changes from SubmitStrategyOp
This way Submit doesn't need to reload the submitted change just to
return the updated change to the caller.

This likely fixes an issue that we observe multiple times per day at
Google. When the merged change is reloaded after submit its status is
still NEW and not as expected MERGED. This is because loading the change
notes reads an old change state (old meta commit) where the change
status was not updated yet. This is specific to our infrastructure where
we are not guranteed to see the latest ref updates if we reopen a
repository after a write operation had been done.

BatchUpdate is not atomic, so it can be that on a failure some of the
changes were actually merged. This is why MergeOp must collect the
updated changes also when an exception during the BatchUpdate execution
was thrown.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I5b5b97c56eee2fc85202e5ff7584993fc0f359f8
2019-08-29 08:10:19 +02:00
..