26bdf6bab5
Each item of the My menu (called Your in PolyGerrit) is configurable by the user. There is a target property on each item, but currently no UI by which the user can set it. Therefore generally we can expect menu items to receive the default value for this property. Unfortunately, the default value is contingent on whether the server thinks the URL is a view in the GWT UI (by looking for a leading '#'). PolyGerrit URLs do not conform to this expectation, so our default menu items are typically presented by the server as pop-out links. Previously this wasn't a concern because the top menu didn't support pop-out links. We introduced support for this with the Documentation menu in https://gerrit-review.googlesource.com/c/104393/. Bug: Issue 6109 Change-Id: I2455bca5ca6250939ff0a9c3b62679aa6d24dadb
PolyGerrit
Installing Node.js
# Debian/Ubuntu
sudo apt-get install nodejs-legacy
# OS X with Homebrew
brew install node
All other platforms: download from nodejs.org.
Installing Bazel
Follow the instructions here to get and install Bazel.
Local UI, Production Data
This is a quick and easy way to test your local changes against real data. Unfortunately, you can't sign in, so testing certain features will require you to use the "test data" technique described below.
Installing go
This is required for running the run-server.sh script below.
# Debian/Ubuntu
sudo apt-get install golang
# OS X with Homebrew
brew install go
All other platforms: download from golang.org
Then add go to your path:
PATH=$PATH:/usr/local/go/bin
Running the server
To test the local UI against gerrit-review.googlesource.com:
./run-server.sh
Then visit http://localhost:8081
Local UI, Test Data
One-time setup:
- Build Gerrit
- Set up a local test site. Docs here and here.
When your project is set up and works using the classic UI, run a test server that serves PolyGerrit:
bazel build polygerrit &&
$(bazel info output_base)/external/local_jdk/bin/java \
-jar bazel-bin/polygerrit.war daemon --polygerrit-dev \
-d ../gerrit_testsite --console-log --show-stack-trace
Running Tests
One-time setup:
# Debian/Ubuntu
sudo apt-get install npm
# OS X with Homebrew
brew install npm
# All platforms (including those above)
sudo npm install -g web-component-tester
Run all web tests:
./polygerrit-ui/app/run_test.sh
To allow the tests to run in Safari it is necessary to enable the "Allow Remote Automation" option under the "Develop" menu.
If you need to pass additional arguments to wct:
WCT_ARGS='-p --some-flag="foo bar"' ./polygerrit-ui/app/run_test.sh
For interactively working on a single test file, do the following:
./polygerrit-ui/run-server.sh
Then visit http://localhost:8081/elements/foo/bar_test.html
Style guide
We follow the Google JavaScript Style Guide with a few exceptions. When in doubt, remain consistent with the code around you.