41816a3d00
When a change has all required labels, but is not submittable for some other reason (such as unready dependency changes), the "Ready to Submit" chip can be misleading. To avoid this confusion, only show the chip when the "Submit" change action is enabled. Bug: Issue 8755 Change-Id: I7cd4472a52d9bf247f1d0ed5e90c89e95dbc3914
234 lines
7.0 KiB
HTML
234 lines
7.0 KiB
HTML
<!DOCTYPE html>
|
|
<!--
|
|
@license
|
|
Copyright (C) 2017 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
|
<title>keyboard-shortcut-behavior</title>
|
|
|
|
<script src="../../bower_components/webcomponentsjs/webcomponents.min.js"></script>
|
|
<script src="../../bower_components/web-component-tester/browser.js"></script>
|
|
<link rel="import" href="../../test/common-test-setup.html"/>
|
|
<script>
|
|
/** @type {string} */
|
|
window.CANONICAL_PATH = '/r';
|
|
</script>
|
|
|
|
<link rel="import" href="../base-url-behavior/base-url-behavior.html">
|
|
<link rel="import" href="rest-client-behavior.html">
|
|
|
|
<test-fixture id="basic">
|
|
<template>
|
|
<test-element></test-element>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<test-fixture id="within-overlay">
|
|
<template>
|
|
<gr-overlay>
|
|
<test-element></test-element>
|
|
</gr-overlay>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<script>
|
|
suite('rest-client-behavior tests', () => {
|
|
let element;
|
|
// eslint-disable-next-line no-unused-vars
|
|
let overlay;
|
|
|
|
suiteSetup(() => {
|
|
// Define a Polymer element that uses this behavior.
|
|
Polymer({
|
|
is: 'test-element',
|
|
behaviors: [
|
|
Gerrit.BaseUrlBehavior,
|
|
Gerrit.RESTClientBehavior,
|
|
],
|
|
});
|
|
});
|
|
|
|
setup(() => {
|
|
element = fixture('basic');
|
|
overlay = fixture('within-overlay');
|
|
});
|
|
|
|
test('changeBaseURL', () => {
|
|
assert.deepEqual(
|
|
element.changeBaseURL('1', '1'),
|
|
'/r/changes/1/revisions/1'
|
|
);
|
|
});
|
|
|
|
test('changePath', () => {
|
|
assert.deepEqual(element.changePath('1'), '/r/c/1');
|
|
});
|
|
|
|
test('Open status', () => {
|
|
const change = {
|
|
change_id: 'Iad9dc96274af6946f3632be53b106ef80f7ba6ca',
|
|
revisions: {
|
|
rev1: {_number: 1},
|
|
},
|
|
current_revision: 'rev1',
|
|
status: 'NEW',
|
|
labels: {},
|
|
mergeable: true,
|
|
};
|
|
let statuses = element.changeStatuses(change);
|
|
const statusString = element.changeStatusString(change);
|
|
assert.deepEqual(statuses, []);
|
|
assert.equal(statusString, '');
|
|
|
|
change.submittable = false;
|
|
statuses = element.changeStatuses(change,
|
|
{includeDerived: true});
|
|
assert.deepEqual(statuses, ['Active']);
|
|
|
|
// With no missing labels but no submitEnabled option.
|
|
change.submittable = true;
|
|
statuses = element.changeStatuses(change,
|
|
{includeDerived: true});
|
|
assert.deepEqual(statuses, ['Active']);
|
|
|
|
// Without missing labels and enabled submit
|
|
statuses = element.changeStatuses(change,
|
|
{includeDerived: true, submitEnabled: true});
|
|
assert.deepEqual(statuses, ['Ready to submit']);
|
|
|
|
change.mergeable = false;
|
|
change.submittable = true;
|
|
statuses = element.changeStatuses(change,
|
|
{includeDerived: true});
|
|
assert.deepEqual(statuses, ['Merge Conflict']);
|
|
|
|
delete change.mergeable;
|
|
change.submittable = true;
|
|
statuses = element.changeStatuses(change,
|
|
{includeDerived: true, mergeable: true, submitEnabled: true});
|
|
assert.deepEqual(statuses, ['Ready to submit']);
|
|
|
|
change.submittable = true;
|
|
statuses = element.changeStatuses(change,
|
|
{includeDerived: true, mergeable: false});
|
|
assert.deepEqual(statuses, ['Merge Conflict']);
|
|
});
|
|
|
|
test('Merge conflict', () => {
|
|
const change = {
|
|
change_id: 'Iad9dc96274af6946f3632be53b106ef80f7ba6ca',
|
|
revisions: {
|
|
rev1: {_number: 1},
|
|
},
|
|
current_revision: 'rev1',
|
|
status: 'NEW',
|
|
labels: {},
|
|
mergeable: false,
|
|
};
|
|
const statuses = element.changeStatuses(change);
|
|
const statusString = element.changeStatusString(change);
|
|
assert.deepEqual(statuses, ['Merge Conflict']);
|
|
assert.equal(statusString, 'Merge Conflict');
|
|
});
|
|
|
|
test('mergeable prop undefined', () => {
|
|
const change = {
|
|
change_id: 'Iad9dc96274af6946f3632be53b106ef80f7ba6ca',
|
|
revisions: {
|
|
rev1: {_number: 1},
|
|
},
|
|
current_revision: 'rev1',
|
|
status: 'NEW',
|
|
labels: {},
|
|
};
|
|
const statuses = element.changeStatuses(change);
|
|
const statusString = element.changeStatusString(change);
|
|
assert.deepEqual(statuses, []);
|
|
assert.equal(statusString, '');
|
|
});
|
|
|
|
test('Merged status', () => {
|
|
const change = {
|
|
change_id: 'Iad9dc96274af6946f3632be53b106ef80f7ba6ca',
|
|
revisions: {
|
|
rev1: {_number: 1},
|
|
},
|
|
current_revision: 'rev1',
|
|
status: 'MERGED',
|
|
labels: {},
|
|
};
|
|
const statuses = element.changeStatuses(change);
|
|
const statusString = element.changeStatusString(change);
|
|
assert.deepEqual(statuses, ['Merged']);
|
|
assert.equal(statusString, 'Merged');
|
|
});
|
|
|
|
test('Abandoned status', () => {
|
|
const change = {
|
|
change_id: 'Iad9dc96274af6946f3632be53b106ef80f7ba6ca',
|
|
revisions: {
|
|
rev1: {_number: 1},
|
|
},
|
|
current_revision: 'rev1',
|
|
status: 'ABANDONED',
|
|
labels: {},
|
|
};
|
|
const statuses = element.changeStatuses(change);
|
|
const statusString = element.changeStatusString(change);
|
|
assert.deepEqual(statuses, ['Abandoned']);
|
|
assert.equal(statusString, 'Abandoned');
|
|
});
|
|
|
|
test('Open status with private and wip', () => {
|
|
const change = {
|
|
change_id: 'Iad9dc96274af6946f3632be53b106ef80f7ba6ca',
|
|
revisions: {
|
|
rev1: {_number: 1},
|
|
},
|
|
current_revision: 'rev1',
|
|
status: 'NEW',
|
|
is_private: true,
|
|
work_in_progress: true,
|
|
labels: {},
|
|
mergeable: true,
|
|
};
|
|
const statuses = element.changeStatuses(change);
|
|
const statusString = element.changeStatusString(change);
|
|
assert.deepEqual(statuses, ['WIP', 'Private']);
|
|
assert.equal(statusString, 'WIP, Private');
|
|
});
|
|
|
|
test('Merge conflict with private and wip', () => {
|
|
const change = {
|
|
change_id: 'Iad9dc96274af6946f3632be53b106ef80f7ba6ca',
|
|
revisions: {
|
|
rev1: {_number: 1},
|
|
},
|
|
current_revision: 'rev1',
|
|
status: 'NEW',
|
|
is_private: true,
|
|
work_in_progress: true,
|
|
labels: {},
|
|
mergeable: false,
|
|
};
|
|
const statuses = element.changeStatuses(change);
|
|
const statusString = element.changeStatusString(change);
|
|
assert.deepEqual(statuses, ['Merge Conflict', 'WIP', 'Private']);
|
|
assert.equal(statusString, 'Merge Conflict, WIP, Private');
|
|
});
|
|
});
|
|
</script>
|