Tapping empty space in file list rows would formerly expand the diff if
the user enabled the expand_inline_diffs preference. If not enabled,
clicking the row would navigate to the individual diff view.
With this change, only clicking on the file link itself (or pressing
Enter/O) navigates to the diff view. Clicking anywhere else in the row
(besides buttons) will expand inline.
Interaction: | Before this change: | After this change:
-----------------------+-----------------------+-----------------------
Tapping the link | Toggle inline if | Go to the view
| expand_inline_diffs=1 |
| otherwise go to view |
-----------------------+-----------------------+-----------------------
Tapping the row (not | Toggle inline if | Toggle inline diff
the link or any | expand_inline_diffs=1 |
buttons) | otherwise go to view |
-----------------------+-----------------------+-----------------------
Tapping the expand | Toggle inline diff | Toggle inline diff
button. | | (no change)
-----------------------+-----------------------+-----------------------
Pressing Enter/o on a | Toggle inline if | Go to the view
selected file. | expand_inline_diffs=1 |
| otherwise go to view |
-----------------------+-----------------------+-----------------------
Pressing i on a | Toggle inline diff | Toggle inline diff
selected file. | | (no change)
Now that the file list ignores expand_inline_diffs, the preference is
removed from the settings view.
Feature: Issue 8218
Change-Id: I63c642a9a5aaa24114e6f21c694327ae51ceb614
62f3ecbda7