9399efcfde
When the expand inline diffs preference is present, clicking on any button in gr-edit-file-controls would cause the diff to expand. Adding stopPropagation and preventDefault calls to the elements inside the applicable element prevents these tap events from bubbling further. Change-Id: I90d5af54fd28b70b23e8d2d6183df6649370ff0d
67 lines
1.9 KiB
JavaScript
67 lines
1.9 KiB
JavaScript
// Copyright (C) 2017 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
(function() {
|
|
'use strict';
|
|
|
|
Polymer({
|
|
is: 'gr-edit-file-controls',
|
|
|
|
/**
|
|
* Fired when an action in the overflow menu is tapped.
|
|
*
|
|
* @event file-action-tap
|
|
*/
|
|
|
|
properties: {
|
|
filePath: String,
|
|
// Edit action not needed in the overflow.
|
|
_allFileActions: {
|
|
type: Array,
|
|
value: () => Object.values(GrEditConstants.Actions)
|
|
.filter(action => action !== GrEditConstants.Actions.EDIT),
|
|
},
|
|
_fileActions: {
|
|
type: Array,
|
|
computed: '_computeFileActions(_allFileActions)',
|
|
},
|
|
},
|
|
|
|
_handleEditTap(e) {
|
|
e.preventDefault();
|
|
e.stopPropagation();
|
|
this._dispatchFileAction(GrEditConstants.Actions.EDIT.id, this.filePath);
|
|
},
|
|
|
|
_handleActionTap(e) {
|
|
e.preventDefault();
|
|
e.stopPropagation();
|
|
this._dispatchFileAction(e.detail.id, this.filePath);
|
|
},
|
|
|
|
_dispatchFileAction(action, path) {
|
|
this.dispatchEvent(new CustomEvent('file-action-tap',
|
|
{detail: {action, path}, bubbles: true}));
|
|
},
|
|
|
|
_computeFileActions(actions) {
|
|
// TODO(kaspern): conditionally disable some actions based on file status.
|
|
return actions.map(action => {
|
|
return {
|
|
name: action.label,
|
|
id: action.id,
|
|
};
|
|
});
|
|
},
|
|
});
|
|
})(); |