20c2fd4f0b
This change is fixing "All Java build rules should be loaded from Starlark" warning flagged by latest buildifier version: [1]. Python rules are now also loaded from the Starlark. Also extract codemirror library import to BUILD file. This is needed to avoid cycle in the workspace file, after importing java rules from Starlark. [1] https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#native-java Change-Id: I36192c9465d988b25cf09c250e110f15850910cd
135 lines
4.8 KiB
Python
135 lines
4.8 KiB
Python
load("@rules_python//python:defs.bzl", "py_binary")
|
|
load("@rules_java//java:defs.bzl", "java_package_configuration")
|
|
load(
|
|
"@bazel_tools//tools/jdk:default_java_toolchain.bzl",
|
|
"JDK9_JVM_OPTS",
|
|
"default_java_toolchain",
|
|
)
|
|
|
|
py_binary(
|
|
name = "merge_jars",
|
|
srcs = ["merge_jars.py"],
|
|
main = "merge_jars.py",
|
|
visibility = ["//visibility:public"],
|
|
)
|
|
|
|
default_java_toolchain(
|
|
name = "error_prone_warnings_toolchain",
|
|
bootclasspath = ["@bazel_tools//tools/jdk:platformclasspath.jar"],
|
|
jvm_opts = JDK9_JVM_OPTS,
|
|
package_configuration = [
|
|
":error_prone",
|
|
],
|
|
visibility = ["//visibility:public"],
|
|
)
|
|
|
|
# Error Prone errors enabled by default; see ../.bazelrc for how this is
|
|
# enabled. This warnings list is originally based on:
|
|
# https://github.com/bazelbuild/BUILD_file_generator/blob/master/tools/bazel_defs/java.bzl
|
|
# However, feel free to add any additional errors. Thus far they have all been pretty useful.
|
|
java_package_configuration(
|
|
name = "error_prone",
|
|
javacopts = [
|
|
"-XepDisableWarningsInGeneratedCode",
|
|
"-Xep:MissingCasesInEnumSwitch:ERROR",
|
|
"-Xep:ReferenceEquality:WARN",
|
|
"-Xep:StringEquality:WARN",
|
|
"-Xep:WildcardImport:WARN",
|
|
"-Xep:AmbiguousMethodReference:WARN",
|
|
"-Xep:BadAnnotationImplementation:WARN",
|
|
"-Xep:BadComparable:WARN",
|
|
"-Xep:BoxedPrimitiveConstructor:ERROR",
|
|
"-Xep:CannotMockFinalClass:WARN",
|
|
"-Xep:ClassCanBeStatic:WARN",
|
|
"-Xep:ClassNewInstance:WARN",
|
|
"-Xep:DefaultCharset:ERROR",
|
|
"-Xep:DoubleCheckedLocking:WARN",
|
|
"-Xep:ElementsCountedInLoop:WARN",
|
|
"-Xep:EqualsHashCode:WARN",
|
|
"-Xep:EqualsIncompatibleType:WARN",
|
|
"-Xep:ExpectedExceptionChecker:ERROR",
|
|
"-Xep:Finally:WARN",
|
|
"-Xep:FloatingPointLiteralPrecision:WARN",
|
|
"-Xep:FragmentInjection:WARN",
|
|
"-Xep:FragmentNotInstantiable:WARN",
|
|
"-Xep:FunctionalInterfaceClash:WARN",
|
|
"-Xep:FutureReturnValueIgnored:WARN",
|
|
"-Xep:GetClassOnEnum:WARN",
|
|
"-Xep:ImmutableAnnotationChecker:WARN",
|
|
"-Xep:ImmutableEnumChecker:WARN",
|
|
"-Xep:IncompatibleModifiers:WARN",
|
|
"-Xep:InjectOnConstructorOfAbstractClass:WARN",
|
|
"-Xep:InputStreamSlowMultibyteRead:WARN",
|
|
"-Xep:IterableAndIterator:WARN",
|
|
"-Xep:JUnit3FloatingPointComparisonWithoutDelta:WARN",
|
|
"-Xep:JUnitAmbiguousTestClass:WARN",
|
|
"-Xep:LiteralClassName:WARN",
|
|
"-Xep:MissingFail:WARN",
|
|
"-Xep:MissingOverride:WARN",
|
|
"-Xep:MutableConstantField:WARN",
|
|
"-Xep:NarrowingCompoundAssignment:WARN",
|
|
"-Xep:NonAtomicVolatileUpdate:WARN",
|
|
"-Xep:NonOverridingEquals:WARN",
|
|
"-Xep:NullableConstructor:WARN",
|
|
"-Xep:NullablePrimitive:WARN",
|
|
"-Xep:NullableVoid:WARN",
|
|
"-Xep:OperatorPrecedence:WARN",
|
|
"-Xep:OverridesGuiceInjectableMethod:WARN",
|
|
"-Xep:PreconditionsInvalidPlaceholder:WARN",
|
|
"-Xep:ProtoFieldPreconditionsCheckNotNull:WARN",
|
|
"-Xep:ProtocolBufferOrdinal:WARN",
|
|
"-Xep:RequiredModifiers:WARN",
|
|
"-Xep:ShortCircuitBoolean:WARN",
|
|
"-Xep:SimpleDateFormatConstant:WARN",
|
|
"-Xep:StaticGuardedByInstance:WARN",
|
|
"-Xep:SynchronizeOnNonFinalField:WARN",
|
|
"-Xep:TruthConstantAsserts:WARN",
|
|
"-Xep:TypeParameterShadowing:WARN",
|
|
"-Xep:TypeParameterUnusedInFormals:WARN",
|
|
"-Xep:URLEqualsHashCode:WARN",
|
|
"-Xep:UnsynchronizedOverridesSynchronized:WARN",
|
|
"-Xep:WaitNotInLoop:WARN",
|
|
],
|
|
packages = ["error_prone_packages"],
|
|
)
|
|
|
|
package_group(
|
|
name = "error_prone_packages",
|
|
packages = [
|
|
"//gerrit-acceptance-framework/...",
|
|
"//gerrit-acceptance-tests/...",
|
|
"//gerrit-cache-h2/...",
|
|
"//gerrit-cache-mem/...",
|
|
"//gerrit-common/...",
|
|
"//gerrit-elasticsearch/...",
|
|
"//gerrit-extension-api/...",
|
|
"//gerrit-gpg/...",
|
|
"//gerrit-httpd/...",
|
|
"//gerrit-launcher/...",
|
|
"//gerrit-lucene/...",
|
|
"//gerrit-main/...",
|
|
"//gerrit-oauth/...",
|
|
"//gerrit-openid/...",
|
|
"//gerrit-patch-commonsnet/...",
|
|
"//gerrit-patch-jgit/...",
|
|
"//gerrit-pgm/...",
|
|
"//gerrit-plugin-api/...",
|
|
"//gerrit-plugin-gwtui/...",
|
|
"//gerrit-prettify/...",
|
|
"//gerrit-reviewdb/...",
|
|
"//gerrit-server/...",
|
|
"//gerrit-sshd/...",
|
|
"//gerrit-test-util/...",
|
|
"//gerrit-util-cli/...",
|
|
"//gerrit-util-http/...",
|
|
"//gerrit-util-ssl/...",
|
|
"//gerrit-war/...",
|
|
"//plugins/commit-message-length-validator/...",
|
|
"//plugins/download-commands/...",
|
|
"//plugins/hooks/...",
|
|
"//plugins/replication/...",
|
|
"//plugins/reviewnotes/...",
|
|
"//plugins/singleusergroup/...",
|
|
],
|
|
)
|