opendev/gerrit
Code Issues Proposed changes
Files
2768119c2faace3c770c4cbdad901b6da6de1d8a
gerrit/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list_test.html
Andrew Bonventre 4d22c7e835 Cleanup: use iron-a11y-keys-behavior for keyboard shortcuts 
+ This does not cover on-keydown handlers within elements.
  A follow-up change will account for those.
+ Keyboard shortcuts are disabled within gr-overlay, input,
  and textarea elements.
+ Added tests for new behavior (plus some missing ones covering
  broken behavior).
+ Removed blur hacks used on elements to placate the kb
  shortcuts due to restrictions that have been removed.

Bug: Issue 4198
Change-Id: Ide8009a3bfc340a35a8ec8b9189a85b49c8a95aa
2016-11-17 15:27:59 -08:00

300 lines
10 KiB
HTML
Raw Blame History

<!DOCTYPE html>
<!--
Copyright (C) 2015 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
<title>gr-change-list</title>
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
<script src="../../../bower_components/web-component-tester/browser.js"></script>
<script src="../../../bower_components/page/page.js"></script>
<link rel="import" href="../../../bower_components/iron-test-helpers/iron-test-helpers.html">
<link rel="import" href="gr-change-list.html">
<test-fixture id="basic">
<template>
<gr-change-list></gr-change-list>
</template>
</test-fixture>
<test-fixture id="grouped">
<template>
<gr-change-list></gr-change-list>
</template>
</test-fixture>
<script>
suite('gr-change-list basic tests', function() {
var element;
setup(function() {
element = fixture('basic');
});
function stubRestAPI(preferences) {
var loggedInPromise = Promise.resolve(preferences !== null);
var preferencesPromise = Promise.resolve(preferences);
stub('gr-rest-api-interface', {
getLoggedIn: sinon.stub().returns(loggedInPromise),
getPreferences: sinon.stub().returns(preferencesPromise),
});
return Promise.all([loggedInPromise, preferencesPromise]);
}
suite('test show change number not logged in', function() {
setup(function(done) {
return stubRestAPI(null).then(function() {
element = fixture('basic');
element._loadPreferences().then(function() { done(); });
});
});
test('show number disabled', function() {
assert.isFalse(element.showNumber);
});
});
suite('test show change number preference enabled', function() {
setup(function(done) {
return stubRestAPI(
{legacycid_in_change_table: true, time_format: 'HHMM_12'}
).then(function() {
element = fixture('basic');
element._loadPreferences().then(function() { done(); });
});
});
test('show number enabled', function() {
assert.isTrue(element.showNumber);
});
});
suite('test show change number preference disabled', function() {
setup(function(done) {
// legacycid_in_change_table is not set when false.
return stubRestAPI(
{time_format: 'HHMM_12'}
).then(function() {
element = fixture('basic');
element._loadPreferences().then(function() { done(); });
});
});
test('show number disabled', function() {
assert.isFalse(element.showNumber);
});
});
test('computed fields', function() {
assert.equal(element._computeLabelNames(
[[{_number: 0, labels: {}}]]).length, 0);
assert.equal(element._computeLabelNames([[
{_number: 0, labels: {Verified: {approved: {}}}},
{_number: 1, labels: {
Verified: {approved: {}}, 'Code-Review': {approved: {}}}},
{_number: 2, labels: {
Verified: {approved: {}}, 'Library-Compliance': {approved: {}}}},
]]).length, 3);
assert.equal(element._computeLabelShortcut('Code-Review'), 'CR');
assert.equal(element._computeLabelShortcut('Verified'), 'V');
assert.equal(element._computeLabelShortcut('Library-Compliance'), 'LC');
assert.equal(element._computeLabelShortcut(
'Some-Special-Label-7'), 'SSL7');
});
test('keyboard shortcuts', function(done) {
element.selectedIndex = 0;
element.changes = [
{_number: 0},
{_number: 1},
{_number: 2},
];
flushAsynchronousOperations();
var elementItems = Polymer.dom(element.root).querySelectorAll(
'gr-change-list-item');
assert.equal(elementItems.length, 3);
flush(function() {
assert.isTrue(elementItems[0].selected);
MockInteractions.pressAndReleaseKeyOn(element, 74, null, 'j');
assert.equal(element.selectedIndex, 1);
MockInteractions.pressAndReleaseKeyOn(element, 74, null, 'j');
var showStub = sinon.stub(page, 'show');
assert.equal(element.selectedIndex, 2);
MockInteractions.pressAndReleaseKeyOn(element, 13, null, 'enter');
assert(showStub.lastCall.calledWithExactly('/c/2/'),
'Should navigate to /c/2/');
MockInteractions.pressAndReleaseKeyOn(element, 75, null, 'k');
assert.equal(element.selectedIndex, 1);
MockInteractions.pressAndReleaseKeyOn(element, 13, null, 'enter');
assert(showStub.lastCall.calledWithExactly('/c/1/'),
'Should navigate to /c/1/');
MockInteractions.pressAndReleaseKeyOn(element, 75, null, 'k');
MockInteractions.pressAndReleaseKeyOn(element, 75, null, 'k');
MockInteractions.pressAndReleaseKeyOn(element, 75, null, 'k');
assert.equal(element.selectedIndex, 0);
showStub.restore();
done();
});
});
test('changes needing review', function() {
element.changes = [
{
_number: 0,
status: 'NEW',
reviewed: true,
owner: {_account_id: 0},
},
{
_number: 1,
status: 'NEW',
owner: {_account_id: 0},
},
{
_number: 2,
status: 'MERGED',
owner: {_account_id: 0},
},
{
_number: 3,
status: 'DRAFT',
owner: {_account_id: 42},
},
{
_number: 4,
status: 'ABANDONED',
owner: {_account_id: 0},
}
];
flushAsynchronousOperations();
var elementItems = Polymer.dom(element.root).querySelectorAll(
'gr-change-list-item');
assert.equal(elementItems.length, 5);
for (var i = 0; i < elementItems.length; i++) {
assert.isFalse(elementItems[i].hasAttribute('needs-review'));
}
element.showReviewedState = true;
elementItems = Polymer.dom(element.root).querySelectorAll(
'gr-change-list-item');
assert.equal(elementItems.length, 5);
assert.isFalse(elementItems[0].hasAttribute('needs-review'));
assert.isTrue(elementItems[1].hasAttribute('needs-review'));
assert.isFalse(elementItems[2].hasAttribute('needs-review'));
assert.isTrue(elementItems[3].hasAttribute('needs-review'));
assert.isFalse(elementItems[4].hasAttribute('needs-review'));
element.account = {_account_id: 42};
elementItems = Polymer.dom(element.root).querySelectorAll(
'gr-change-list-item');
assert.equal(elementItems.length, 5);
assert.isFalse(elementItems[0].hasAttribute('needs-review'));
assert.isTrue(elementItems[1].hasAttribute('needs-review'));
assert.isFalse(elementItems[2].hasAttribute('needs-review'));
assert.isFalse(elementItems[3].hasAttribute('needs-review'));
assert.isFalse(elementItems[4].hasAttribute('needs-review'));
});
test('no changes', function() {
element.changes = [];
flushAsynchronousOperations();
var listItems = Polymer.dom(element.root).querySelectorAll(
'gr-change-list-item');
assert.equal(listItems.length, 0);
var noChangesMsg = Polymer.dom(element.root).querySelector('.noChanges');
assert.ok(noChangesMsg);
});
test('empty groups', function() {
element.groups = [[], []];
flushAsynchronousOperations();
var listItems = Polymer.dom(element.root).querySelectorAll(
'gr-change-list-item');
assert.equal(listItems.length, 0);
var noChangesMsg = Polymer.dom(element.root).querySelectorAll(
'.noChanges');
assert.equal(noChangesMsg.length, 2);
});
});
suite('gr-change-list groups', function() {
var element;
setup(function() {
element = fixture('basic');
});
test('keyboard shortcuts', function() {
element.selectedIndex = 0;
element.groups = [
[
{_number: 0},
{_number: 1},
{_number: 2},
],
[
{_number: 3},
{_number: 4},
{_number: 5},
],
[
{_number: 6},
{_number: 7},
{_number: 8},
]
];
element.groupTitles = ['Group 1', 'Group 2', 'Group 3'];
flushAsynchronousOperations();
var elementItems = Polymer.dom(element.root).querySelectorAll(
'gr-change-list-item');
assert.equal(elementItems.length, 9);
MockInteractions.pressAndReleaseKeyOn(element, 74); // 'j'
assert.equal(element.selectedIndex, 1);
MockInteractions.pressAndReleaseKeyOn(element, 74); // 'j'
var showStub = sinon.stub(page, 'show');
assert.equal(element.selectedIndex, 2);
MockInteractions.pressAndReleaseKeyOn(element, 13); // 'enter'
assert(showStub.lastCall.calledWithExactly('/c/2/'),
'Should navigate to /c/2/');
MockInteractions.pressAndReleaseKeyOn(element, 75); // 'k'
assert.equal(element.selectedIndex, 1);
MockInteractions.pressAndReleaseKeyOn(element, 13); // 'enter'
assert(showStub.lastCall.calledWithExactly('/c/1/'),
'Should navigate to /c/1/');
MockInteractions.pressAndReleaseKeyOn(element, 74); // 'j'
MockInteractions.pressAndReleaseKeyOn(element, 74); // 'j'
MockInteractions.pressAndReleaseKeyOn(element, 74); // 'j'
assert.equal(element.selectedIndex, 4);
MockInteractions.pressAndReleaseKeyOn(element, 13); // 'enter'
assert(showStub.lastCall.calledWithExactly('/c/4/'),
'Should navigate to /c/4/');
showStub.restore();
});
});
</script>
View Git Blame Copy Permalink