
Previously reviewers did not get collapsed when toggling automated messages. This is because the backend doesn't actually consider these to be messages and can't currently get tagged. Since we always consider this type of message to be automated, the frontend handles this and now hides reviewer additions as well. Bug: Issue 4933 Change-Id: I348fd491304313f6c4fe44d461c7bc3ebf0a67ca
142 lines
4.1 KiB
HTML
142 lines
4.1 KiB
HTML
<!DOCTYPE html>
|
|
<!--
|
|
Copyright (C) 2016 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
|
<title>gr-message</title>
|
|
|
|
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
|
|
<script src="../../../bower_components/web-component-tester/browser.js"></script>
|
|
|
|
<link rel="import" href="../../../bower_components/iron-test-helpers/iron-test-helpers.html">
|
|
<link rel="import" href="gr-message.html">
|
|
|
|
<test-fixture id="basic">
|
|
<template>
|
|
<gr-message></gr-message>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<script>
|
|
suite('gr-message tests', function() {
|
|
var element;
|
|
|
|
setup(function() {
|
|
stub('gr-rest-api-interface', {
|
|
getLoggedIn: function() { return Promise.resolve(false); },
|
|
});
|
|
element = fixture('basic');
|
|
});
|
|
|
|
test('reply event', function(done) {
|
|
element.message = {
|
|
'id': '47c43261_55aa2c41',
|
|
'author': {
|
|
'_account_id': 1115495,
|
|
'name': 'Andrew Bonventre',
|
|
'email': 'andybons@chromium.org',
|
|
},
|
|
'date': '2016-01-12 20:24:49.448000000',
|
|
'message': 'Uploaded patch set 1.',
|
|
'_revision_number': 1
|
|
};
|
|
|
|
element.addEventListener('reply', function(e) {
|
|
assert.deepEqual(e.detail.message, element.message);
|
|
done();
|
|
});
|
|
flushAsynchronousOperations();
|
|
MockInteractions.tap(element.$$('.replyContainer gr-button'));
|
|
});
|
|
|
|
test('reviewer update', function() {
|
|
var updatedBy = {
|
|
_account_id: 1115495,
|
|
name: 'Andrew Bonventre',
|
|
email: 'andybons@chromium.org',
|
|
};
|
|
var reviewer = {
|
|
_account_id: 123456,
|
|
name: 'Foo Bar',
|
|
email: 'barbar@chromium.org',
|
|
};
|
|
element.message = {
|
|
updated_by: updatedBy,
|
|
reviewer: reviewer,
|
|
state: 'CC',
|
|
updated: '2016-01-12 20:24:49.448000000',
|
|
};
|
|
flushAsynchronousOperations();
|
|
var content = element.$$('.contentContainer');
|
|
assert.isOk(content);
|
|
assert.strictEqual(
|
|
content.querySelector('gr-account-chip').account, reviewer);
|
|
assert.equal(0, content.textContent.trim().indexOf(updatedBy.name));
|
|
});
|
|
|
|
test('autogenerated prefix hiding', function() {
|
|
element.message = {
|
|
tag: 'autogenerated:gerrit:test',
|
|
updated: '2016-01-12 20:24:49.448000000',
|
|
};
|
|
|
|
assert.isTrue(element.isAutomated);
|
|
assert.isFalse(element.hidden);
|
|
|
|
element.hideAutomated = true;
|
|
|
|
assert.isTrue(element.hidden);
|
|
});
|
|
|
|
test('reviewer message treated as autogenerated', function() {
|
|
element.message = {
|
|
tag: 'autogenerated:gerrit:test',
|
|
updated: '2016-01-12 20:24:49.448000000',
|
|
reviewer: {},
|
|
};
|
|
|
|
assert.isTrue(element.isAutomated);
|
|
assert.isFalse(element.hidden);
|
|
|
|
element.hideAutomated = true;
|
|
|
|
assert.isTrue(element.hidden);
|
|
});
|
|
|
|
test('tag that is not autogenerated prefix does not hide', function() {
|
|
element.message = {
|
|
tag: 'something',
|
|
updated: '2016-01-12 20:24:49.448000000',
|
|
};
|
|
|
|
assert.isFalse(element.isAutomated);
|
|
assert.isFalse(element.hidden);
|
|
|
|
element.hideAutomated = true;
|
|
|
|
assert.isFalse(element.hidden);
|
|
});
|
|
|
|
test('reply button hidden unless logged in', function() {
|
|
var message = {
|
|
'message': 'Uploaded patch set 1.',
|
|
};
|
|
assert.isFalse(element._computeShowReplyButton(message, false));
|
|
assert.isTrue(element._computeShowReplyButton(message, true));
|
|
});
|
|
});
|
|
</script>
|