There was a CSS issue with the remove reviewer button that caused the x
to appear lower than the rest of the text.
A bit of background:
- The x is actually a multiplication sign, which is smaller than a
normal letter (but more of a square shape) in the default font.
- When the font-size, height, and line height attributes are removed
from the remove button in gr-account-chip, everyting lines up as
expected but the x is small.
- There was an attempt to make the x bigger but increasing the font-size
and then decreasing the height and line height.
- This didn't result in a centered X.
The solution:
- Removed the border around the button which caused some extra height/
shifting down
- Manually adding negative vertical margin to visually tweek since the
only other explanation for the imbalance is the line box. It seems to
be slightly different for no apparent reason in the Reply dialog. This
seems to be the best compromise for now, though not perfect, as
alignment for different names appears differently.
Bug: Issue 5187
Change-Id: I56eea5f9bf845b106adedc5f05da46f7a5bc0cd1
f8f88ade27