History

Becky Siegel 2c602323e1 Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

2017-02-09 16:07:32 -08:00

app

Move reply buttons to comment thread

2017-02-09 16:07:32 -08:00

.gitattributes

Add the skeleton of a new UI based on Polymer, PolyGerrit

2015-11-09 22:01:28 +00:00

.gitignore

Serve fonts from Gerrit instead of Google Fonts.

2016-04-01 13:11:02 -04:00

BUILD

Bazel: Reformat build files

2016-12-07 11:33:07 +00:00

README.md

Fix polygerrit.war path when building PolyGerrit with Bazel

2017-01-23 14:38:00 -08:00

run-server.sh

Use test_components when running run-server.sh

2017-01-24 14:00:42 -08:00

server.go

Add CLI flag to run-server.go for local plugins

2017-02-09 09:09:27 -08:00

wct.conf.js

Add the skeleton of a new UI based on Polymer, PolyGerrit

2015-11-09 22:01:28 +00:00

README.md

PolyGerrit

Installing Node.js

# Debian/Ubuntu
sudo apt-get install nodejs-legacy

# OS X with Homebrew
brew install node

All other platforms: download from nodejs.org.

Installing Bazel

Follow the instructions here to get and install Bazel.

Local UI, Production Data

This is a quick and easy way to test your local changes against real data. Unfortunately, you can't sign in, so testing certain features will require you to use the "test data" technique described below.

Installing go

This is required for running the run-server.sh script below.

# Debian/Ubuntu
sudo apt-get install golang

# OS X with Homebrew
brew install go

All other platforms: download from golang.org

Then add go to your path:

PATH=$PATH:/usr/local/go/bin

Running the server

To test the local UI against gerrit-review.googlesource.com:

./run-server.sh

Then visit http://localhost:8081

Local UI, Test Data

One-time setup:

Build Gerrit
Set up a local test site. Docs here and here.

When your project is set up and works using the classic UI, run a test server that serves PolyGerrit:

bazel build polygerrit && \
java -jar bazel-bin/polygerrit.war daemon --polygerrit-dev \
-d ../gerrit_testsite --console-log --show-stack-trace

Running Tests

One-time setup:

# Debian/Ubuntu
sudo apt-get install npm

# OS X with Homebrew
brew install npm

# All platforms (including those above)
sudo npm install -g web-component-tester

Run all web tests:

./polygerrit-ui/app/run_test.sh

If you need to pass additional arguments to wct:

WCT_ARGS='-p --some-flag="foo bar"' ./polygerrit-ui/app/run_test.sh

For interactively working on a single test file, do the following:

./polygerrit-ui/run-server.sh

Then visit http://localhost:8081/elements/foo/bar_test.html

Style guide

We follow the Google JavaScript Style Guide with a few exceptions. When in doubt, remain consistent with the code around you.