Files
gerrit/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js
Sean Egan 3278d7b611 PolyGerrit: Add "Mark as Reviewed" keyboard shortcut for change list
Changes that become marked as unreviewed can only be marked as reviewed
in the dashboard by clicking into the review, selecting the vertical
dropdown, and finally clicking "Mark reviewed".

For users with busy dashboards who would like to quickly mark changes
as reviewed, it becomes quite cumbersome to have to navigate into every
review they want to mark as reviewed. To improve their user experience,
they should be able to mark reviews quickly and easily from the changes
list in the dashboard without having to click into each individual
review.

Reviewers may come across reviews that they want to quickly mark as
read in various situations. One example is when the code owner rebases
with no new code changes, resulting in the review to be bolded on the
dashboard but unable to be quickly dismissed. Other situations are
discussed in the issue comments.

Feature: Issue 2390
Change-Id: I86664055f3315fb497e887c6702c24f483b5dff6
2018-07-24 18:58:31 -04:00

211 lines
5.7 KiB
JavaScript

/**
* @license
* Copyright (C) 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
(function() {
'use strict';
const CHANGE_SIZE = {
XS: 10,
SMALL: 50,
MEDIUM: 250,
LARGE: 1000,
};
Polymer({
is: 'gr-change-list-item',
properties: {
visibleChangeTableColumns: Array,
labelNames: {
type: Array,
},
/** @type {?} */
change: Object,
changeURL: {
type: String,
computed: '_computeChangeURL(change)',
},
needsReview: {
type: Boolean,
reflectToAttribute: true,
computed: '_computeItemNeedsReview(change.reviewed)',
},
statuses: {
type: Array,
computed: 'changeStatuses(change)',
},
showStar: {
type: Boolean,
value: false,
},
showNumber: Boolean,
_changeSize: {
type: String,
computed: '_computeChangeSize(change)',
},
},
behaviors: [
Gerrit.BaseUrlBehavior,
Gerrit.ChangeTableBehavior,
Gerrit.PathListBehavior,
Gerrit.RESTClientBehavior,
Gerrit.URLEncodingBehavior,
],
_computeItemNeedsReview(reviewed) {
return !reviewed;
},
_computeChangeURL(change) {
return Gerrit.Nav.getUrlForChange(change);
},
_computeLabelTitle(change, labelName) {
const label = change.labels[labelName];
if (!label) { return 'Label not applicable'; }
const significantLabel = label.rejected || label.approved ||
label.disliked || label.recommended;
if (significantLabel && significantLabel.name) {
return labelName + '\nby ' + significantLabel.name;
}
return labelName;
},
_computeLabelClass(change, labelName) {
const label = change.labels[labelName];
// Mimic a Set.
const classes = {
cell: true,
label: true,
};
if (label) {
if (label.approved) {
classes['u-green'] = true;
}
if (label.value == 1) {
classes['u-monospace'] = true;
classes['u-green'] = true;
} else if (label.value == -1) {
classes['u-monospace'] = true;
classes['u-red'] = true;
}
if (label.rejected) {
classes['u-red'] = true;
}
} else {
classes['u-gray-background'] = true;
}
return Object.keys(classes).sort().join(' ');
},
_computeLabelValue(change, labelName) {
const label = change.labels[labelName];
if (!label) { return ''; }
if (label.approved) {
return '✓';
}
if (label.rejected) {
return '✕';
}
if (label.value > 0) {
return '+' + label.value;
}
if (label.value < 0) {
return label.value;
}
return '';
},
_computeProjectURL(change) {
return Gerrit.Nav.getUrlForProjectChanges(change.project, true,
change.internalHost);
},
_computeProjectBranchURL(change) {
return Gerrit.Nav.getUrlForBranch(change.branch, change.project, null,
change.internalHost);
},
_computeTopicURL(change) {
if (!change.topic) { return ''; }
return Gerrit.Nav.getUrlForTopic(change.topic, change.internalHost);
},
/**
* Computes the display string for the project column. If there is a host
* specified in the change detail, the string will be prefixed with it.
*
* @param {!Object} change
* @param {string=} truncate whether or not the project name should be
* truncated. If this value is truthy, the name will be truncated.
* @return {string}
*/
_computeProjectDisplay(change, truncate) {
if (!change || !change.project) { return ''; }
let str = '';
if (change.internalHost) { str += change.internalHost + '/'; }
str += truncate ? this.truncatePath(change.project, 2) : change.project;
return str;
},
_computeAccountStatusString(account) {
return account && account.status ? `(${account.status})` : '';
},
_computeSizeTooltip(change) {
if (change.insertions + change.deletions === 0 ||
isNaN(change.insertions + change.deletions)) {
return 'Size unknown';
} else {
return `+${change.insertions}, -${change.deletions}`;
}
},
/**
* TShirt sizing is based on the following paper:
* http://dirkriehle.com/wp-content/uploads/2008/09/hicss-42-csdistr-final-web.pdf
*/
_computeChangeSize(change) {
const delta = change.insertions + change.deletions;
if (isNaN(delta) || delta === 0) {
return null; // Unknown
}
if (delta < CHANGE_SIZE.XS) {
return 'XS';
} else if (delta < CHANGE_SIZE.SMALL) {
return 'S';
} else if (delta < CHANGE_SIZE.MEDIUM) {
return 'M';
} else if (delta < CHANGE_SIZE.LARGE) {
return 'L';
} else {
return 'XL';
}
},
toggleReviewed() {
const newVal = !this.change.reviewed;
this.set('change.reviewed', newVal);
this.dispatchEvent(new CustomEvent('toggle-reviewed', {
bubbles: true,
detail: {change: this.change, reviewed: newVal},
}));
},
});
})();