3278d7b611
Changes that become marked as unreviewed can only be marked as reviewed in the dashboard by clicking into the review, selecting the vertical dropdown, and finally clicking "Mark reviewed". For users with busy dashboards who would like to quickly mark changes as reviewed, it becomes quite cumbersome to have to navigate into every review they want to mark as reviewed. To improve their user experience, they should be able to mark reviews quickly and easily from the changes list in the dashboard without having to click into each individual review. Reviewers may come across reviews that they want to quickly mark as read in various situations. One example is when the code owner rebases with no new code changes, resulting in the review to be bolded on the dashboard but unable to be quickly dismissed. Other situations are discussed in the issue comments. Feature: Issue 2390 Change-Id: I86664055f3315fb497e887c6702c24f483b5dff6
110 lines
3.8 KiB
HTML
110 lines
3.8 KiB
HTML
<!--
|
|
@license
|
|
Copyright (C) 2015 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<link rel="import" href="../../../behaviors/base-url-behavior/base-url-behavior.html">
|
|
<link rel="import" href="../../../behaviors/gr-url-encoding-behavior.html">
|
|
<link rel="import" href="../../../bower_components/polymer/polymer.html">
|
|
<link rel="import" href="../../core/gr-navigation/gr-navigation.html">
|
|
<link rel="import" href="../../shared/gr-icons/gr-icons.html">
|
|
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
|
|
<link rel="import" href="../gr-change-list/gr-change-list.html">
|
|
<link rel="import" href="../gr-repo-header/gr-repo-header.html">
|
|
<link rel="import" href="../gr-user-header/gr-user-header.html">
|
|
<link rel="import" href="../../../styles/shared-styles.html">
|
|
|
|
<dom-module id="gr-change-list-view">
|
|
<template>
|
|
<style include="shared-styles">
|
|
:host {
|
|
background-color: var(--view-background-color);
|
|
display: block;
|
|
}
|
|
.loading {
|
|
color: var(--deemphasized-text-color);
|
|
padding: 1em var(--default-horizontal-margin);
|
|
}
|
|
gr-change-list {
|
|
width: 100%;
|
|
}
|
|
gr-user-header,
|
|
gr-repo-header {
|
|
border-bottom: 1px solid var(--border-color);
|
|
}
|
|
nav {
|
|
align-items: center;
|
|
background-color: var(--view-background-color);;
|
|
display: flex;
|
|
height: 3rem;
|
|
justify-content: flex-end;
|
|
margin-right: 20px;
|
|
}
|
|
nav,
|
|
iron-icon {
|
|
color: var(--deemphasized-text-color);
|
|
}
|
|
iron-icon {
|
|
height: 1.85rem;
|
|
margin-left: 16px;
|
|
width: 1.85rem;
|
|
}
|
|
.hide {
|
|
display: none;
|
|
}
|
|
@media only screen and (max-width: 50em) {
|
|
.loading,
|
|
.error {
|
|
padding: 0 var(--default-horizontal-margin);
|
|
}
|
|
}
|
|
</style>
|
|
<div class="loading" hidden$="[[!_loading]]" hidden>Loading...</div>
|
|
<div hidden$="[[_loading]]" hidden>
|
|
<gr-repo-header
|
|
repo="[[_repo]]"
|
|
class$="[[_computeHeaderClass(_repo)]]"></gr-repo-header>
|
|
<gr-user-header
|
|
user-id="[[_userId]]"
|
|
show-dashboard-link
|
|
logged-in="[[_loggedIn]]"
|
|
class$="[[_computeHeaderClass(_userId)]]"></gr-user-header>
|
|
<gr-change-list
|
|
account="[[account]]"
|
|
changes="{{_changes}}"
|
|
preferences="[[preferences]]"
|
|
selected-index="{{viewState.selectedChangeIndex}}"
|
|
show-star="[[_loggedIn]]"
|
|
on-toggle-star="_handleToggleStar"
|
|
on-toggle-reviewed="_handleToggleReviewed"></gr-change-list>
|
|
<nav class$="[[_computeNavClass(_loading)]]">
|
|
Page [[_computePage(_offset, _changesPerPage)]]
|
|
<a id="prevArrow"
|
|
href$="[[_computeNavLink(_query, _offset, -1, _changesPerPage)]]"
|
|
class$="[[_computePrevArrowClass(_offset)]]">
|
|
<iron-icon icon="gr-icons:chevron-left"></iron-icon>
|
|
</a>
|
|
<a id="nextArrow"
|
|
href$="[[_computeNavLink(_query, _offset, 1, _changesPerPage)]]"
|
|
class$="[[_computeNextArrowClass(_changes)]]">
|
|
<iron-icon icon="gr-icons:chevron-right"></iron-icon>
|
|
</a>
|
|
</nav>
|
|
</div>
|
|
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
|
|
</template>
|
|
<script src="gr-change-list-view.js"></script>
|
|
</dom-module>
|