Files
gerrit/polygerrit-ui/app/elements/gr-change-actions.html
Andrew Bonventre 882043f905 Move reply from dropdown to dialog
This makes things more friendly on mobile and doesn’t have
any significant usability difference.
Also size the resize dialog to fit within the screen on mobile.

Bug: Issue 3908
Bug: Issue 3866
Change-Id: I0aac13d47407a5f5b0d53a6efd2602d5c2b7c10c
2016-02-23 15:30:32 +00:00

296 lines
9.2 KiB
HTML
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

<!--
Copyright (C) 2016 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<link rel="import" href="../bower_components/polymer/polymer.html">
<link rel="import" href="../bower_components/iron-input/iron-input.html">
<link rel="import" href="../behaviors/rest-client-behavior.html">
<link rel="import" href="gr-ajax.html">
<link rel="import" href="gr-button.html">
<link rel="import" href="gr-confirm-rebase-dialog.html">
<link rel="import" href="gr-overlay.html">
<link rel="import" href="gr-request.html">
<dom-module id="gr-change-actions">
<template>
<style>
:host {
display: block;
}
gr-button {
display: block;
margin-bottom: .5em;
}
gr-button:before {
content: attr(data-label);
}
gr-button[loading]:before {
content: attr(data-loading-label);
}
@media screen and (max-width: 60em) {
.confirmDialog {
width: 90vw;
}
}
</style>
<gr-ajax id="actionsXHR"
url="[[_computeRevisionActionsPath(changeNum, patchNum)]]"
last-response="{{_revisionActions}}"
loading="{{_loading}}"></gr-ajax>
<div>
<template is="dom-repeat" items="[[_computeActionValues(actions, 'change')]]" as="action">
<gr-button title$="[[action.title]]"
primary$="[[_computePrimary(action.__key)]]"
hidden$="[[!action.enabled]]"
data-action-key$="[[action.__key]]"
data-action-type$="[[action.__type]]"
data-label$="[[action.label]]"
on-tap="_handleActionTap"></gr-button>
</template>
<template is="dom-repeat" items="[[_computeActionValues(_revisionActions, 'revision')]]" as="action">
<gr-button title$="[[action.title]]"
primary$="[[_computePrimary(action.__key)]]"
disabled$="[[!action.enabled]]"
data-action-key$="[[action.__key]]"
data-action-type$="[[action.__type]]"
data-label$="[[action.label]]"
data-loading-label$="[[_computeLoadingLabel(action.__key)]]"
on-tap="_handleActionTap"></gr-button>
</template>
</div>
<gr-overlay id="overlay" with-backdrop>
<gr-confirm-rebase-dialog id="confirmRebase"
class="confirmDialog"
on-confirm="_handleRebaseConfirm"
on-cancel="_handleConfirmDialogCancel"
hidden></gr-confirm-rebase-dialog>
</gr-overlay>
</template>
<script>
(function() {
'use strict';
// TODO(davido): Add the rest of the change actions.
var ChangeActions = {
ABANDON: 'abandon',
DELETE: '/',
RESTORE: 'restore',
};
// TODO(andybons): Add the rest of the revision actions.
var RevisionActions = {
DELETE: '/',
PUBLISH: 'publish',
REBASE: 'rebase',
SUBMIT: 'submit',
};
Polymer({
is: 'gr-change-actions',
/**
* Fired when the change should be reloaded.
*
* @event reload-change
*/
properties: {
actions: {
type: Object,
},
changeNum: String,
patchNum: String,
_loading: {
type: Boolean,
value: true,
},
_revisionActions: Object,
},
behaviors: [
Gerrit.RESTClientBehavior,
],
observers: [
'_actionsChanged(actions, _revisionActions)',
],
reload: function() {
if (!this.changeNum || !this.patchNum) {
return Promise.resolve();
}
return this.$.actionsXHR.generateRequest().completes;
},
_actionsChanged: function(actions, revisionActions) {
this.hidden =
revisionActions.rebase == null &&
revisionActions.submit == null &&
revisionActions.publish == null &&
actions.abandon == null &&
actions.restore == null;
},
_computeRevisionActionsPath: function(changeNum, patchNum) {
return this.changeBaseURL(changeNum, patchNum) + '/actions';
},
_getValuesFor: function(obj) {
return Object.keys(obj).map(function(key) {
return obj[key];
});
},
_computeActionValues: function(actions, type) {
var result = [];
var values = this._getValuesFor(
type == 'change' ? ChangeActions : RevisionActions);
for (var a in actions) {
if (values.indexOf(a) == -1) { continue; }
actions[a].__key = a;
actions[a].__type = type;
result.push(actions[a]);
}
return result;
},
_computeLoadingLabel: function(action) {
return {
'rebase': 'Rebasing...',
'submit': 'Submitting...',
}[action];
},
_computePrimary: function(actionKey) {
return actionKey == 'submit';
},
_computeButtonClass: function(action) {
if ([RevisionActions.SUBMIT,
RevisionActions.PUBLISH].indexOf(action) != -1) {
return 'primary';
}
return '';
},
_handleActionTap: function(e) {
e.preventDefault();
var el = Polymer.dom(e).rootTarget;
var key = el.getAttribute('data-action-key');
var type = el.getAttribute('data-action-type');
if (type == 'revision') {
if (key == RevisionActions.REBASE) {
this._showRebaseDialog();
return;
}
this._fireRevisionAction(this._prependSlash(key),
this._revisionActions[key]);
} else {
this._fireChangeAction(this._prependSlash(key), this.actions[key]);
}
},
_prependSlash: function(key) {
return key == '/' ? key : '/' + key;
},
_handleConfirmDialogCancel: function() {
var dialogEls =
Polymer.dom(this.root).querySelectorAll('.confirmDialog');
for (var i = 0; i < dialogEls.length; i++) {
dialogEls[i].hidden = true;
}
this.$.overlay.close();
},
_handleRebaseConfirm: function() {
var payload = {};
var el = this.$.confirmRebase;
if (el.clearParent) {
// There is a subtle but important difference between setting the base
// to an empty string and omitting it entirely from the payload. An
// empty string implies that the parent should be cleared and the
// change should be rebased on top of the target branch. Leaving out
// the base implies that it should be rebased on top of its current
// parent.
payload.base = '';
} else if (el.base && el.base.length > 0) {
payload.base = el.base;
}
this.$.overlay.close();
el.hidden = false;
this._fireRevisionAction('/rebase', this._revisionActions.rebase,
payload);
},
_fireChangeAction: function(endpoint, action) {
this._send(action.method, {}, endpoint).then(
function() {
// We cant reload a change that was deleted.
if (endpoint == ChangeActions.DELETE) {
page.show('/');
} else {
this.fire('reload-change', null, {bubbles: false});
}
}.bind(this)).catch(function(err) {
alert('Oops. Something went wrong. Check the console and bug the ' +
'PolyGerrit team for assistance.');
throw err;
});
},
_fireRevisionAction: function(endpoint, action, opt_payload) {
var buttonEl = this.$$('[data-action-key="' + action.__key + '"]');
buttonEl.setAttribute('loading', true);
buttonEl.disabled = true;
function enableButton() {
buttonEl.removeAttribute('loading');
buttonEl.disabled = false;
}
this._send(action.method, opt_payload, endpoint, true).then(
function() {
this.fire('reload-change', null, {bubbles: false});
enableButton();
}.bind(this)).catch(function(err) {
// TODO(andybons): Handle merge conflict (409 status);
alert('Oops. Something went wrong. Check the console and bug the ' +
'PolyGerrit team for assistance.');
enableButton();
throw err;
});
},
_showRebaseDialog: function() {
this.$.confirmRebase.hidden = false;
this.$.overlay.open();
},
_send: function(method, payload, actionEndpoint, revisionAction) {
var xhr = document.createElement('gr-request');
this._xhrPromise = xhr.send({
method: method,
url: this.changeBaseURL(this.changeNum,
revisionAction ? this.patchNum : null) + actionEndpoint,
body: payload,
});
return this._xhrPromise;
},
});
})();
</script>
</dom-module>