7f412ae230
``` js
Gerrit.install(function(plugin) {
// Make cherry-pick appear first.
plugin.changeActions().setActionPriority(
'revision', 'cherrypick', -5);
// Make cherry-pick appear last
plugin.changeActions().setActionPriority(
'revision', 'cherrypick', 5);
});
```
Default priority list is:
- Reply is always first, aligned to the left
- More actions if always after it
- Quick approve (CodeReview+2) after them, with priority at -3
- Primary actions come last, with priority of 3
- Change actions before primary, with priority of 2
- Revision actions before change actions, with priority of 1
- In case of a tie, actions are sorted alphabetically
Feature: Issue 5360
Change-Id: I7f36954608f764bff4e36a4a2f916bf0dda3859d
180 lines
6.5 KiB
HTML
180 lines
6.5 KiB
HTML
<!DOCTYPE html>
|
||
<!--
|
||
Copyright (C) 2016 The Android Open Source Project
|
||
|
||
Licensed under the Apache License, Version 2.0 (the "License");
|
||
you may not use this file except in compliance with the License.
|
||
You may obtain a copy of the License at
|
||
|
||
http://www.apache.org/licenses/LICENSE-2.0
|
||
|
||
Unless required by applicable law or agreed to in writing, software
|
||
distributed under the License is distributed on an "AS IS" BASIS,
|
||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
See the License for the specific language governing permissions and
|
||
limitations under the License.
|
||
-->
|
||
|
||
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
||
<title>gr-change-actions-js-api</title>
|
||
|
||
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
|
||
<script src="../../../bower_components/web-component-tester/browser.js"></script>
|
||
|
||
<link rel="import" href="../../../bower_components/iron-test-helpers/iron-test-helpers.html">
|
||
<!--
|
||
This must refer to the element this interface is wrapping around. Otherwise
|
||
breaking changes to gr-change-actions won’t be noticed.
|
||
-->
|
||
<link rel="import" href="../../change/gr-change-actions/gr-change-actions.html">
|
||
|
||
<script>void(0);</script>
|
||
|
||
<test-fixture id="basic">
|
||
<template>
|
||
<gr-change-actions></gr-change-actions>
|
||
</template>
|
||
</test-fixture>
|
||
|
||
<script>
|
||
suite('gr-js-api-interface tests', function() {
|
||
var element;
|
||
var changeActions;
|
||
|
||
// Because deepEqual doesn’t behave in Safari.
|
||
function assertArraysEqual(actual, expected) {
|
||
assert.equal(actual.length, expected.length);
|
||
for (var i = 0; i < actual.length; i++) {
|
||
assert.equal(actual[i], expected[i]);
|
||
}
|
||
}
|
||
|
||
setup(function() {
|
||
element = fixture('basic');
|
||
element.change = {};
|
||
element._hasKnownChainState = false;
|
||
var plugin;
|
||
Gerrit.install(function(p) { plugin = p; }, '0.1',
|
||
'http://test.com/plugins/testplugin/static/test.js');
|
||
changeActions = plugin.changeActions();
|
||
});
|
||
|
||
teardown(function() {
|
||
changeActions = null;
|
||
});
|
||
|
||
test('property existence', function() {
|
||
[
|
||
'ActionType',
|
||
'ChangeActions',
|
||
'RevisionActions',
|
||
].forEach(function(p) {
|
||
assertArraysEqual(changeActions[p], element[p]);
|
||
});
|
||
});
|
||
|
||
test('add/remove primary action keys', function() {
|
||
element.primaryActionKeys = [];
|
||
changeActions.addPrimaryActionKey('foo');
|
||
assertArraysEqual(element.primaryActionKeys, ['foo']);
|
||
changeActions.addPrimaryActionKey('foo');
|
||
assertArraysEqual(element.primaryActionKeys, ['foo']);
|
||
changeActions.addPrimaryActionKey('bar');
|
||
assertArraysEqual(element.primaryActionKeys, ['foo', 'bar']);
|
||
changeActions.removePrimaryActionKey('foo');
|
||
assertArraysEqual(element.primaryActionKeys, ['bar']);
|
||
changeActions.removePrimaryActionKey('baz');
|
||
assertArraysEqual(element.primaryActionKeys, ['bar']);
|
||
changeActions.removePrimaryActionKey('bar');
|
||
assertArraysEqual(element.primaryActionKeys, []);
|
||
});
|
||
|
||
test('action buttons', function(done) {
|
||
var key = changeActions.add(changeActions.ActionType.REVISION, 'Bork!');
|
||
var handler = sinon.spy();
|
||
changeActions.addTapListener(key, handler);
|
||
flush(function() {
|
||
MockInteractions.tap(element.$$('[data-action-key="' + key + '"]'));
|
||
assert(handler.calledOnce);
|
||
changeActions.removeTapListener(key, handler);
|
||
MockInteractions.tap(element.$$('[data-action-key="' + key + '"]'));
|
||
assert(handler.calledOnce);
|
||
changeActions.remove(key);
|
||
flush(function() {
|
||
assert.isNull(element.$$('[data-action-key="' + key + '"]'));
|
||
done();
|
||
});
|
||
});
|
||
});
|
||
|
||
test('action button properties', function(done) {
|
||
var key = changeActions.add(changeActions.ActionType.REVISION, 'Bork!');
|
||
flush(function() {
|
||
var button = element.$$('[data-action-key="' + key + '"]');
|
||
assert.isOk(button);
|
||
assert.equal(button.getAttribute('data-label'), 'Bork!');
|
||
assert.isNotOk(button.disabled);
|
||
changeActions.setLabel(key, 'Yo');
|
||
changeActions.setEnabled(key, false);
|
||
flush(function() {
|
||
assert.equal(button.getAttribute('data-label'), 'Yo');
|
||
assert.isTrue(button.disabled);
|
||
done();
|
||
});
|
||
});
|
||
});
|
||
|
||
test('hide action buttons', function(done) {
|
||
var key = changeActions.add(changeActions.ActionType.REVISION, 'Bork!');
|
||
flush(function() {
|
||
var button = element.$$('[data-action-key="' + key + '"]');
|
||
assert.isOk(button);
|
||
assert.isFalse(button.hasAttribute('hidden'));
|
||
changeActions.setActionHidden(
|
||
changeActions.ActionType.REVISION, key, true);
|
||
flush(function() {
|
||
var button = element.$$('[data-action-key="' + key + '"]');
|
||
assert.isNotOk(button);
|
||
done();
|
||
});
|
||
});
|
||
});
|
||
|
||
test('move action button to overflow', function(done) {
|
||
var key = changeActions.add(changeActions.ActionType.REVISION, 'Bork!');
|
||
flush(function() {
|
||
assert.isTrue(element.$.moreActions.hidden);
|
||
assert.isOk(element.$$('[data-action-key="' + key + '"]'));
|
||
changeActions.setActionOverflow(
|
||
changeActions.ActionType.REVISION, key, true);
|
||
flush(function() {
|
||
assert.isNotOk(element.$$('[data-action-key="' + key + '"]'));
|
||
assert.isFalse(element.$.moreActions.hidden);
|
||
assert.strictEqual(element.$.moreActions.items[0].name, 'Bork!');
|
||
done();
|
||
});
|
||
});
|
||
});
|
||
|
||
test('change actions priority', function(done) {
|
||
var key1 = changeActions.add(changeActions.ActionType.REVISION, 'Bork!');
|
||
var key2 = changeActions.add(changeActions.ActionType.CHANGE, 'Squanch?');
|
||
flush(function() {
|
||
var buttons =
|
||
Polymer.dom(element.root).querySelectorAll('[data-action-key]');
|
||
assert.equal(buttons[0].getAttribute('data-action-key'), key1);
|
||
assert.equal(buttons[1].getAttribute('data-action-key'), key2);
|
||
changeActions.setActionPriority(
|
||
changeActions.ActionType.REVISION, key1, 10);
|
||
flush(function() {
|
||
buttons =
|
||
Polymer.dom(element.root).querySelectorAll('[data-action-key]');
|
||
assert.equal(buttons[0].getAttribute('data-action-key'), key2);
|
||
assert.equal(buttons[1].getAttribute('data-action-key'), key1);
|
||
done();
|
||
});
|
||
});
|
||
});
|
||
});
|
||
</script>
|