Checking permissions of users that aren't the caller on the current request can have implications on the security of the system. The most prominent one is creating a group-oracle. To limit the cases where we could potentially expose Gerrit to these threats, PermissionBackend removes the method that was operating solely on the provider of the current user. Change-Id: I601ea1200a15a5f262ca0770b23cc1c7bee126b1
160 lines
5.8 KiB
Java
160 lines
5.8 KiB
Java
// Copyright (C) 2012 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package com.google.gerrit.server.restapi.change;
|
|
|
|
import com.google.gerrit.extensions.registration.DynamicMap;
|
|
import com.google.gerrit.extensions.restapi.AcceptsPost;
|
|
import com.google.gerrit.extensions.restapi.AuthException;
|
|
import com.google.gerrit.extensions.restapi.IdString;
|
|
import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
|
|
import com.google.gerrit.extensions.restapi.RestApiException;
|
|
import com.google.gerrit.extensions.restapi.RestCollection;
|
|
import com.google.gerrit.extensions.restapi.RestView;
|
|
import com.google.gerrit.extensions.restapi.TopLevelResource;
|
|
import com.google.gerrit.reviewdb.client.Change;
|
|
import com.google.gerrit.reviewdb.client.Project;
|
|
import com.google.gerrit.reviewdb.server.ReviewDb;
|
|
import com.google.gerrit.server.ChangeFinder;
|
|
import com.google.gerrit.server.CurrentUser;
|
|
import com.google.gerrit.server.change.ChangeResource;
|
|
import com.google.gerrit.server.notedb.ChangeNotes;
|
|
import com.google.gerrit.server.permissions.ChangePermission;
|
|
import com.google.gerrit.server.permissions.PermissionBackend;
|
|
import com.google.gerrit.server.permissions.PermissionBackendException;
|
|
import com.google.gerrit.server.project.ProjectCache;
|
|
import com.google.gerrit.server.project.ProjectState;
|
|
import com.google.gwtorm.server.OrmException;
|
|
import com.google.inject.Inject;
|
|
import com.google.inject.Provider;
|
|
import com.google.inject.Singleton;
|
|
import java.io.IOException;
|
|
import java.util.List;
|
|
|
|
@Singleton
|
|
public class ChangesCollection
|
|
implements RestCollection<TopLevelResource, ChangeResource>, AcceptsPost<TopLevelResource> {
|
|
private final Provider<ReviewDb> db;
|
|
private final Provider<CurrentUser> user;
|
|
private final Provider<QueryChanges> queryFactory;
|
|
private final DynamicMap<RestView<ChangeResource>> views;
|
|
private final ChangeFinder changeFinder;
|
|
private final CreateChange createChange;
|
|
private final ChangeResource.Factory changeResourceFactory;
|
|
private final PermissionBackend permissionBackend;
|
|
private final ProjectCache projectCache;
|
|
|
|
@Inject
|
|
ChangesCollection(
|
|
Provider<ReviewDb> db,
|
|
Provider<CurrentUser> user,
|
|
Provider<QueryChanges> queryFactory,
|
|
DynamicMap<RestView<ChangeResource>> views,
|
|
ChangeFinder changeFinder,
|
|
CreateChange createChange,
|
|
ChangeResource.Factory changeResourceFactory,
|
|
PermissionBackend permissionBackend,
|
|
ProjectCache projectCache) {
|
|
this.db = db;
|
|
this.user = user;
|
|
this.queryFactory = queryFactory;
|
|
this.views = views;
|
|
this.changeFinder = changeFinder;
|
|
this.createChange = createChange;
|
|
this.changeResourceFactory = changeResourceFactory;
|
|
this.permissionBackend = permissionBackend;
|
|
this.projectCache = projectCache;
|
|
}
|
|
|
|
@Override
|
|
public QueryChanges list() {
|
|
return queryFactory.get();
|
|
}
|
|
|
|
@Override
|
|
public DynamicMap<RestView<ChangeResource>> views() {
|
|
return views;
|
|
}
|
|
|
|
@Override
|
|
public ChangeResource parse(TopLevelResource root, IdString id)
|
|
throws RestApiException, OrmException, PermissionBackendException, IOException {
|
|
List<ChangeNotes> notes = changeFinder.find(id.encoded(), true);
|
|
if (notes.isEmpty()) {
|
|
throw new ResourceNotFoundException(id);
|
|
} else if (notes.size() != 1) {
|
|
throw new ResourceNotFoundException("Multiple changes found for " + id);
|
|
}
|
|
|
|
ChangeNotes change = notes.get(0);
|
|
if (!canRead(change)) {
|
|
throw new ResourceNotFoundException(id);
|
|
}
|
|
checkProjectStatePermitsRead(change.getProjectName());
|
|
return changeResourceFactory.create(change, user.get());
|
|
}
|
|
|
|
public ChangeResource parse(Change.Id id)
|
|
throws RestApiException, OrmException, PermissionBackendException, IOException {
|
|
List<ChangeNotes> notes = changeFinder.find(id);
|
|
if (notes.isEmpty()) {
|
|
throw new ResourceNotFoundException(toIdString(id));
|
|
} else if (notes.size() != 1) {
|
|
throw new ResourceNotFoundException("Multiple changes found for " + id);
|
|
}
|
|
|
|
ChangeNotes change = notes.get(0);
|
|
if (!canRead(change)) {
|
|
throw new ResourceNotFoundException(toIdString(id));
|
|
}
|
|
checkProjectStatePermitsRead(change.getProjectName());
|
|
return changeResourceFactory.create(change, user.get());
|
|
}
|
|
|
|
private static IdString toIdString(Change.Id id) {
|
|
return IdString.fromDecoded(id.toString());
|
|
}
|
|
|
|
public ChangeResource parse(ChangeNotes notes, CurrentUser user) {
|
|
return changeResourceFactory.create(notes, user);
|
|
}
|
|
|
|
@Override
|
|
public CreateChange post(TopLevelResource parent) throws RestApiException {
|
|
return createChange;
|
|
}
|
|
|
|
private boolean canRead(ChangeNotes notes) throws PermissionBackendException, IOException {
|
|
try {
|
|
permissionBackend.currentUser().change(notes).database(db).check(ChangePermission.READ);
|
|
} catch (AuthException e) {
|
|
return false;
|
|
}
|
|
ProjectState projectState = projectCache.checkedGet(notes.getProjectName());
|
|
if (projectState == null) {
|
|
return false;
|
|
}
|
|
return projectState.statePermitsRead();
|
|
}
|
|
|
|
private void checkProjectStatePermitsRead(Project.NameKey project)
|
|
throws IOException, RestApiException {
|
|
ProjectState projectState = projectCache.checkedGet(project);
|
|
if (projectState == null) {
|
|
throw new ResourceNotFoundException("project not found: " + project.get());
|
|
}
|
|
projectState.checkStatePermitsRead();
|
|
}
|
|
}
|