Files
gerrit/gerrit-server
Dave Borowitz 04d82e10e6 ChangeJson: Ensure limitToPsId revision is present in output
Due to a logic bug, we weren't including the limitToPsId revision in the
revisions map in the output ChangeInfo (unless it would have been
included for another reason, such as ALL_REVISIONS being requested).

In addition to a more direct test in RevisionIT, add a test to ActionsIT
ensuring that actions load on a non-current revision, which is the
codepath in the wild that led to discovering this bug.

Fixing the immediate bug unfortunately makes this code even uglier; it
cries out for a more thorough refactoring, but we need to fix this
critical bug preventing ActionVisitors from working. On the plus side,
the additional tests in this change will make that refactoring safer.

Change-Id: Iea61de55f2efc54d3955ff40f993a40e2936beb0
2017-08-29 14:17:24 -04:00
..