Change Ia1fcdb3c9b made the getUserName() method return an Optional
and callers rely on this method to never return null. However when the
setUserName method was not invoked userName was still null. This
resulted in a NullPointerException when trying to create a new account
from the "New Account" button on the login page when using
DEVELOPMENT_BECOME_ANY_ACCOUNT [1]. Fix this by initializing userName
with Optional.empty().
[1]
com.google.gerrit.pgm.http.jetty.HiddenErrorHandler : Error in POST /login
java.lang.NullPointerException
at com.google.gerrit.server.account.AccountManager.create(AccountManager.java:285)
at com.google.gerrit.server.account.AccountManager.authenticate(AccountManager.java:147)
at com.google.gerrit.httpd.auth.become.BecomeAnyAccountLoginServlet.create(BecomeAnyAccountLoginServlet.java:248)
at com.google.gerrit.httpd.auth.become.BecomeAnyAccountLoginServlet.doPost(BecomeAnyAccountLoginServlet.java:100)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:661)
...
Change-Id: Ied5d6ec93e7e5d1b1f72106e2f28d0cd1c224c08
Signed-off-by: Edwin Kempin <ekempin@google.com>
34d63bba4f