gerrit/polygerrit-ui/app/behaviors/gr-list-view-behavior
Wyatt Allen 292d013f32 Decode inheritance project IDs before use
In the JSON of emitted by the repo list endpoint, the project IDs are
URL-encoded using java.net.URLEncoder.encode. While the Java function
encodes spaces as plus-signs, the JavaScript decodeURLComponent does
not.

As a result, when editing the "inherits from" field of a project's
access settings where the parent project's ID includes spaces, the
payload would use an improperly decoded parent value, and this would be
rejected by the API for failing to identify the parent.

Add a new decoding method to the URL encoding behavior that better
matches the style of encoding used by java.net.URLEncoder. Because the
behavior had no test coverage before, it's moved to a new location and
a suite of tests are added. Add tests for the access screen properly
encoding and decoding parent IDs.

Change-Id: Icb1d28d8f1f88c3c7373aa1c8953238a61c32ace
2018-07-30 18:25:47 -07:00
..
gr-list-view-behavior_test.html Add @license tags to PG HTML and JS assets 2018-03-26 10:47:55 -04:00
gr-list-view-behavior.html Decode inheritance project IDs before use 2018-07-30 18:25:47 -07:00