14aa6ab6fc
Previously the change table editor had a section for shown columns and a separate one for hidden columns. From the shown columns section, you could 'delete' a column, and from the hidden section, you could 'add' a column. This was confusing for users, particularly when there were no hidden columns. This change keeps all columns in the section, but instead adds checkbox indicating whether or not each column should be visible. Bug: Issue 5547 Change-Id: I65d1afd4c5e3e9cbbf823ad5773db1f13ca182ef
213 lines
7.7 KiB
HTML
213 lines
7.7 KiB
HTML
<!DOCTYPE html>
|
|
<!--
|
|
Copyright (C) 2015 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
|
<title>gr-change-list-item</title>
|
|
|
|
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
|
|
<script src="../../../bower_components/web-component-tester/browser.js"></script>
|
|
<script src="../../../scripts/util.js"></script>
|
|
|
|
<link rel="import" href="../../../bower_components/iron-test-helpers/iron-test-helpers.html">
|
|
<link rel="import" href="gr-change-list-item.html">
|
|
|
|
<test-fixture id="basic">
|
|
<template>
|
|
<gr-change-list-item></gr-change-list-item>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<script>
|
|
suite('gr-change-list-item tests', function() {
|
|
var element;
|
|
|
|
setup(function() {
|
|
stub('gr-rest-api-interface', {
|
|
getConfig: function() { return Promise.resolve({}); },
|
|
getLoggedIn: function() { return Promise.resolve(false); },
|
|
});
|
|
element = fixture('basic');
|
|
});
|
|
|
|
test('change status', function() {
|
|
var getStatusForChange = function(change) {
|
|
element.change = change;
|
|
return element.$$('.cell.status').textContent.trim();
|
|
};
|
|
|
|
assert.equal(getStatusForChange({mergeable: true}), '');
|
|
assert.equal(getStatusForChange({mergeable: false}), 'Merge Conflict');
|
|
assert.equal(getStatusForChange({status: 'NEW'}), '');
|
|
assert.equal(getStatusForChange({status: 'MERGED'}), 'Merged');
|
|
assert.equal(getStatusForChange({status: 'ABANDONED'}), 'Abandoned');
|
|
assert.equal(getStatusForChange({status: 'DRAFT'}), 'Draft');
|
|
});
|
|
|
|
test('computed fields', function() {
|
|
assert.equal(element._computeLabelClass({labels: {}}),
|
|
'cell label u-gray-background');
|
|
assert.equal(element._computeLabelClass(
|
|
{labels: {}}, 'Verified'), 'cell label u-gray-background');
|
|
assert.equal(element._computeLabelClass(
|
|
{labels: {Verified: {approved: true, value: 1}}}, 'Verified'),
|
|
'cell label u-green u-monospace');
|
|
assert.equal(element._computeLabelClass(
|
|
{labels: {Verified: {rejected: true, value: -1}}}, 'Verified'),
|
|
'cell label u-monospace u-red');
|
|
assert.equal(element._computeLabelClass(
|
|
{labels: {'Code-Review': {value: 1}}}, 'Code-Review'),
|
|
'cell label u-green u-monospace');
|
|
assert.equal(element._computeLabelClass(
|
|
{labels: {'Code-Review': {value: -1}}}, 'Code-Review'),
|
|
'cell label u-monospace u-red');
|
|
assert.equal(element._computeLabelClass(
|
|
{labels: {'Code-Review': {value: -1}}}, 'Verified'),
|
|
'cell label u-gray-background');
|
|
|
|
assert.equal(element._computeLabelTitle({labels: {}}, 'Verified'),
|
|
'Label not applicable');
|
|
assert.equal(element._computeLabelTitle(
|
|
{labels: {Verified: {approved: {name: 'Diffy'}}}}, 'Verified'),
|
|
'Verified\nby Diffy');
|
|
assert.equal(element._computeLabelTitle(
|
|
{labels: {Verified: {approved: {name: 'Diffy'}}}}, 'Code-Review'),
|
|
'Label not applicable');
|
|
assert.equal(element._computeLabelTitle(
|
|
{labels: {Verified: {rejected: {name: 'Diffy'}}}}, 'Verified'),
|
|
'Verified\nby Diffy');
|
|
assert.equal(element._computeLabelTitle(
|
|
{labels: {'Code-Review': {disliked: {name: 'Diffy'}, value: -1}}},
|
|
'Code-Review'), 'Code-Review\nby Diffy');
|
|
assert.equal(element._computeLabelTitle(
|
|
{labels: {'Code-Review': {recommended: {name: 'Diffy'}, value: 1}}},
|
|
'Code-Review'), 'Code-Review\nby Diffy');
|
|
assert.equal(element._computeLabelTitle(
|
|
{labels: {'Code-Review': {recommended: {name: 'Diffy'},
|
|
rejected: {name: 'Admin'}}}}, 'Code-Review'),
|
|
'Code-Review\nby Admin');
|
|
assert.equal(element._computeLabelTitle(
|
|
{labels: {'Code-Review': {approved: {name: 'Diffy'},
|
|
rejected: {name: 'Admin'}}}}, 'Code-Review'),
|
|
'Code-Review\nby Admin');
|
|
assert.equal(element._computeLabelTitle(
|
|
{labels: {'Code-Review': {recommended: {name: 'Diffy'},
|
|
disliked: {name: 'Admin'}, value: -1}}}, 'Code-Review'),
|
|
'Code-Review\nby Admin');
|
|
assert.equal(element._computeLabelTitle(
|
|
{labels: {'Code-Review': {approved: {name: 'Diffy'},
|
|
disliked: {name: 'Admin'}, value: -1}}}, 'Code-Review'),
|
|
'Code-Review\nby Diffy');
|
|
|
|
assert.equal(element._computeLabelValue({labels: {}}), '');
|
|
assert.equal(element._computeLabelValue({labels: {}}, 'Verified'), '');
|
|
assert.equal(element._computeLabelValue(
|
|
{labels: {Verified: {approved: true, value: 1}}}, 'Verified'), '✓');
|
|
assert.equal(element._computeLabelValue(
|
|
{labels: {Verified: {value: 1}}}, 'Verified'), '+1');
|
|
assert.equal(element._computeLabelValue(
|
|
{labels: {Verified: {value: -1}}}, 'Verified'), '-1');
|
|
assert.equal(element._computeLabelValue(
|
|
{labels: {Verified: {approved: true}}}, 'Verified'), '✓');
|
|
assert.equal(element._computeLabelValue(
|
|
{labels: {Verified: {rejected: true}}}, 'Verified'), '✕');
|
|
|
|
assert.equal(element._computeProjectURL('combustible/stuff'),
|
|
'/q/status:open+project:combustible%252Fstuff');
|
|
|
|
assert.equal(element._computeProjectBranchURL(
|
|
'combustible-stuff', 'le/mons'),
|
|
'/q/status:open+project:combustible-stuff+branch:le%252Fmons');
|
|
|
|
element.change = {_number: 42};
|
|
assert.equal(element.changeURL, '/c/42/');
|
|
element.change = {_number: 43};
|
|
assert.equal(element.changeURL, '/c/43/');
|
|
});
|
|
|
|
test('no hidden columns', function() {
|
|
element.visibleChangeTableColumns = [
|
|
'Subject',
|
|
'Status',
|
|
'Owner',
|
|
'Project',
|
|
'Branch',
|
|
'Updated',
|
|
'Size',
|
|
];
|
|
|
|
flushAsynchronousOperations();
|
|
|
|
element.columnNames.forEach(function(column) {
|
|
var elementClass = '.' + column.toLowerCase();
|
|
assert.isFalse(element.$$(elementClass).hidden);
|
|
});
|
|
});
|
|
|
|
test('no hidden columns', function() {
|
|
element.visibleChangeTableColumns = [
|
|
'Subject',
|
|
'Status',
|
|
'Owner',
|
|
'Project',
|
|
'Branch',
|
|
'Updated',
|
|
'Size',
|
|
];
|
|
|
|
flushAsynchronousOperations();
|
|
|
|
element.columnNames.forEach(function(column) {
|
|
var elementClass = '.' + column.toLowerCase();
|
|
assert.isFalse(element.$$(elementClass).hidden);
|
|
});
|
|
});
|
|
|
|
test('project column hidden', function() {
|
|
element.visibleChangeTableColumns = [
|
|
'Subject',
|
|
'Status',
|
|
'Owner',
|
|
'Branch',
|
|
'Updated',
|
|
'Size',
|
|
];
|
|
|
|
flushAsynchronousOperations();
|
|
|
|
element.columnNames.forEach(function(column) {
|
|
var elementClass = '.' + column.toLowerCase();
|
|
if (column === 'Project') {
|
|
assert.isTrue(element.$$(elementClass).hidden);
|
|
} else {
|
|
assert.isFalse(element.$$(elementClass).hidden);
|
|
}
|
|
});
|
|
});
|
|
|
|
test('random column does not exist', function() {
|
|
element.visibleChangeTableColumns = [
|
|
'Bad',
|
|
];
|
|
|
|
flushAsynchronousOperations();
|
|
var elementClass = '.bad';
|
|
assert.isNotOk(element.$$(elementClass));
|
|
});
|
|
|
|
});
|
|
</script>
|