opendev/gerrit
Code Issues Proposed changes
3a9e596cf0
gerrit/lib
History
Dave Borowitz 292fa154c1 Format all Java files with google-java-format 
Having a standard tool for formatting saves reviewers' valuable time.
google-java-format is Google's standard formatter and is somewhat
inspired by gofmt[1]. This commit formats everything using
google-java-format version 1.2.

The downside of this one-off formatting is breaking blame. This can be
somewhat hacked around with a tool like git-hyper-blame[2], but it's
definitely not optimal until/unless this kind of feature makes its way
to git core.

Not in this change:
* Tool support, e.g. Eclipse. The command must be run manually [3].
* Documentation of best practice, e.g. new 100-column default.

[1] https://talks.golang.org/2015/gofmt-en.slide#3
[2] https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html
[3] git ls-files | grep java$ | xargs google-java-format -i

Change-Id: Id5f3c6de95ce0b68b41f0a478b5c99a93675aaa3
Signed-off-by: David Pursehouse <dpursehouse@collab.net>
2017-02-07 10:04:39 +09:00
..
antlr Remove Buck based build 2017-01-23 12:44:58 +00:00
asciidoctor Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
auto Remove Buck based build 2017-01-23 12:44:58 +00:00
bouncycastle Remove Buck based build 2017-01-23 12:44:58 +00:00
codemirror Remove Buck based build 2017-01-23 12:44:58 +00:00
commons Remove Buck based build 2017-01-23 12:44:58 +00:00
dropwizard Remove Buck based build 2017-01-23 12:44:58 +00:00
easymock Remove Buck based build 2017-01-23 12:44:58 +00:00
elasticsearch Remove Buck based build 2017-01-23 12:44:58 +00:00
fonts Remove Buck based build 2017-01-23 12:44:58 +00:00
greenmail Remove Buck based build 2017-01-23 12:44:58 +00:00
guice Remove Buck based build 2017-01-23 12:44:58 +00:00
gwt Remove Buck based build 2017-01-23 12:44:58 +00:00
highlightjs Remove Buck based build 2017-01-23 12:44:58 +00:00
httpcomponents Remove Buck based build 2017-01-23 12:44:58 +00:00
jackson Remove Buck based build 2017-01-23 12:44:58 +00:00
jetty Remove Buck based build 2017-01-23 12:44:58 +00:00
jgit Remove Buck based build 2017-01-23 12:44:58 +00:00
joda Remove Buck based build 2017-01-23 12:44:58 +00:00
js bower2bazel: don't specify versions for non-seed packages. 2017-02-01 13:33:55 +01:00
jsoup Remove one last buck file from gerrit's core 2017-01-27 19:41:56 +00:00
log Remove Buck based build 2017-01-23 12:44:58 +00:00
lucene Remove Buck based build 2017-01-23 12:44:58 +00:00
mail Remove Buck based build 2017-01-23 12:44:58 +00:00
mime4j Remove Buck based build 2017-01-23 12:44:58 +00:00
mina Remove Buck based build 2017-01-23 12:44:58 +00:00
openid Remove Buck based build 2017-01-23 12:44:58 +00:00
ow2 Remove Buck based build 2017-01-23 12:44:58 +00:00
powermock Bazel: Fix powermock-core declaration 2017-01-24 23:31:15 +01:00
prolog Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
BUILD Bazel: Reformat build files 2016-12-07 11:33:07 +00:00
GUAVA_VERSION Allow to share guava definitions between buck and bazel builds 2016-10-26 15:46:27 +09:00
guava.bzl Format .bzl files with Bazel Buildifier 2016-12-11 19:00:21 +09:00
JGIT_VERSION Upgrade JGit to 4.6.0.201612231935-r.30-gd3148f300 2017-01-19 23:45:46 +00:00
LICENSE-antlr Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-Apache1.1 Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-Apache2.0 Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-args4j Synchronize args4j license with upstream 2016-06-07 18:59:40 +00:00
LICENSE-asciidoctor Add correct license for asciidoctor 2016-08-19 04:05:06 +00:00
LICENSE-automaton Synchronize automaton license with upstream 2016-06-09 09:31:58 +00:00
LICENSE-bouncycastle Synchronize bouncy castle license with upstream 2016-06-10 06:31:21 +02:00
LICENSE-CC-BY3.0-unported Clarify that the CC-BY 3.0 license is the unported version 2016-09-21 11:19:22 +02:00
LICENSE-clippy Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-codemirror-minified Use a pre-built minified CodeMirror in the release build 2016-04-04 20:33:27 -04:00
LICENSE-codemirror-original Use a pre-built minified CodeMirror in the release build 2016-04-04 20:33:27 -04:00
LICENSE-diffy Diffy should use the unported CC-BY 3.0 license 2016-09-21 11:26:15 +02:00
LICENSE-DO_NOT_DISTRIBUTE Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-es6-promise Add es6-promise for Internet Explorer 2016-09-13 15:14:32 +00:00
LICENSE-fetch Add fetch polyfill for use in all supported browsers 2016-03-03 23:49:18 -05:00
LICENSE-h2 Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-highlightjs Syntax highlighting 2016-07-25 13:47:30 -07:00
LICENSE-icu4j Adds the Soy library and injects it via EmailArguments 2016-08-22 09:45:33 -07:00
LICENSE-jgit Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-jsch Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-jsoup Add jsoup to Buck and Bazel 2016-11-16 01:24:59 +00:00
LICENSE-moment Recognize time format preferences. 2016-03-15 15:22:39 -07:00
LICENSE-MPL1.1 Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-OFL1.1 Serve fonts from Gerrit instead of Google Fonts. 2016-04-01 13:11:02 -04:00
LICENSE-ow2 Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-page.js Build bower_components with buck 2015-11-12 19:01:53 -05:00
LICENSE-polymer Build bower_components with buck 2015-11-12 19:01:53 -05:00
LICENSE-postgresql Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-prologcafe Update license text for PrologCafe 2013-05-13 09:44:25 -07:00
LICENSE-promise-polyfill Build bower_components with buck 2015-11-12 19:01:53 -05:00
LICENSE-protobuf Add dependency on the Google protocol buffer library 2013-09-10 15:59:25 -07:00
LICENSE-PublicDomain Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-silk_icons Synchronize license for silk icons 2016-09-21 11:04:46 +02:00
LICENSE-slf4j Build with Buck 2013-05-09 13:40:36 +00:00
LICENSE-xz Download commands: Add JGit archive 2014-03-03 23:34:46 +00:00