opendev/gerrit
Code Issues Proposed changes
Files
3bcb02f7eebfcffd434ab521c6f95def6c392718
gerrit/Documentation
History
Dave Borowitz 3b5fb8113f Remove DraftHandling.DELETE 
Using this as the default is more dangerous than useful: if a caller
forgets to populate the `drafts` field in ReviewInput, then drafts are
unceremoniously deleted. A much safer default is KEEP; this also comes
closest to preserving the old behavior, which also does not publish any
drafts. We don't know of anybody relying on DELETE as the default, but
just in case, this is probably the safest new default.

An alternative proposal[1] would phase out the old default more slowly.
However, given that the community couldn't come up with any use cases
for the old default[2], that much caution is unnecessary, especially
when compared with the real risk of data loss in the current state.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/140055
[2] https://groups.google.com/d/topic/repo-discuss/caWj8VqUVDY/discussion

Change-Id: Idd8cdd6e93c17f296dc62c400980323f0167ae9f
2018-01-09 15:21:06 -05:00
..
images
Use buck rule for ReleaseNotes instead of Makefile
2016-05-17 23:23:31 +00:00
.gitignore
Ignore /Documentation/*.html
2015-05-06 11:25:51 -07:00
access-control.txt
Merge branch 'stable-2.14' into stable-2.15
2017-10-20 15:42:59 +09:00
BUILD
Dissolve gerrit-pgm top-level directory
2017-10-31 11:02:37 -04:00
cmd-apropos.txt
Documentation: Also consider the use of kerberos authentication over SSH
2017-08-28 01:44:52 +02:00
cmd-ban-commit.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-cherry-pick.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-close-connection.txt
Fix broken synopsis formatting in documentation
2016-07-06 10:54:42 +02:00
cmd-create-account.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-create-branch.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-create-group.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-create-project.txt
Documentation: add REBASE_ALWAYS as submit type option where omitted
2017-08-27 23:37:33 +00:00
cmd-flush-caches.txt
Remove AccountByEmailCache
2017-08-08 14:24:34 +02:00
cmd-gc.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-gsql.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-hook-commit-msg.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-index-activate.txt
doc: add option and example section to ssh index command
2016-07-20 09:50:05 -07:00
cmd-index-changes.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-index-project.txt
Allow to index all changes of a project
2017-02-24 11:10:22 +00:00
cmd-index-start.txt
doc update: how to get online index status info
2016-08-15 13:57:37 -07:00
cmd-index.txt
Merge branch 'stable-2.13' into stable-2.14
2017-04-14 08:45:12 +09:00
cmd-kill.txt
Fix broken synopsis formatting in documentation
2016-07-06 10:54:42 +02:00
cmd-logging-ls-level.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-logging-set-level.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-ls-groups.txt
Documentation: Also consider the use of kerberos authentication over SSH
2017-08-28 01:44:52 +02:00
cmd-ls-members.txt
Documentation: Also consider the use of kerberos authentication over SSH
2017-08-28 01:44:52 +02:00
cmd-ls-projects.txt
Documentation: Also consider the use of kerberos authentication over SSH
2017-08-28 01:44:52 +02:00
cmd-ls-user-refs.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-plugin-enable.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-plugin-install.txt
Fix various typos, spelling mistakes, and inconsistencies
2016-09-06 16:27:49 +09:00
cmd-plugin-ls.txt
Fix broken synopsis formatting in documentation
2016-07-06 10:54:42 +02:00
cmd-plugin-reload.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-plugin-remove.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-query.txt
Documentation: Also consider the use of kerberos authentication over SSH
2017-08-28 01:44:52 +02:00
cmd-receive-pack.txt
Documentation: Also consider the use of kerberos authentication over SSH
2017-08-28 01:44:52 +02:00
cmd-rename-group.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-review.txt
Merge "PostReview: Remove support for 'strictLabels' option"
2017-10-12 12:50:47 +00:00
cmd-set-account.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-set-head.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-set-members.txt
Documentation: Also consider the use of kerberos authentication over SSH
2017-08-28 01:44:52 +02:00
cmd-set-project-parent.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-set-project.txt
Documentation: add REBASE_ALWAYS as submit type option where omitted
2017-08-27 23:37:33 +00:00
cmd-set-reviewers.txt
Fix changes not found
2017-10-18 21:55:15 -04:00
cmd-show-caches.txt
Remove unused subgroup cache
2017-10-30 10:23:44 -04:00
cmd-show-connections.txt
ShowConnections: Only show start and idle columns for mina backend
2016-08-04 05:55:37 +00:00
cmd-show-queue.txt
doc update: how to get online index status info
2016-08-15 13:57:37 -07:00
cmd-stream-events.txt
Private state changed event
2017-12-19 17:36:54 +01:00
cmd-suexec.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-test-submit-rule.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-test-submit-type.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-version.txt
Documentation: Also consider the use of kerberos authentication over SSH
2017-08-28 01:44:52 +02:00
concept-changes.txt
Add new topic, Changes, to documentation
2017-08-09 18:56:03 -07:00
concept-patch-sets.txt
Add new concept topic, Patch Sets, to documentation
2017-08-09 19:07:02 -07:00
concept-refs-for-namespace.txt
Add new concept topic on refs/for namespace
2017-08-09 19:02:17 -07:00
config-accounts.txt
Documentation: fix dead link to old NoteDb page location
2017-10-17 22:43:59 +02:00
config-auto-site-initialization.txt
Update Documentation of Auto Site Initialization
2017-03-01 08:18:24 +09:00
config-cla.txt
config-cla: Improve documentation of adding groups config
2016-08-22 17:46:31 +09:00
config-gerrit.txt
Merge "Add config to disable private changes"
2018-01-09 15:46:08 +00:00
config-gitweb.txt
Harmonize notation of admonition blocks in documentation
2016-07-08 15:42:31 +02:00
config-groups.txt
Documentation: describe NoteDb group storage
2017-12-05 15:57:58 +01:00
config-hooks.txt
Move hooks from core Gerrit to 'hooks' plugin
2016-07-04 11:06:18 +09:00
config-labels.txt
Merge branch 'stable-2.15'
2017-12-21 23:08:34 +00:00
config-login-register.txt
Use "gerrit" as the Gerrit user instead of "gerrit2"
2017-07-04 21:20:47 +09:00
config-mail.txt
Add shortOriginalSubject to change email template params
2017-10-30 13:57:31 -07:00
config-plugins.txt
Discontinue draft workflow
2017-09-30 15:47:14 +02:00
config-project-config.txt
Add rejectEmptyCommit project config
2018-01-09 14:37:08 +01:00
config-reverseproxy.txt
Update reverse proxy configuration example for nginx
2015-07-06 01:50:38 +00:00
config-robot-comments.txt
Add support for Robot Comments
2016-09-28 15:34:54 +02:00
config-sso.txt
config-sso.txt: Update sections that talk about external IDs
2017-08-29 14:51:36 +02:00
config-themes.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
config-validation.txt
Fix various typos in documentation
2017-03-03 15:54:53 +09:00
database-setup.txt
Revert "Update mysql-connector-java to 6.0.6"
2017-10-11 06:37:47 +00:00
dev-bazel.txt
Bazel: Document experimental local repository cache
2017-12-24 08:44:44 +01:00
dev-build-plugins.txt
Document how to bundle custom plugins in release.war
2017-12-21 18:05:38 +01:00
dev-contributing.txt
Merge branch 'stable-2.14' into stable-2.15
2017-10-20 22:06:15 +09:00
dev-design.txt
Update issue tracker URL in documentation
2016-06-23 06:48:12 +00:00
dev-eclipse.txt
Document how to add custom plugin(s) to eclipse project
2017-12-21 18:05:43 +01:00
dev-inspector.txt
Merge "Some more broken synopsis formattings in documentation"
2016-07-08 14:07:44 +00:00
dev-intellij.txt
Add description for debugging a remote Gerrit server
2017-03-03 10:12:14 +01:00
dev-plugins.txt
Support for GWT to PolyGerrit integration plugin migration
2017-12-08 20:21:59 -08:00
dev-polygerrit.txt
Add a very basic polygerrit documentation
2017-08-28 17:43:19 +00:00
dev-readme.txt
Add description for debugging a remote Gerrit server
2017-03-03 10:12:14 +01:00
dev-release-deploy-config.txt
dev-release: Add step to sign the announcement mail
2017-06-30 13:38:33 +09:00
dev-release-jgit.txt
Provide a diff file to make it easier to deploy JGit snapshot
2016-08-31 11:13:47 +09:00
dev-release-subproject.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
dev-release.txt
dev-release.txt: Use $version shell variable in invocation of version.py
2017-10-12 09:46:46 +09:00
dev-rest-api.txt
gerrit-server: use hashed passwords for HTTP.
2017-02-28 09:09:33 +01:00
dev-stars.txt
Replace Mute/Unmute by Mark as Reviewed/Unreviewed (Part 3)
2017-10-01 12:38:18 +00:00
error-branch-not-found.txt
Doc: Consistently refer to "Web UI" rather than "WebUI"
2014-05-02 17:21:22 +09:00
error-change-closed.txt
Doc: Consistently refer to "Web UI" rather than "WebUI"
2014-05-02 17:21:22 +09:00
error-change-does-not-belong-to-project.txt
Consistently refer to Change-Id in documentation
2014-09-04 13:12:24 +09:00
error-change-not-found.txt
Consistently refer to Change-Id in documentation
2014-09-04 13:12:24 +09:00
error-change-upload-blocked.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-commit-already-exists.txt
Merge branch 'stable-2.8'
2014-03-11 18:24:13 +09:00
error-contains-banned-commit.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-has-duplicates.txt
Fix some legacy-style titles in documentation
2016-07-08 13:45:28 +02:00
error-invalid-author.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-invalid-changeid-line.txt
Doc: Consistently refer to "Web UI" rather than "WebUI"
2014-05-02 17:21:22 +09:00
error-invalid-committer.txt
Fix reference to Forge Committer access right in documentation
2014-07-08 07:24:01 +00:00
error-messages.txt
Add limit to number of commits that ReceiveCommits will validate
2017-08-31 12:19:58 -04:00
error-missing-changeid.txt
Consistently refer to Change-Id in documentation
2014-09-04 13:12:24 +09:00
error-missing-subject.txt
Improve reject message if Change-Id is in subject
2014-02-21 09:25:33 +01:00
error-multiple-changeid-lines.txt
Doc: Consistently refer to "Web UI" rather than "WebUI"
2014-05-02 17:21:22 +09:00
error-no-common-ancestry.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-no-new-changes.txt
Update no-new-change error message documentation
2015-10-09 14:58:49 +00:00
error-non-fast-forward.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-not-a-gerrit-administrator.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-not-allowed-to-upload-merges.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-not-permitted-to-create.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-not-signed-off-by.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-not-valid-ref.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-permission-denied.txt
Documentation: Also consider the use of kerberos authentication over SSH
2017-08-28 01:44:52 +02:00
error-prohibited-by-gerrit.txt
Rename 'Push Annotated/Signed Tag' permission to 'Create Annotated/Signed Tag'
2016-09-08 13:50:04 +09:00
error-project-not-found.txt
Doc: Consistently refer to "Web UI" rather than "WebUI"
2014-05-02 17:21:22 +09:00
error-push-fails-due-to-commit-message.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-same-change-id-in-multiple-changes.txt
Provide more informative error message for Change-Id conflicts
2016-04-12 14:18:12 +00:00
error-too-many-commits.txt
Add limit to number of commits that ReceiveCommits will validate
2017-08-31 12:19:58 -04:00
error-upload-denied.txt
Fix some legacy-style titles in documentation
2016-07-08 13:45:28 +02:00
i18n-readme.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
index.txt
Documentation: describe NoteDb group storage
2017-12-05 15:57:58 +01:00
install-j2ee.txt
Fix broken formatting in Tomcat reverse proxy config documentation
2014-10-21 11:04:42 +09:00
install-quick.txt
Merge branch 'stable-2.14'
2017-07-14 13:25:19 +09:00
install.txt
Use "gerrit" as the Gerrit user instead of "gerrit2"
2017-07-04 21:20:47 +09:00
intro-gerrit-walkthrough.txt
Update introductory section of Gerrit documentation
2017-08-03 07:50:47 -07:00
intro-how-gerrit-works.txt
Update introductory section of Gerrit documentation
2017-08-03 07:50:47 -07:00
intro-project-owner.txt
Remove Buck based build
2017-01-23 12:44:58 +00:00
intro-quick.txt
Replace intro-quick.txt with contents of intro-product-overview.txt
2017-08-08 06:51:02 -07:00
intro-user.txt
Basic documentation of WIP in intro-user.txt
2017-10-26 14:26:30 -04:00
js-api.txt
Fix remaining legacy section title styles in documentation
2016-12-06 08:46:05 +09:00
json.txt
Populate ChangeAttribute with WIP and private status.
2017-12-19 17:36:50 +01:00
linux-quickstart.txt
linux-quickstart: Add missing path in example git config command
2017-11-04 00:45:48 +00:00
metrics.txt
RetryHelper: Rename and parameterize the metrics
2018-01-05 14:30:23 +01:00
note-db.txt
Documentation: describe NoteDb group storage
2017-12-05 15:57:58 +01:00
pg-plugin-dev.txt
Support for .settingsScreen() plugin API
2018-01-04 15:59:48 -08:00
pg-plugin-endpoints.txt
Create a robot-comment-controls plugin endpoint
2017-12-06 14:02:52 -08:00
pg-plugin-migration.txt
Support for GWT to PolyGerrit integration plugin migration
2017-12-08 20:21:59 -08:00
pg-plugin-repo-api.txt
Rename projects admin interface to repo
2017-12-27 21:40:31 +00:00
pg-plugin-settings-api.txt
Support for .settingsScreen() plugin API
2018-01-04 15:59:48 -08:00
pg-plugin-styling.txt
Proofreading PolyGerrit plugin dev docs
2017-12-05 16:09:26 -08:00
pgm-daemon.txt
Remove AccountByEmailCache
2017-08-08 14:24:34 +02:00
pgm-gsql.txt
Some more broken synopsis formattings in documentation
2016-07-08 13:47:29 +02:00
pgm-index.txt
Support Jdbc implementation of AccountPatchReviewStore
2017-04-26 09:28:57 +02:00
pgm-init.txt
init: Add a flag to force-delete the cache
2016-10-06 17:20:01 +02:00
pgm-LocalUsernamesToLowerCase.txt
Fix rendering in documentation of LocalUsernamesToLowerCase
2017-09-07 14:50:39 +00:00
pgm-MigrateAccountPatchReviewDb.txt
Documentation: Add --site-path to MigrateAccountPatchReviewDb command.
2017-10-19 22:57:25 +02:00
pgm-passwd.txt
Gerrit command line utility to set/update secure.config
2017-01-12 00:25:25 +00:00
pgm-prolog-shell.txt
Use "gerrit" as the Gerrit user instead of "gerrit2"
2017-07-04 21:20:47 +09:00
pgm-reindex.txt
Remove --dry-run option from reindex command documentation
2016-07-08 15:26:42 +02:00
pgm-rulec.txt
Some more broken synopsis formattings in documentation
2016-07-08 13:47:29 +02:00
pgm-SwitchSecureStore.txt
Some more broken synopsis formattings in documentation
2016-07-08 13:47:29 +02:00
project-configuration.txt
Support inheriting project submit type
2018-01-09 08:38:52 -05:00
prolog-change-facts.txt
Add pure_revert Prolog fact
2017-09-13 19:39:48 +02:00
prolog-cookbook.txt
Prolog cookbook: attribute success to uploader, not author
2017-12-27 14:28:04 -08:00
replace_macros.py
Set file encoding on replace_macros.py
2016-05-19 16:24:11 -04:00
rest-api-access.txt
Add a groups map ProjectAccessInfo.
2017-08-30 16:58:00 +02:00
rest-api-accounts.txt
Discontinue draft workflow
2017-09-30 15:47:14 +02:00
rest-api-changes.txt
Remove DraftHandling.DELETE
2018-01-09 15:21:06 -05:00
rest-api-config.txt
Add config to disable private changes
2018-01-09 15:22:31 +01:00
rest-api-documentation.txt
Remove Buck based build
2017-01-23 12:44:58 +00:00
rest-api-groups.txt
Revert "Deprecate group owner in API"
2017-11-13 13:31:34 +01:00
rest-api-plugins.txt
Disentangle ListPlugins and PluginLsCommand
2017-08-10 22:43:32 +01:00
rest-api-projects.txt
Merge changes Ib5711baa,I730e37bc
2018-01-09 14:46:48 +00:00
rest-api.txt
Support faster cross-domain XHR calls
2017-06-16 20:57:16 -07:00
user-change-cleanup.txt
Add background job to abandon inactive changes automatically
2015-06-25 07:26:25 +02:00
user-changeid.txt
Discontinue draft workflow
2017-09-30 15:47:14 +02:00
user-dashboards.txt
Add user guide
2015-04-30 14:37:09 +00:00
user-inline-edit.txt
RemoveDrafts: disallow creation of new drafts
2017-09-15 07:50:36 +02:00
user-named-destinations.txt
Add named destinations support
2015-09-03 10:50:07 -06:00
user-named-queries.txt
Move 'User Refs' docs to the intro-user doc.
2015-09-04 14:55:15 +00:00
user-notify.txt
Update "CC Me On Comments I Write" in docs
2017-09-25 17:20:06 +00:00
user-review-ui.txt
Discontinue draft workflow
2017-09-30 15:47:14 +02:00
user-search-accounts.txt
Fix mistakes in account search documentation
2017-01-02 15:00:22 +01:00
user-search-groups.txt
Add fields for members and subgroups to the group index
2017-09-13 14:57:46 +02:00
user-search-projects.txt
Document 'inname' and 'description' search operators for project queries
2017-10-13 13:54:25 +02:00
user-search.txt
Discontinue draft workflow
2017-09-30 15:47:14 +02:00
user-signedoffby.txt
Revert "== GERRIT" in documentation.
2014-03-25 19:44:49 +00:00
user-submodules.txt
Fix typos in the documentation
2016-11-15 18:20:16 -08:00
user-upload.txt
Allow percent encoding in patch set titles.
2017-10-30 12:54:42 -07:00