7416b235e4
Previously, on a changelist or file view, if you change the patchset to a lower number and then click the back button, dropdown value did not change properly. The issue was related to how the selected option was rendered in a dom-if. This change refactors the gr-select element to fit this use case. Bug: Issue 4800 Change-Id: I66ee5b7aba5421a01ca79f9e72a853a73c32e589
65 lines
2.3 KiB
HTML
65 lines
2.3 KiB
HTML
<!--
|
|
Copyright (C) 2015 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
<link rel="import" href="../../shared/gr-select/gr-select.html">
|
|
<link rel="import" href="../../../bower_components/polymer/polymer.html">
|
|
|
|
<dom-module id="gr-patch-range-select">
|
|
<template>
|
|
<style>
|
|
:host {
|
|
display: block;
|
|
}
|
|
.patchRange {
|
|
display: inline-block;
|
|
}
|
|
</style>
|
|
Patch set:
|
|
<span class="patchRange">
|
|
<select id="leftPatchSelect" bind-value="{{_leftSelected}}"
|
|
on-change="_handlePatchChange" is="gr-select">
|
|
<option value="PARENT">Base</option>
|
|
<template is="dom-repeat" items="{{availablePatches}}" as="patchNum">
|
|
<option value$="[[patchNum]]"
|
|
disabled$="[[_computeLeftDisabled(patchNum, patchRange)]]">[[patchNum]]</option>
|
|
</template>
|
|
</select>
|
|
</span>
|
|
<span is="dom-if" if="[[filesWeblinks.meta_a]]">
|
|
<template is="dom-repeat" items="[[filesWeblinks.meta_a]]" as="weblink">
|
|
<a target="_blank"
|
|
href$="[[weblink.url]]">[[weblink.name]]</a>
|
|
</template>
|
|
</span>
|
|
→
|
|
<span class="patchRange">
|
|
<select id="rightPatchSelect" bind-value="{{_rightSelected}}"
|
|
on-change="_handlePatchChange" is="gr-select">
|
|
<template is="dom-repeat" items="{{availablePatches}}" as="patchNum">
|
|
<option value$="[[patchNum]]"
|
|
disabled$="[[_computeRightDisabled(patchNum, patchRange)]]">[[patchNum]]</option>
|
|
</template>
|
|
</select>
|
|
<span is="dom-if" if="[[filesWeblinks.meta_b]]">
|
|
<template is="dom-repeat" items="[[filesWeblinks.meta_b]]" as="weblink">
|
|
<a target="_blank"
|
|
href$="[[weblink.url]]">[[weblink.name]]</a>
|
|
</template>
|
|
</span>
|
|
</span>
|
|
</template>
|
|
<script src="gr-patch-range-select.js"></script>
|
|
</dom-module>
|