Files
gerrit/polygerrit-ui/app/elements/diff/gr-selection-action-box/gr-selection-action-box_test.html
Kasper Nilsson 76aaa8cb33 Check for modifiers before creating comment
In some cases, the "press c to comment" feature was overriding default
browser copy behavior. This change checks for modifiers before creating
comments. This functionality is factored out into a function for future
use.

Bug: Issue 3989
Change-Id: I3ebe0dec2f5436b8339d81d99d1287799ff3568b
2016-09-27 16:10:09 -07:00

130 lines
4.2 KiB
HTML

<!DOCTYPE html>
<!--
Copyright (C) 2016 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
<title>gr-selection-action-box</title>
<script src="../../../bower_components/webcomponentsjs/webcomponents.min.js"></script>
<script src="../../../bower_components/web-component-tester/browser.js"></script>
<link rel="import" href="../../../bower_components/iron-test-helpers/iron-test-helpers.html">
<link rel="import" href="gr-selection-action-box.html">
<test-fixture id="basic">
<template>
<div>
<gr-selection-action-box></gr-selection-action-box>
<div class="target">some text</div>
</div>
</template>
</test-fixture>
<script>
suite('gr-selection-action-box', function() {
var container;
var element;
setup(function() {
container = fixture('basic');
element = container.querySelector('gr-selection-action-box');
sinon.stub(element, 'fire');
});
teardown(function() {
element.fire.restore();
});
test('ignores regular keys', function() {
MockInteractions.pressAndReleaseKeyOn(document.body, 27); // 'esc'
assert.isFalse(element.fire.called);
});
test('reacts to hotkey', function() {
MockInteractions.pressAndReleaseKeyOn(document.body, 67); // 'c'
assert.isTrue(element.fire.called);
});
test('event fired contains playload', function() {
var side = 'left';
var range = {
startLine: 1,
startChar: 11,
endLine: 2,
endChar: 42,
};
element.side = 'left';
element.range = range;
MockInteractions.pressAndReleaseKeyOn(document.body, 67); // 'c'
assert(element.fire.calledWithExactly(
'create-comment',
{
side: side,
range: range,
}));
});
suite('placeAbove', function() {
var target;
setup(function() {
target = container.querySelector('.target');
sinon.stub(container, 'getBoundingClientRect').returns(
{top: 1, bottom: 2, left: 3, right: 4, width: 50, height: 6});
sinon.stub(element, '_getTargetBoundingRect').returns(
{top: 42, bottom: 20, left: 30, right: 40, width: 100, height: 60});
sinon.stub(element, 'getBoundingClientRect').returns(
{width: 10, height: 10});
});
teardown(function() {
element.getBoundingClientRect.restore();
container.getBoundingClientRect.restore();
element._getTargetBoundingRect.restore();
});
test('placeAbove for Element argument', function() {
element.placeAbove(target);
assert.equal(element.style.top, '27px');
assert.equal(element.style.left, '72px');
});
test('placeAbove for Text Node argument', function() {
element.placeAbove(target.firstChild);
assert.equal(element.style.top, '27px');
assert.equal(element.style.left, '72px');
});
test('uses document.createRange', function() {
sinon.spy(document, 'createRange');
element._getTargetBoundingRect.restore();
sinon.spy(element, '_getTargetBoundingRect');
element.placeAbove(target.firstChild);
assert.isTrue(document.createRange.called);
document.createRange.restore();
});
});
test('_checkForModifiers', function() {
assert.isTrue(element._checkForModifiers({altKey: true}));
assert.isTrue(element._checkForModifiers({ctrlKey: true}));
assert.isTrue(element._checkForModifiers({metaKey: true}));
assert.isTrue(element._checkForModifiers({shiftKey: true}));
assert.isFalse(element._checkForModifiers({}));
});
});
</script>