gerrit/gerrit-acceptance-framework
Edwin Kempin 341baf22a0 Pass project to ChangeData so that it can load the change from notes
ChangeData currently loads the change directly from the database, but
now when we support notedb it should load the change via the change
notes factory. Loading the change via the change notes factory
requires the project name in addition to the change ID, hence
ChangeData must know it.

The only caller of ChangeData that cannot provide the project name is
HasDraftByLegacyPredicate. Due to this HasDraftByLegacyPredicate
loads the changes on its own from the database for now. We may remove
this deprecated predicate before migrating to notedb or find another
solution later.

When the change is now loaded from notedb its last modified timestamp
is only precise to seconds, while when its loaded from the database it
is precise to milliseconds. Due to this different changes got the same
last modified timestamp when notedb was enabled and as result the
GetRelatedIT#getRelatedReworkThenExtendInTheMiddleOfSeries test
started to fail. Defining a 1s time clock step for this test fixes
this issue.

Change-Id: Iee0dce795766f543c996d75fde4067cb23a357dd
Signed-off-by: Edwin Kempin <ekempin@google.com>
2016-02-05 12:14:25 +01:00
..
2015-11-09 21:44:27 +00:00