gerrit/gerrit-acceptance-tests
Edwin Kempin f64ef68bcd ChangeControl.GenericFactory#validateFor: Don't load change from db
All callers of ChangeControl.GenericFactory#validateFor(Change.Id,
CurrentUser) cannot provide the project name, which we would need to
load the change through ChangeNotes.Factory. Hence we need to lookup
the change from the index. Since we request no fields when looking up
the change from the index, rereading it is enforced, hence the change
we get back is not stale.

Move the methods to find changes from ChangeUtil into a separate
class. This is needed because ChangeUtil with all its dependencies
cannot be injected into ChangeControl.GenericFactory, but all those
dependencies are not needed for looking up changes from the index.

Change-Id: I9c2ee58486046f3a2ae80b588613b708a66d8306
Signed-off-by: Edwin Kempin <ekempin@google.com>
2016-02-05 12:51:04 +01:00
..
src/test/java/com/google/gerrit/acceptance ChangeControl.GenericFactory#validateFor: Don't load change from db 2016-02-05 12:51:04 +01:00
BUCK AbstractSubmit: Log observed ChangeMergedEvents 2016-02-02 08:39:42 -05:00
tests.defs Buck: Tweak unit test invocation and halve the run time 2015-10-16 08:25:43 +02:00