Files
gerrit/polygerrit-ui/app/embed/gr-diff.js
Dmitrii Filippov 1f9cac8d5d Avoid global Polymer variable in the code
This change replaces usages of Polymer global variable with imported
functions. The bundled-polymer.js are still imported, but only in entry
points: gr-app.js and embed/gr-diff.js as well as in test setup (to
still have Polymer available on `window` to plugins and embed usages).

Change-Id: I0afec9272c7bb752db7da23ca6364f64b230fe2b
2020-05-04 07:33:16 +00:00

38 lines
1.6 KiB
JavaScript

/**
* @license
* Copyright (C) 2020 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
window.Gerrit = window.Gerrit || {};
// TODO(dmfilippov): remove bundled-polymer.js imports when the following issue
// https://github.com/Polymer/polymer-resin/issues/9 is resolved.
// Because gr-diff.js is a shared component, it shouldn' pollute global
// variables. If an application wants to use Polymer global variable -
// the app must assign/import it and do not rely on the Polymer variable
// exposed by shared gr-diff component.
import '../scripts/bundled-polymer.js';
import '../elements/diff/gr-diff/gr-diff.js';
import '../elements/diff/gr-diff-cursor/gr-diff-cursor.js';
import {initDiffAppContext} from './gr-diff-app-context-init.js';
import {GrDiffLine} from '../elements/diff/gr-diff/gr-diff-line.js';
import {GrAnnotation} from '../elements/diff/gr-diff-highlight/gr-annotation.js';
// Setup appContext for diff.
// TODO (dmfilippov): find a better solution
initDiffAppContext();
// Setup global variables for existing usages of this component
window.GrDiffLine = GrDiffLine;
window.GrAnnotation = GrAnnotation;