405a8f53d3
In LuceneChangeIndex, we schedule the future by calling (essentially)
MoreExecutors.listeningDecorator(threadPool).submit()
this returns a TrustedListenableFutureTask, a Future implemented by
Guava, and we wait on this one.
The implementation passes this off to ScheduledThreadPoolExecutor for
running. This interprets it as a Runnable in
AbstractExecutorService#submit(), and a Runnable has no call surface
for cancellation. This means that the guava future is never canceled
if the corresponding ScheduledFutureTask is canceled.
Server#stop shuts down all thread pools. Since the pools are created
with
setExecuteExistingDelayedTasksAfterShutdownPolicy(false)
all pending work is canceled.
The problem would trigger in the following circumstances:
* For tests that schedule two or more ref updates at the end of the
test. Since the interactive pool has size 1, that could delay a
piece of work to be delayed.
* Executors are shutdown in creation order, which is random. It would
only trigger if the interactive pool was shutdown before the batch
pool.
The problem could be reliably reproduced by building with Bazel,
setting shard_count=30 on
//gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/project:rest_project,
and running shard 10 (which exhibited the problem) 50-way parallel on
a 12 HT-core system.
Things to note:
* If we have to use ListenableFutures, then it would be nice if we
could use a Executor that actually works together well with Guava.
* Server#stop discards pending work. In particular, work scheduled by
ReindexAfterUpdate can be discarded, potentially leaving the index
inconsistent.
* ReindexAfterUpdate runs in the batch executor, but then schedules
its search work on the interactive executor, which is gratuitously
parallel.
* WorkQueue.Executor is a lot of cognitive overhead for providing a
list of processes. Can't administrators just run jstack?
* A randomized creation order for threadpools causes randomized
shutdown order, making problems harder to reproduce.
Bug: Issue 4466
Change-Id: I55c3b85c66433de7ee9e037fc243abe705080bbc
|
||
|---|---|---|
| .settings | ||
| bucklets | ||
| contrib | ||
| Documentation | ||
| gerrit-acceptance-framework | ||
| gerrit-acceptance-tests | ||
| gerrit-antlr | ||
| gerrit-cache-h2 | ||
| gerrit-common | ||
| gerrit-elasticsearch | ||
| gerrit-extension-api | ||
| gerrit-gpg | ||
| gerrit-gwtdebug | ||
| gerrit-gwtexpui | ||
| gerrit-gwtui | ||
| gerrit-gwtui-common | ||
| gerrit-httpd | ||
| gerrit-index | ||
| gerrit-launcher | ||
| gerrit-lucene | ||
| gerrit-main | ||
| gerrit-oauth | ||
| gerrit-openid | ||
| gerrit-patch-commonsnet | ||
| gerrit-patch-jgit | ||
| gerrit-pgm | ||
| gerrit-plugin-api | ||
| gerrit-plugin-archetype | ||
| gerrit-plugin-gwt-archetype | ||
| gerrit-plugin-gwtui | ||
| gerrit-plugin-js-archetype | ||
| gerrit-prettify | ||
| gerrit-reviewdb | ||
| gerrit-server | ||
| gerrit-sshd | ||
| gerrit-util-cli | ||
| gerrit-util-http | ||
| gerrit-util-ssl | ||
| gerrit-war | ||
| lib | ||
| plugins | ||
| polygerrit-ui | ||
| ReleaseNotes | ||
| tools | ||
| website/releases | ||
| .bazelrc | ||
| .buckconfig | ||
| .buckversion | ||
| .editorconfig | ||
| .gitignore | ||
| .gitmodules | ||
| .mailmap | ||
| .pydevproject | ||
| .watchmanconfig | ||
| BUCK | ||
| BUILD | ||
| COPYING | ||
| INSTALL | ||
| README.md | ||
| SUBMITTING_PATCHES | ||
| VERSION | ||
| WORKSPACE | ||
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.