gerrit

History

Becky Siegel 41bdc04cb8 Don't merge threads on same line left/right

Goes along with c/95273/. Adds commentSide attribute to comments to see
which side of the diff view they belong on. This is also used as part
of the locationRange for the gr-diff-comment-thread-group, so that two
thread groups can be on the same line or range for the unified group (
one for the right, one for the left).

Note: there is already a 'side' attribute on the gr-diff-comment, which
is confusing. This side actually references 'PARENT' or 'REVISION', to
identify whether the comment belongs to the parent or any revision. On
diffs where two revisions are compared to each other, this cannot be
used to determine left/right. However, because 'side' is part of
the CommentInfo entity[1], it is difficult to change the name and make
more sense out of that.

[1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#comment-info

Bug: Issue 5114
Change-Id: I5cc4c17d4bb134e31e5cc07ff9b08ed349488c97

2017-02-07 21:00:52 +00:00

gr-diff-builder_test.html

Don't merge threads on same line left/right

2017-02-07 21:00:52 +00:00

gr-diff-builder-image.js

Establish annotation pipeline

2016-07-20 12:25:40 -07:00

gr-diff-builder-side-by-side.js

Allow multiple threads per line, with different ranges

2017-02-01 16:10:08 -08:00

gr-diff-builder-unified.js

Allow multiple threads per line, with different ranges