0ee62135f2
Sometimes avatars do not load on the change metadata or the dashboard. I found this is because the this._account check sometimes returns null which then cause it to hit the this.hidden = true. Because there was no setting hidden back to false, gr-avatar stayed permanently hidden even if "account" became defined. Bug: Issue 9851 Change-Id: I2627d7c830fc8825790f15359024496ff9e0e6be
193 lines
5.2 KiB
HTML
193 lines
5.2 KiB
HTML
<!DOCTYPE html>
|
|
<!--
|
|
@license
|
|
Copyright (C) 2015 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
|
<title>gr-avatar</title>
|
|
|
|
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
|
|
<script src="../../../bower_components/web-component-tester/browser.js"></script>
|
|
<link rel="import" href="../../../test/common-test-setup.html"/>
|
|
<link rel="import" href="gr-avatar.html">
|
|
|
|
<script>void(0);</script>
|
|
|
|
<test-fixture id="basic">
|
|
<template>
|
|
<gr-avatar></gr-avatar>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<script>
|
|
suite('gr-avatar tests', () => {
|
|
let element;
|
|
let sandbox;
|
|
|
|
setup(() => {
|
|
sandbox = sinon.sandbox.create();
|
|
element = fixture('basic');
|
|
});
|
|
|
|
teardown(() => {
|
|
sandbox.restore();
|
|
});
|
|
|
|
test('methods', () => {
|
|
assert.equal(element._buildAvatarURL(
|
|
{
|
|
_account_id: 123,
|
|
}),
|
|
'/accounts/123/avatar?s=16');
|
|
assert.equal(element._buildAvatarURL(
|
|
{
|
|
email: 'test@example.com',
|
|
}),
|
|
'/accounts/test%40example.com/avatar?s=16');
|
|
assert.equal(element._buildAvatarURL(
|
|
{
|
|
name: 'John Doe',
|
|
}),
|
|
'/accounts/John%20Doe/avatar?s=16');
|
|
assert.equal(element._buildAvatarURL(
|
|
{
|
|
username: 'John_Doe',
|
|
}),
|
|
'/accounts/John_Doe/avatar?s=16');
|
|
assert.equal(element._buildAvatarURL(
|
|
{
|
|
_account_id: 123,
|
|
avatars: [
|
|
{
|
|
url: 'https://cdn.example.com/s12-p/photo.jpg',
|
|
height: 12,
|
|
},
|
|
{
|
|
url: 'https://cdn.example.com/s16-p/photo.jpg',
|
|
height: 16,
|
|
},
|
|
{
|
|
url: 'https://cdn.example.com/s100-p/photo.jpg',
|
|
height: 100,
|
|
},
|
|
],
|
|
}),
|
|
'https://cdn.example.com/s16-p/photo.jpg');
|
|
assert.equal(element._buildAvatarURL(
|
|
{
|
|
_account_id: 123,
|
|
avatars: [
|
|
{
|
|
url: 'https://cdn.example.com/s95-p/photo.jpg',
|
|
height: 95,
|
|
},
|
|
],
|
|
}),
|
|
'/accounts/123/avatar?s=16');
|
|
assert.equal(element._buildAvatarURL(undefined), '');
|
|
});
|
|
|
|
test('dom for existing account', () => {
|
|
assert.isFalse(element.hasAttribute('hidden'));
|
|
|
|
sandbox.stub(element, '_getConfig', () => {
|
|
return Promise.resolve({plugin: {has_avatars: true}});
|
|
});
|
|
|
|
element.imageSize = 64;
|
|
element.account = {
|
|
_account_id: 123,
|
|
};
|
|
|
|
assert.strictEqual(element.style.backgroundImage, '');
|
|
|
|
// Emulate plugins loaded.
|
|
Gerrit._setPluginsPending([]);
|
|
|
|
Promise.all([
|
|
element.$.restAPI.getConfig(),
|
|
Gerrit.awaitPluginsLoaded(),
|
|
]).then(() => {
|
|
assert.isFalse(element.hasAttribute('hidden'));
|
|
|
|
assert.isTrue(
|
|
element.style.backgroundImage.includes('/accounts/123/avatar?s=64'));
|
|
});
|
|
});
|
|
|
|
test('dom for non available account', () => {
|
|
assert.isFalse(element.hasAttribute('hidden'));
|
|
|
|
sandbox.stub(element, '_getConfig', () => {
|
|
return Promise.resolve({plugin: {has_avatars: true}});
|
|
});
|
|
|
|
// Emulate plugins loaded.
|
|
Gerrit._setPluginsPending([]);
|
|
|
|
return Promise.all([
|
|
element.$.restAPI.getConfig(),
|
|
Gerrit.awaitPluginsLoaded(),
|
|
]).then(() => {
|
|
assert.isTrue(element.hasAttribute('hidden'));
|
|
|
|
assert.strictEqual(element.style.backgroundImage, '');
|
|
});
|
|
});
|
|
|
|
test('avatar config not set and account not set', () => {
|
|
assert.isFalse(element.hasAttribute('hidden'));
|
|
|
|
sandbox.stub(element, '_getConfig', () => {
|
|
return Promise.resolve({});
|
|
});
|
|
|
|
// Emulate plugins loaded.
|
|
Gerrit._setPluginsPending([]);
|
|
|
|
return Promise.all([
|
|
element.$.restAPI.getConfig(),
|
|
Gerrit.awaitPluginsLoaded(),
|
|
]).then(() => {
|
|
assert.isTrue(element.hasAttribute('hidden'));
|
|
});
|
|
});
|
|
|
|
test('avatar config not set and account set', () => {
|
|
assert.isFalse(element.hasAttribute('hidden'));
|
|
|
|
sandbox.stub(element, '_getConfig', () => {
|
|
return Promise.resolve({});
|
|
});
|
|
|
|
element.imageSize = 64;
|
|
element.account = {
|
|
_account_id: 123,
|
|
};
|
|
|
|
// Emulate plugins loaded.
|
|
Gerrit._setPluginsPending([]);
|
|
|
|
return Promise.all([
|
|
element.$.restAPI.getConfig(),
|
|
Gerrit.awaitPluginsLoaded(),
|
|
]).then(() => {
|
|
assert.isTrue(element.hasAttribute('hidden'));
|
|
});
|
|
});
|
|
});
|
|
</script>
|