4315f01324
Prior to this change, draft changes in search results may have resulted in touching the database, since ChangeControl#isDraftVisible checks if the user is a reviewer, and there are not enough stored fields to compute the reviewer set from the index. (We store approvals on the current patch set, not all approvals; even the latter would be insufficient with NoteDb.) Add a new reviewer field that stores enough information to reconstruct the whole ReviewerSet, and also to search by reviewer state. Shove this all in one repeated field with a little comma-separated format, similar to what we already do for labels. The current ReviewerPredicate implementation matches the old behavior of returning results independent of state, although it's now expressed as a predicate tree. Change-Id: Ie54b9e2decf847185ec741bc50bae7eb680787a0 |
||
---|---|---|
.. | ||
src | ||
BUCK |