Files
gerrit/polygerrit-ui/app/elements/shared/gr-account-label/gr-account-label.js
Kasper Nilsson e848b842f6 Add handling for undefined account names
Previously, in gr-account-label, an undefined name field resulted in a
completely empty tag. This is because, in general, the name field is
autopopulated by gerrit. However, there are some cases (like with
certain buildbots) where the name field was undefined. Now, in this
case, the email is still displayed.

Bug: Issue 4617
Change-Id: I91c54a8823b20b04dbed2a86b2b987ac34a0f0f9
2016-09-26 13:01:33 -07:00

49 lines
1.3 KiB
JavaScript

// Copyright (C) 2016 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
(function() {
'use strict';
Polymer({
is: 'gr-account-label',
properties: {
account: Object,
avatarImageSize: {
type: Number,
value: 32,
},
showEmail: {
type: Boolean,
value: false,
},
},
_computeAccountTitle: function(account) {
if (!account || (!account.name && !account.email)) { return; }
var result = '';
if (account.name) {
result += util.escapeHTML(account.name);
}
if (account.email) {
result += ' <' + util.escapeHTML(account.email) + '>';
}
return result;
},
_computeShowEmail: function(showEmail, account) {
return !!(showEmail && account && account.email);
},
});
})();