861c4a255f
So this has to do with the way Polymer does dirty checking from within dom-repeat. Since the underlying array instance identity was not changed, the dom-repeat would not trigger and the reply dialog was not updated properly. Additionally: + Guard against searching for a saved draft when discarding one that hasn’t been saved. + Move _files to be a compute function. Change-Id: Idc49f158cba7f908d50f163a6fdbd93fbe585462
60 lines
1.8 KiB
JavaScript
60 lines
1.8 KiB
JavaScript
// Copyright (C) 2016 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
(function() {
|
|
'use strict';
|
|
|
|
Polymer({
|
|
is: 'gr-comment-list',
|
|
|
|
properties: {
|
|
changeNum: Number,
|
|
comments: Object,
|
|
patchNum: Number,
|
|
},
|
|
|
|
_computeFilesFromComments: function(comments) {
|
|
return Object.keys(comments || {}).sort();
|
|
},
|
|
|
|
_computeFileDiffURL: function(file, changeNum, patchNum) {
|
|
return '/c/' + changeNum + '/' + patchNum + '/' + file;
|
|
},
|
|
|
|
_computeDiffLineURL: function(file, changeNum, patchNum, comment) {
|
|
var diffURL = this._computeFileDiffURL(file, changeNum, patchNum);
|
|
if (comment.line) {
|
|
// TODO(andybons): This is not correct if the comment is on the base.
|
|
diffURL += '#' + comment.line;
|
|
}
|
|
return diffURL;
|
|
},
|
|
|
|
_computeCommentsForFile: function(comments, file) {
|
|
// Changes are not picked up by the dom-repeat due to the array instance
|
|
// identity not changing even when it has elements added/removed from it.
|
|
return (comments[file] || []).slice();
|
|
},
|
|
|
|
_computePatchDisplayName: function(comment) {
|
|
if (comment.side == 'PARENT') {
|
|
return 'Base, ';
|
|
}
|
|
if (comment.patch_set != this.patchNum) {
|
|
return 'PS' + comment.patch_set + ', ';
|
|
}
|
|
return '';
|
|
}
|
|
});
|
|
})();
|