Files
gerrit/polygerrit-ui/app/elements/shared/gr-avatar/gr-avatar.js
Shawn Pearce 428061cd79 gr-avatar: avoid redirection through /avatar
Some REST APIs like /changes/ may return an "avatars" object within
the account with the avatar URL that /accounts/${id}/avatar would
redirect to:

    "owner": {
      "_account_id": 10...,
      "name": "Shawn Pearce",
      "email": "sop@google.com",
      "avatars": [
        {
          "url": "https://somegooglesite.com/.../photo.jpg",
          "height": 26
        }
      ]
    },

This can save an entire 302 redirect request with the backend server,
whose latency can be significant when displaying 25 rows on HTTP 1.1
when the browser is limited to 3 or 4 concurrent requests.

Change-Id: Ie60007b749c4fdb0071c4bed4fa808be45d30d45
2016-05-15 21:02:46 -07:00

70 lines
1.9 KiB
JavaScript

// Copyright (C) 2016 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
(function() {
'use strict';
Polymer({
is: 'gr-avatar',
properties: {
account: {
type: Object,
observer: '_accountChanged',
},
imageSize: {
type: Number,
value: 16,
},
},
created: function() {
this.hidden = true;
},
attached: function() {
this.$.restAPI.getConfig().then(function(cfg) {
var hasAvatars = !!(cfg && cfg.plugin && cfg.plugin.has_avatars);
if (hasAvatars) {
this.hidden = false;
this._updateAvatarURL(this.account); // src needs to be set if avatar becomes visible
}
}.bind(this));
},
_accountChanged: function(account) {
this._updateAvatarURL(account);
},
_updateAvatarURL: function(account) {
if (!this.hidden && account) {
var url = this._buildAvatarURL(this.account);
if (url) {
this.style.backgroundImage = 'url("' + url + '")';
}
}
},
_buildAvatarURL: function(account) {
if (!account) { return ''; }
var avatars = account.avatars || [];
for (var i = 0; i < avatars.length; i++) {
if (avatars[i].height === this.imageSize) {
return avatars[i].url;
}
}
return '/accounts/' + account._account_id + '/avatar?s=' + this.imageSize;
},
});
})();