4d22c7e835
+ This does not cover on-keydown handlers within elements. A follow-up change will account for those. + Keyboard shortcuts are disabled within gr-overlay, input, and textarea elements. + Added tests for new behavior (plus some missing ones covering broken behavior). + Removed blur hacks used on elements to placate the kb shortcuts due to restrictions that have been removed. Bug: Issue 4198 Change-Id: Ide8009a3bfc340a35a8ec8b9189a85b49c8a95aa
59 lines
1.4 KiB
JavaScript
59 lines
1.4 KiB
JavaScript
// Copyright (C) 2016 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
(function() {
|
|
'use strict';
|
|
|
|
Polymer({
|
|
is: 'gr-button',
|
|
|
|
properties: {
|
|
disabled: {
|
|
type: Boolean,
|
|
observer: '_disabledChanged',
|
|
reflectToAttribute: true,
|
|
},
|
|
_enabledTabindex: {
|
|
type: String,
|
|
value: '0',
|
|
},
|
|
},
|
|
|
|
behaviors: [
|
|
Gerrit.KeyboardShortcutBehavior,
|
|
Gerrit.TooltipBehavior,
|
|
],
|
|
|
|
hostAttributes: {
|
|
role: 'button',
|
|
tabindex: '0',
|
|
},
|
|
|
|
keyBindings: {
|
|
'space enter': '_handleCommitKey',
|
|
},
|
|
|
|
_disabledChanged: function(disabled) {
|
|
if (disabled) {
|
|
this._enabledTabindex = this.getAttribute('tabindex');
|
|
}
|
|
this.setAttribute('tabindex', disabled ? '-1' : this._enabledTabindex);
|
|
},
|
|
|
|
_handleCommitKey: function(e) {
|
|
e.preventDefault();
|
|
this.click();
|
|
},
|
|
});
|
|
})();
|