gerrit/gerrit-acceptance-tests
Simon Hwang fe1a9138fa Fix Incorrect owner group matching behaviour for creating projects
This change fixes a critical bug that might add a wrong group as an
owner of a project being created by ssh commands.

Before this fix, when the --owner argument does not match any group, the
commands tried to find a group whose name starts with the argument
instead of throwing an error to notify the user.

This behaviour seemed to be insecure and this fix prevents the commands
to create the project and throws an error if the --owner argument is not
valid, that is, if there is no exact match for the group name.

In total, the ssh commands that are affected by this change are:
CreateGroupCommand, CreateProjectCommand, ListGroupsCommand, and
SetMembersCommand. Moreover, it makes more sense to use exactSuggestion
instead of bestSuggestion for those commands as well.

Bug: Issue 3655
Change-Id: Icec00651b4268a2b70799f1cba739db5248b04f5
2015-11-09 09:55:01 -05:00
..
src/test/java/com/google/gerrit/acceptance Fix Incorrect owner group matching behaviour for creating projects 2015-11-09 09:55:01 -05:00
BUCK Revert "Allow tests to use hamcrest matchers directly" 2014-12-24 08:42:12 +00:00
tests.defs tests: Use insecure random for acceptance tests 2014-04-24 08:30:43 +02:00